Skip to content

[cms] add version to Node in Maintenance API (#2788) #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2024
Merged

[cms] add version to Node in Maintenance API (#2788) #2796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7e8ac9
[cms] add version to Node in Maintenance API (#2788)
shmel1k Mar 14, 2024
ead5bca
[cms] add comment for 'version' in maintenance api (#2817)
shmel1k Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ydb/core/cms/api_adapters.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ class TListClusterNodes: public TAdapterActor<
out.set_host(in.Host);
out.set_port(in.IcPort);
out.set_state(ConvertNodeState(in.State));
out.set_version(in.Version);
*out.mutable_start_time() = TimeUtil::MicrosecondsToTimestamp(in.StartTime.GetValue());

auto& location = *out.mutable_location();
Expand Down
3 changes: 3 additions & 0 deletions ydb/public/api/protos/draft/ydb_maintenance.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ message Node {
}
// start_time defines time when node was registered in cms.
google.protobuf.Timestamp start_time = 8;
// version defines YDB version for current Node.
// For example, 'ydb-stable-24-1'.
string version = 9;
}

message ListClusterNodesRequest {
Expand Down