Skip to content

Conversation

@n00bcracker
Copy link
Collaborator

Changelog entry

  1. Filled db names in remained SchemeCache requests
  2. Deleted filling db name in GRPC requests with default values
  3. Deleted unnecessary CanonizePath calls for db names

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@github-actions

This comment was marked as outdated.

@github-actions
Copy link

🟢 2025-10-29 13:13:16 UTC The validation of the Pull Request description is successful.

@github-actions

This comment was marked as outdated.

@n00bcracker n00bcracker self-assigned this Oct 30, 2025
@n00bcracker n00bcracker force-pushed the fill_db_name_in_scheme_cache_requests-4 branch from b266125 to 6bcc22c Compare October 30, 2025 14:50
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

2. Deleted filling db name in GRPC requests with default values
3. Deleted unnecessary CanonizePath calls for db names
@n00bcracker n00bcracker force-pushed the fill_db_name_in_scheme_cache_requests-4 branch from 6bcc22c to 8194541 Compare October 31, 2025 14:58
@n00bcracker n00bcracker marked this pull request as ready for review October 31, 2025 14:59
@n00bcracker n00bcracker requested review from a team as code owners October 31, 2025 14:59
@github-actions
Copy link

github-actions bot commented Oct 31, 2025

2025-10-31 15:00:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for f77d4c0 has started.
2025-10-31 15:01:09 UTC Artifacts will be uploaded here
2025-10-31 15:02:33 UTC ya make is running...
🟡 2025-10-31 16:37:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41097 38268 0 6 2793 30

2025-10-31 16:37:24 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-31 16:47:44 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
65 (only retried tests) 51 0 0 0 14

🟢 2025-10-31 16:47:46 UTC Build successful.
🟢 2025-10-31 16:48:02 UTC ydbd size 2.3 GiB changed* by -61.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4af0266 merge: f77d4c0 diff diff %
ydbd size 2 427 637 080 Bytes 2 427 574 152 Bytes -61.5 KiB -0.003%
ydbd stripped size 515 904 712 Bytes 515 897 928 Bytes -6.6 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

2025-10-31 15:02:06 UTC Pre-commit check linux-x86_64-release-asan for f77d4c0 has started.
2025-10-31 15:02:23 UTC Artifacts will be uploaded here
2025-10-31 15:03:51 UTC ya make is running...
🟡 2025-10-31 17:31:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17495 16685 0 427 345 38

🟢 2025-10-31 17:31:52 UTC Build successful.
🟢 2025-10-31 17:32:19 UTC ydbd size 3.8 GiB changed* by -66.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4af0266 merge: f77d4c0 diff diff %
ydbd size 4 065 299 928 Bytes 4 065 231 952 Bytes -66.4 KiB -0.002%
ydbd stripped size 1 509 159 304 Bytes 1 509 154 984 Bytes -4.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Collaborator

@nikvas0 nikvas0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kqp ok

@n00bcracker n00bcracker removed the request for review from a-serebryanskiy November 3, 2025 09:01
@n00bcracker n00bcracker merged commit 72fd04f into ydb-platform:main Nov 5, 2025
13 checks passed
@n00bcracker n00bcracker deleted the fill_db_name_in_scheme_cache_requests-4 branch November 5, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants