Skip to content

Conversation

@igormunkin
Copy link
Collaborator

@igormunkin igormunkin commented Mar 14, 2024

Within this changeset String::Contains UDF is rewritten to provide both scalar and block implementations. <STROKA_FIND_UDF> macro used for generating this function definition is left untouched, since all other functions listed in <STROKA_FIND_UDF_MAP> are marked as deprecated1. The same comment is left for the functions String::Substring,
String::Find and String::ReverseFind and functions listed in <STROKA_UDF_MAP> and <STRING_TWO_ARGS_UDF_MAP> macros.

Besides, TBlockItem type constructor with <bool> parameter, that follows YQL <-> arrow type mapping convention, is implemented and used to yield the String::Contains block kernel result.

Changelog category

  • Improvement

@github-actions
Copy link

github-actions bot commented Mar 14, 2024

2024-03-14 15:05:29 UTC Pre-commit check for 13bdd0c has started.
2024-03-14 15:05:31 UTC Build linux-x86_64-release-asan is running...
2024-03-14 15:39:56 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 14, 2024

2024-03-14 15:05:44 UTC Pre-commit check for 13bdd0c has started.
2024-03-14 15:05:46 UTC Build linux-x86_64-release-cmake14 is running...
2024-03-14 15:39:58 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 14, 2024

2024-03-14 15:09:39 UTC Pre-commit check for 13bdd0c has started.
2024-03-14 15:09:40 UTC Build linux-x86_64-relwithdebinfo is running...
2024-03-14 15:39:56 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 14, 2024

2024-03-14 15:48:50 UTC Pre-commit check for 57b46e9 has started.
2024-03-14 15:48:52 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-14 16:01:30 UTC Build successful.
2024-03-14 16:01:45 UTC Tests are running...
🔴 2024-03-14 18:06:26 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15061 14496 0 63 475 27

@github-actions
Copy link

github-actions bot commented Mar 14, 2024

2024-03-14 15:49:07 UTC Pre-commit check for 57b46e9 has started.
2024-03-14 15:49:09 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-14 16:00:08 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Mar 14, 2024

2024-03-14 15:57:20 UTC Pre-commit check for 57b46e9 has started.
2024-03-14 15:57:22 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-14 16:09:32 UTC Build successful.
2024-03-14 16:09:41 UTC Tests are running...
🔴 2024-03-14 18:08:42 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68374 57416 0 4 10930 24

@github-actions
Copy link

github-actions bot commented Mar 15, 2024

2024-03-15 06:42:42 UTC Pre-commit check for 91b0aa4 has started.
2024-03-15 06:42:45 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-15 06:50:29 UTC Build successful.
2024-03-15 06:50:48 UTC Tests are running...
🔴 2024-03-15 08:59:46 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15062 14483 0 71 480 28

@github-actions
Copy link

github-actions bot commented Mar 15, 2024

2024-03-15 06:42:42 UTC Pre-commit check for 91b0aa4 has started.
2024-03-15 06:42:45 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-15 06:49:56 UTC Build successful.
2024-03-15 06:50:09 UTC Tests are running...
🔴 2024-03-15 08:42:50 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68373 57419 0 4 10930 20

@github-actions
Copy link

github-actions bot commented Mar 15, 2024

2024-03-15 06:42:44 UTC Pre-commit check for 91b0aa4 has started.
2024-03-15 06:42:47 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-15 06:52:36 UTC Build successful.

Within this changeset String::Contains UDF is rewritten to provide both
scalar and block implementations. <STROKA_FIND_UDF> macro used for
generating this function definition is left untouched, since all other
functions listed in <STROKA_FIND_UDF_MAP> are marked as deprecated[1].
The same comment is left for the functions String::Substring,
String::Find and String::ReverseFind, and functions listed in
<STROKA_UDF_MAP> and <STRING_TWO_ARGS_UDF_MAP> macros.

Besides, TBlockItem type constructor with <bool> parameter, that follows
YQL <-> arrow type mapping convention, is implemented and used to yield
the String::Contains block kernel result.

[1]: https://ydb.tech/docs/ru/yql/reference/udf/list/string
@github-actions
Copy link

github-actions bot commented Mar 15, 2024

2024-03-15 09:22:20 UTC Pre-commit check for 761379b has started.
2024-03-15 09:22:23 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-15 09:23:31 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Mar 15, 2024

2024-03-15 09:22:21 UTC Pre-commit check for 761379b has started.
2024-03-15 09:22:24 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-15 09:23:30 UTC Build successful.
2024-03-15 09:23:43 UTC Tests are running...
🟢 2024-03-15 11:05:51 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68373 57421 0 0 10930 22

@github-actions
Copy link

github-actions bot commented Mar 15, 2024

2024-03-15 09:22:22 UTC Pre-commit check for 761379b has started.
2024-03-15 09:22:26 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-15 09:23:29 UTC Build successful.
2024-03-15 09:23:42 UTC Tests are running...
🔴 2024-03-15 11:19:25 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15053 14476 0 71 478 28

@igormunkin igormunkin marked this pull request as ready for review March 15, 2024 12:33
@igormunkin igormunkin requested a review from a team as a code owner March 15, 2024 12:33
@shnikd shnikd mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants