Skip to content

Conversation

rosik
Copy link
Collaborator

@rosik rosik commented Oct 9, 2025

Changelog entry

  • Changelog entry isn't necessary because the bug couldn't affect users, just the test was flaky

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

The flaky test revealed a bug which couldn't affect users though, just the test was flaky.

The test expects that after a PDisk restart, all previously sent TEvLog events will be answered with either ok or with error. The check is based on counting TEvLogResult.Results.size() (permalink). The TEvLogResult (CORRUPTED) can be sent from 2 places: TLogWrite::Abort (permalink) that is fine, and from TCompletionLogWrite::Release (permalink) which is missing Results field. The flakiness appeared because the second case is reproduced infrequently.

@rosik rosik requested a review from va-kuznecov October 9, 2025 14:21
@github-actions github-actions bot added the bugfix label Oct 9, 2025
Copy link

github-actions bot commented Oct 9, 2025

🟢 2025-10-10 09:54:47 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Oct 9, 2025

2025-10-10 07:57:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8b062b7 has started.
2025-10-10 07:57:54 UTC Artifacts will be uploaded here
2025-10-10 08:01:42 UTC ya make is running...
🟡 2025-10-10 09:39:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39356 36568 0 5 2752 31

2025-10-10 09:39:40 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-10 09:56:50 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
697 (only retried tests) 671 0 0 2 24

🟢 2025-10-10 09:56:53 UTC Build successful.
🟢 2025-10-10 09:57:07 UTC ydbd size 2.3 GiB changed* by +1.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a446a72 merge: 8b062b7 diff diff %
ydbd size 2 418 700 232 Bytes 2 418 701 832 Bytes +1.6 KiB +0.000%
ydbd stripped size 515 107 272 Bytes 515 107 336 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 9, 2025

2025-10-09 14:45:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8b062b7 has started.

Copy link

github-actions bot commented Oct 9, 2025

2025-10-09 14:46:02 UTC Pre-commit check linux-x86_64-release-asan for 8b062b7 has started.
2025-10-09 14:46:45 UTC Artifacts will be uploaded here
2025-10-09 14:51:03 UTC ya make is running...
🟡 2025-10-09 16:55:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16395 15870 0 231 273 21

🟢 2025-10-09 16:55:06 UTC Build successful.
🟢 2025-10-09 16:55:30 UTC ydbd size 3.7 GiB changed* by +1.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a446a72 merge: 8b062b7 diff diff %
ydbd size 4 023 586 624 Bytes 4 023 588 000 Bytes +1.3 KiB +0.000%
ydbd stripped size 1 494 478 880 Bytes 1 494 478 944 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 10, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 10, 2025
@rosik rosik merged commit 2f4d3b2 into ydb-platform:main Oct 10, 2025
33 of 42 checks passed
@rosik rosik deleted the fix-flaky-pdisk-ut branch October 10, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mute ydb/core/blobstorage/pdisk/ut 2 tests in main

4 participants