-
Notifications
You must be signed in to change notification settings - Fork 723
Fix flaky TPDiskTest::TestStartEncryptedOrPlainAndRestart #26616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🟢 |
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
Changelog category
Description for reviewers
The flaky test revealed a bug which couldn't affect users though, just the test was flaky.
The test expects that after a PDisk restart, all previously sent TEvLog events will be answered with either ok or with error. The check is based on counting
TEvLogResult.Results.size()
(permalink). The TEvLogResult (CORRUPTED) can be sent from 2 places:TLogWrite::Abort
(permalink) that is fine, and fromTCompletionLogWrite::Release
(permalink) which is missing Results field. The flakiness appeared because the second case is reproduced infrequently.