Refactor password options in YDB CLI #23350
Conversation
|
🟢 |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| @@ -651,7 +656,7 @@ std::vector<TString> TOptionsParseResult::ParseFromProfilesAndEnv(std::shared_pt | |||
| auto applyOption = [&](const TIntrusivePtr<TClientCommandOption>& clientOption, const TString& value, bool isFileName, const TString& humanReadableFileName, EOptionValueSource valueSource) { | |||
| if (clientOption->HandlerImpl(value, isFileName, humanReadableFileName, valueSource)) { // returns false only when loading from default value from file | |||
| Opts.emplace_back(clientOption, value, valueSource); | |||
| if (dynamic_cast<const TAuthMethodOption*>(clientOption.Get())) { | |||
| if (clientOption.Get()->IsMainAuthOption()) { | |||
There was a problem hiding this comment.
if (clientOption->IsMainAuthOption()) {
| }, | ||
| profile); | ||
|
|
||
| // user from explicit profile + --password-file option |
There was a problem hiding this comment.
I think that there is one more interesting case: user from explicit profile, password from active profile. I would say that ydb cli should ask for password in this case.
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
Changelog category
Description for reviewers