Skip to content

YQ-2068 remove unused ProgramBuilder for transformer #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2024
Merged

YQ-2068 remove unused ProgramBuilder for transformer #2162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ydb/library/yql/dq/actors/compute/dq_compute_actor_async_io.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,9 @@ struct IDqAsyncIoFactory : public TThrRefBase {
IRandomProvider *const RandomProvider;
};

//TODO (YQ-2068) temporary flag for changing interface
#define Y_YQL_DQ_NO_PROGRAM_BUILDER_FOR_TRANSFORM

struct TInputTransformArguments {
const NDqProto::TTaskInput& InputDesc;
const ui64 InputIndex;
Expand All @@ -246,7 +249,6 @@ struct IDqAsyncIoFactory : public TThrRefBase {
const NActors::TActorId& ComputeActorId;
const NKikimr::NMiniKQL::TTypeEnvironment& TypeEnv;
const NKikimr::NMiniKQL::THolderFactory& HolderFactory;
NKikimr::NMiniKQL::TProgramBuilder& ProgramBuilder;
std::shared_ptr<NKikimr::NMiniKQL::TScopedAlloc> Alloc;
NWilson::TTraceId TraceId;
};
Expand All @@ -263,7 +265,6 @@ struct IDqAsyncIoFactory : public TThrRefBase {
const THashMap<TString, TString>& TaskParams;
const NKikimr::NMiniKQL::TTypeEnvironment& TypeEnv;
const NKikimr::NMiniKQL::THolderFactory& HolderFactory;
NKikimr::NMiniKQL::TProgramBuilder& ProgramBuilder;
};

// Creates source.
Expand Down
6 changes: 0 additions & 6 deletions ydb/library/yql/dq/actors/compute/dq_compute_actor_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,7 +801,6 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>

struct TAsyncInputTransformHelper : TAsyncInputHelper {
NUdf::TUnboxedValue InputBuffer;
TMaybe<NKikimr::NMiniKQL::TProgramBuilder> ProgramBuilder;

using TAsyncInputHelper::TAsyncInputHelper;
};
Expand Down Expand Up @@ -936,7 +935,6 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>

struct TAsyncOutputTransformInfo : public TAsyncOutputInfoBase {
IDqOutputConsumer::TPtr OutputBuffer;
TMaybe<NKikimr::NMiniKQL::TProgramBuilder> ProgramBuilder;
};

protected:
Expand Down Expand Up @@ -1281,7 +1279,6 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>
this->RegisterWithSameMailbox(source.Actor);
}
for (auto& [inputIndex, transform] : InputTransformsMap) {
transform.ProgramBuilder.ConstructInPlace(typeEnv, *FunctionRegistry);
Y_ABORT_UNLESS(AsyncIoFactory);
const auto& inputDesc = Task.GetInputs(inputIndex);
CA_LOG_D("Create transform for input " << inputIndex << " " << inputDesc.ShortDebugString());
Expand All @@ -1299,7 +1296,6 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>
.ComputeActorId = this->SelfId(),
.TypeEnv = typeEnv,
.HolderFactory = holderFactory,
.ProgramBuilder = *transform.ProgramBuilder,
.Alloc = Alloc,
.TraceId = ComputeActorSpan.GetTraceId()
});
Expand All @@ -1309,7 +1305,6 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>
this->RegisterWithSameMailbox(transform.Actor);
}
for (auto& [outputIndex, transform] : OutputTransformsMap) {
transform.ProgramBuilder.ConstructInPlace(typeEnv, *FunctionRegistry);
Y_ABORT_UNLESS(AsyncIoFactory);
const auto& outputDesc = Task.GetOutputs(outputIndex);
CA_LOG_D("Create transform for output " << outputIndex << " " << outputDesc.ShortDebugString());
Expand All @@ -1326,7 +1321,6 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>
.TaskParams = taskParams,
.TypeEnv = typeEnv,
.HolderFactory = holderFactory,
.ProgramBuilder = *transform.ProgramBuilder
});
} catch (const std::exception& ex) {
throw yexception() << "Failed to create output transform " << outputDesc.GetTransform().GetType() << ": " << ex.what();
Expand Down