Skip to content

Conversation

@va-kuznecov
Copy link
Member

@va-kuznecov va-kuznecov commented Jul 16, 2025

Changelog entry

Add new handler for error we saw on our cluster. After change we will get a readable error instead of VERIFY

Changelog category

  • Not for changelog

Description for reviewers

...

@github-actions github-actions bot added bugfix and removed bugfix labels Jul 16, 2025
Copy link
Collaborator

@SammyVimes SammyVimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Jul 16, 2025

2025-07-16 08:18:21 UTC Pre-commit check linux-x86_64-release-asan for 582dfaa has started.
2025-07-16 08:18:47 UTC Artifacts will be uploaded here
2025-07-16 08:22:35 UTC ya make is running...
🟡 2025-07-16 10:53:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16354 15959 0 131 237 27

🟢 2025-07-16 10:54:35 UTC Build successful.
🟢 2025-07-16 10:55:05 UTC ydbd size 3.9 GiB changed* by +64 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 973850d merge: 582dfaa diff diff %
ydbd size 4 210 160 328 Bytes 4 210 160 392 Bytes +64 Bytes +0.000%
ydbd stripped size 1 459 369 240 Bytes 1 459 369 304 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 16, 2025

🟢 2025-07-16 09:28:10 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Jul 16, 2025

2025-07-16 11:20:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 582dfaa has started.
2025-07-16 11:20:24 UTC Artifacts will be uploaded here
2025-07-16 11:23:59 UTC ya make is running...
🟡 2025-07-16 13:20:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38800 36043 0 4 2709 44

2025-07-16 13:25:10 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-16 13:45:54 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
705 (only retried tests) 656 0 0 25 24

🟢 2025-07-16 13:46:12 UTC Build successful.
🟢 2025-07-16 13:46:35 UTC ydbd size 2.2 GiB changed* by +48 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 973850d merge: 582dfaa diff diff %
ydbd size 2 394 334 704 Bytes 2 394 334 752 Bytes +48 Bytes +0.000%
ydbd stripped size 500 845 352 Bytes 500 845 416 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@va-kuznecov va-kuznecov enabled auto-merge (squash) July 16, 2025 11:46
@va-kuznecov va-kuznecov merged commit 20b8d68 into ydb-platform:main Jul 16, 2025
16 of 18 checks passed
@va-kuznecov va-kuznecov deleted the dev/pdisk_no_device_error branch July 17, 2025 11:55
va-kuznecov added a commit to va-kuznecov/ydb that referenced this pull request Jul 17, 2025
va-kuznecov added a commit to va-kuznecov/ydb that referenced this pull request Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants