Report inferred PDisk SlotCount in metrics #21115
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR exposes inferred PDisk ExpectedSlotCount and SlotSizeInUnits in metrics, skips inference when explicit config is set, and updates tooling and tests to reflect these new fields.
- Add
SlotCountandSlotSizeInUnitstoTPDiskMetricsin the proto definition. - Populate the new metrics in the PDisk whiteboard report and controller update.
- Adjust node warden logic to respect explicit
PDiskConfig, update unit tests, and enhancedstooloutput with metric fields.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ydb/core/protos/blobstorage_disk.proto | Added two optional fields (SlotCount, SlotSizeInUnits) to metrics proto. |
| ydb/core/blobstorage/pdisk/blobstorage_pdisk_impl.cpp | Populated new metrics fields in whiteboard and controller update. |
| ydb/core/blobstorage/nodewarden/node_warden_pdisk.cpp | Skip inferring slot count when explicit config values are set. |
| ydb/core/blobstorage/nodewarden/blobstorage_node_warden_ut.cpp | Updated CreatePDisk signature, modified existing test, and added a test for explicit config. |
| ydb/apps/dstool/lib/dstool_cmd_pdisk_list.py | Show new metrics fields in pdisk list, falling back to config when metrics are absent. |
Comments suppressed due to low confidence (1)
ydb/core/blobstorage/nodewarden/blobstorage_node_warden_ut.cpp:1026
- The new test uses
CUSTOM_UNIT_TEST, which may not be registered by the existing test suite. Use the standardY_UNIT_TESTmacro to ensure this test is discovered and executed.
CUSTOM_UNIT_TEST(TestInferPDiskSlotCountExplicitConfig) {
|
🟢 |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢 |
rosik
force-pushed
the
report-inferred-pdisk-slot-count
branch
from
81f48a3 to
83b365c
Compare
rosik
force-pushed
the
report-inferred-pdisk-slot-count
branch
from
83b365c to
09dd7a5
Compare
rosik
force-pushed
the
report-inferred-pdisk-slot-count
branch
from
09dd7a5 to
b0f921a
Compare
|
⚪ Test history | Ya make output | Test bloat
🟢 |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢 |
Changelog category
Description for reviewers
This PR includes two changes:
ExpectedSlotCountandSlotSizeInUnitsto PDiskMetrics so it can be inspected withdstool(tested manually, missing unit-test)PDiskConfig(don't override them with inferred values) and test it