Skip to content

Fix VDisk compaction race (merge from main #21048) #21081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: stable-25-1
Choose a base branch
from

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Jul 14, 2025

Changelog entry

Fix VDisk compaction race

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

This patch fixes vdisk compaction race leading to possible data corruption when two compactions are started concurrently.

@alexvru alexvru requested a review from a team as a code owner July 14, 2025 11:51
Copy link

🟢 2025-07-14 11:52:02 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Jul 14, 2025

2025-07-14 11:52:50 UTC Pre-commit check linux-x86_64-release-asan for 7433113 has started.
2025-07-14 11:53:03 UTC Artifacts will be uploaded here
2025-07-14 11:55:50 UTC ya make is running...
🟡 2025-07-14 13:12:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12900 12814 0 20 29 37

2025-07-14 13:13:40 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-07-14 13:36:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
125 (only retried tests) 70 0 4 17 34

2025-07-14 13:36:54 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-07-14 13:59:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
82 (only retried tests) 40 0 3 6 33

🟢 2025-07-14 13:59:47 UTC Build successful.
🟢 2025-07-14 14:00:16 UTC ydbd size 3.7 GiB changed* by +2.7 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: c697d92 merge: 7433113 diff diff %
ydbd size 4 013 973 968 Bytes 4 013 976 768 Bytes +2.7 KiB +0.000%
ydbd stripped size 1 400 781 624 Bytes 1 400 782 648 Bytes +1.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 14, 2025

2025-07-14 12:15:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7433113 has started.
2025-07-14 12:16:07 UTC Artifacts will be uploaded here
2025-07-14 12:19:05 UTC ya make is running...
🟡 2025-07-14 13:34:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20030 18749 0 8 1225 48

2025-07-14 13:36:08 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-07-14 13:59:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
103 (only retried tests) 60 0 3 0 40

2025-07-14 13:59:59 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-07-14 14:29:57 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74 (only retried tests) 32 0 3 0 39

🟢 2025-07-14 14:30:08 UTC Build successful.
🟢 2025-07-14 14:30:33 UTC ydbd size 2.1 GiB changed* by +1.5 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: c697d92 merge: 7433113 diff diff %
ydbd size 2 305 728 456 Bytes 2 305 730 008 Bytes +1.5 KiB +0.000%
ydbd stripped size 484 702 048 Bytes 484 702 496 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge July 14, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants