-
Notifications
You must be signed in to change notification settings - Fork 695
Added OverridePlanner validation #19945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added OverridePlanner validation #19945
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds validation for the OverridePlanner settings by introducing a new function to parse and validate JSON configuration, and by updating the query compiler to aggregate and report any configuration errors.
- Introduces ApplyOverridePlannerSettings to validate the JSON override planner settings.
- Updates the override planner logic to collect and report issues through ctx.
Comments suppressed due to low confidence (1)
ydb/core/kqp/query_compiler/kqp_query_compiler.cpp:511
- [nitpick] Consider renaming the lambda 'extractUint' to a more descriptive name like 'ExtractUnsignedInt' to enhance code readability.
const auto extractUint = [](const NJson::TJsonValue& node, ui32* result) -> TString {
🟢 |
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
Added OverridePlanner validation
Changelog category
Description for reviewers