Skip to content

Added OverridePlanner validation #19945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

GrigoriyPA
Copy link
Collaborator

Changelog entry

Added OverridePlanner validation

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner June 20, 2025 07:33
@GrigoriyPA GrigoriyPA requested a review from Copilot June 20, 2025 07:33
@GrigoriyPA GrigoriyPA requested a review from Hor911 June 20, 2025 07:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds validation for the OverridePlanner settings by introducing a new function to parse and validate JSON configuration, and by updating the query compiler to aggregate and report any configuration errors.

  • Introduces ApplyOverridePlannerSettings to validate the JSON override planner settings.
  • Updates the override planner logic to collect and report issues through ctx.
Comments suppressed due to low confidence (1)

ydb/core/kqp/query_compiler/kqp_query_compiler.cpp:511

  • [nitpick] Consider renaming the lambda 'extractUint' to a more descriptive name like 'ExtractUnsignedInt' to enhance code readability.
    const auto extractUint = [](const NJson::TJsonValue& node, ui32* result) -> TString {

Copy link

🟢 2025-06-20 07:35:22 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Jun 20, 2025

2025-06-20 07:35:42 UTC Pre-commit check linux-x86_64-release-asan for 06999ba has started.
2025-06-20 07:35:54 UTC Artifacts will be uploaded here
2025-06-20 07:36:23 UTC Check cancelled

Copy link

github-actions bot commented Jun 20, 2025

2025-06-20 07:35:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 06999ba has started.
2025-06-20 07:35:55 UTC Artifacts will be uploaded here
2025-06-20 07:36:23 UTC Check cancelled

Copy link

github-actions bot commented Jun 20, 2025

2025-06-20 07:39:06 UTC Pre-commit check linux-x86_64-release-asan for 1efe749 has started.
2025-06-20 07:39:17 UTC Artifacts will be uploaded here
2025-06-20 07:42:35 UTC ya make is running...
🟢 2025-06-20 09:11:31 UTC ydbd size 3.9 GiB changed* by +69.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ecbf05b merge: 1efe749 diff diff %
ydbd size 4 180 099 280 Bytes 4 180 170 464 Bytes +69.5 KiB +0.002%
ydbd stripped size 1 449 133 240 Bytes 1 449 149 048 Bytes +15.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2025-06-20 09:11:33 UTC Check cancelled

Copy link

github-actions bot commented Jun 20, 2025

2025-06-20 07:41:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1efe749 has started.
2025-06-20 07:41:15 UTC Artifacts will be uploaded here
2025-06-20 07:44:24 UTC ya make is running...
🟡 2025-06-20 08:45:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28748 27361 0 5 1347 35

2025-06-20 08:47:58 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-20 08:59:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
666 (only retried tests) 628 0 1 0 37

2025-06-20 08:59:30 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-06-20 09:08:08 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
448 (only retried tests) 417 0 1 0 30

🟢 2025-06-20 09:08:21 UTC Build successful.
🟢 2025-06-20 09:08:43 UTC ydbd size 2.2 GiB changed* by +42.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f2672d3 merge: 1efe749 diff diff %
ydbd size 2 376 339 424 Bytes 2 376 382 896 Bytes +42.5 KiB +0.002%
ydbd stripped size 497 981 256 Bytes 497 986 376 Bytes +5.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA added the rebase-and-check Rebase PR with the current base branch and check label Jun 20, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jun 20, 2025
Copy link

github-actions bot commented Jun 20, 2025

2025-06-20 09:12:57 UTC Pre-commit check linux-x86_64-release-asan for cc6386a has started.
2025-06-20 09:13:09 UTC Artifacts will be uploaded here
2025-06-20 09:16:26 UTC ya make is running...
🟡 2025-06-20 11:04:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13737 13438 0 69 201 29

2025-06-20 11:06:16 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-20 11:41:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1657 (only retried tests) 1405 0 53 174 25

2025-06-20 11:41:41 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-20 12:17:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1487 (only retried tests) 1239 0 50 172 26

🟢 2025-06-20 12:17:25 UTC Build successful.
🟢 2025-06-20 12:18:00 UTC ydbd size 3.9 GiB changed* by +69.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a44c172 merge: cc6386a diff diff %
ydbd size 4 180 099 296 Bytes 4 180 170 464 Bytes +69.5 KiB +0.002%
ydbd stripped size 1 449 133 240 Bytes 1 449 149 048 Bytes +15.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 20, 2025

2025-06-20 09:12:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for cc6386a has started.
2025-06-20 09:13:10 UTC Artifacts will be uploaded here
2025-06-20 09:16:33 UTC ya make is running...
🟡 2025-06-20 10:25:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28748 27347 0 6 1346 49

2025-06-20 10:28:31 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-20 10:39:51 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
510 (only retried tests) 479 0 0 0 31

🟢 2025-06-20 10:40:00 UTC Build successful.
🟢 2025-06-20 10:40:20 UTC ydbd size 2.2 GiB changed* by +42.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a44c172 merge: cc6386a diff diff %
ydbd size 2 376 339 424 Bytes 2 376 382 896 Bytes +42.5 KiB +0.002%
ydbd stripped size 497 981 256 Bytes 497 986 376 Bytes +5.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant