Skip to content

Change MAX_BLOCK_SIZE constant for encrypted file deserializer to suit real export settings #19933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

UgnineSirdis
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Real settings for block size are 32 MB, so we need to make the constant bigger in order not to generate invalid encrypted files

Copy link

🟢 2025-06-19 21:46:58 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Jun 19, 2025

2025-06-19 21:49:33 UTC Pre-commit check linux-x86_64-release-asan for 9c98803 has started.
2025-06-19 21:49:44 UTC Artifacts will be uploaded here
2025-06-19 21:53:08 UTC ya make is running...
🟡 2025-06-19 23:38:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13909 13434 0 234 212 29

2025-06-19 23:39:53 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-20 00:22:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2483 (only retried tests) 2151 0 113 189 30

2025-06-20 00:22:43 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-20 00:57:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1689 (only retried tests) 1431 0 56 179 23

🟢 2025-06-20 00:57:42 UTC Build successful.
🟢 2025-06-20 00:58:18 UTC ydbd size 3.9 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6065f1e merge: 9c98803 diff diff %
ydbd size 4 180 038 752 Bytes 4 180 038 656 Bytes -96 Bytes -0.000%
ydbd stripped size 1 449 114 744 Bytes 1 449 114 680 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 19, 2025

2025-06-19 21:49:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9c98803 has started.
2025-06-19 21:49:45 UTC Artifacts will be uploaded here
2025-06-19 21:53:10 UTC ya make is running...
🟡 2025-06-19 22:57:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29149 27743 0 12 1346 48

2025-06-19 22:59:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-19 23:11:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
493 (only retried tests) 461 0 2 0 30

2025-06-19 23:11:13 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-06-19 23:20:51 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
326 (only retried tests) 296 0 1 0 29

🟢 2025-06-19 23:20:58 UTC Build successful.
🟢 2025-06-19 23:21:23 UTC ydbd size 2.2 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6065f1e merge: 9c98803 diff diff %
ydbd size 2 376 303 640 Bytes 2 376 303 640 Bytes 0 Bytes 0.000%
ydbd stripped size 497 974 856 Bytes 497 974 856 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant