-
Notifications
You must be signed in to change notification settings - Fork 695
Improve tiny ydb perfomance #19909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tiny ydb perfomance #19909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the performance of tiny YDB by refactoring task actor behavior, updating thread pool configuration and switching logic, and adding configuration options for forced foreign slots and adjacent pool management.
- Refactored THugeTaskActor in manual test to dynamically generate worker configurations
- Enhanced shared executor pool logic to utilize adjacent pools and forced foreign slots
- Updated configuration (both proto and cpp) to support new tiny YDB performance parameters
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
ydb/library/actors/core/manual_test/shared_threads/main.cpp | Refactored task actor constructor and main to support multiple test cases and dynamic worker counts |
ydb/library/actors/core/executor_thread_ctx.h | Added AdjacentPoolId field to thread context |
ydb/library/actors/core/executor_pool_shared.h | Added ForcedForeignSlots flag and AdjacentPools to worker config |
ydb/library/actors/core/executor_pool_shared.cpp | Adjusted adjacent pool switching logic and foreign slot handling |
ydb/library/actors/core/cpu_manager.cpp | Updated foreign slot configuration based on forced foreign slots |
ydb/library/actors/core/config.h | Added tiny-YDB specific configuration members |
ydb/core/protos/config.proto | Added proto definitions for adjacent pools and forced foreign slots |
ydb/core/driver_lib/run/run.cpp | Adjusted pool id assignment when using shared threads |
ydb/core/driver_lib/run/config_helpers.cpp | Propagated new config options for adjacent pools and forced foreign slots |
ydb/core/driver_lib/run/auto_config_initializer.cpp | Updated executor and service pool assignments for improved YDB perf |
🟢 |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
...