Skip to content

Setup the buffer page size from config on start #19724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abyss7
Copy link
Collaborator

@abyss7 abyss7 commented Jun 17, 2025

Changelog entry

The new config option is buffer_page_alloc_size with default 4Kb

Changelog category

  • Performance improvement

Description for reviewers

...

@abyss7 abyss7 requested review from a team as code owners June 17, 2025 10:38
@abyss7 abyss7 requested a review from gridnevvvit June 17, 2025 10:40
Copy link

🟢 2025-06-17 10:41:01 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Jun 17, 2025

2025-06-17 10:41:45 UTC Pre-commit check linux-x86_64-release-asan for 57824b5 has started.
2025-06-17 10:42:10 UTC Artifacts will be uploaded here
2025-06-17 10:46:41 UTC ya make is running...
🔴 2025-06-17 12:58:40 UTC Too many tests failed, NOT going to retry
🟡 2025-06-17 13:05:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16024 12690 0 2810 486 38

🟢 2025-06-17 13:07:09 UTC Build successful.
🔴 2025-06-17 13:07:52 UTC ydbd size 3.9 GiB changed* by +3.4 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 0ca2955 merge: 57824b5 diff diff %
ydbd size 4 167 354 616 Bytes 4 170 888 224 Bytes +3.4 MiB +0.085%
ydbd stripped size 1 446 053 048 Bytes 1 446 789 528 Bytes +719.2 KiB +0.051%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 17, 2025

2025-06-17 10:41:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for 57824b5 has started.
2025-06-17 10:42:04 UTC Artifacts will be uploaded here
2025-06-17 10:45:42 UTC ya make is running...
🔴 2025-06-17 13:00:30 UTC Too many tests failed, NOT going to retry
🔴 2025-06-17 13:25:57 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38308 22919 0 11582 3746 61

🟢 2025-06-17 13:29:53 UTC Build successful.
🟢 2025-06-17 13:30:36 UTC ydbd size 2.2 GiB changed* by +5.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7eb7f65 merge: 57824b5 diff diff %
ydbd size 2 371 138 248 Bytes 2 371 143 384 Bytes +5.0 KiB +0.000%
ydbd stripped size 497 369 576 Bytes 497 370 600 Bytes +1.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 22, 2025

2025-06-22 21:02:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for ce1ba2a has started.
2025-06-22 21:02:43 UTC Artifacts will be uploaded here
2025-06-22 21:06:37 UTC ya make is running...
🟡 2025-06-22 22:55:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38457 35743 0 3 2663 48

2025-06-22 22:59:21 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-22 23:15:09 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
490 (only retried tests) 459 0 0 0 31

🟢 2025-06-22 23:15:18 UTC Build successful.
🟢 2025-06-22 23:15:39 UTC ydbd size 2.2 GiB changed* by +6.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ecb9d76 merge: ce1ba2a diff diff %
ydbd size 2 378 944 072 Bytes 2 378 950 312 Bytes +6.1 KiB +0.000%
ydbd stripped size 498 353 192 Bytes 498 354 632 Bytes +1.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 22, 2025

2025-06-22 21:02:38 UTC Pre-commit check linux-x86_64-release-asan for ce1ba2a has started.
2025-06-22 21:02:49 UTC Artifacts will be uploaded here
2025-06-22 21:06:40 UTC ya make is running...
🟡 2025-06-22 23:33:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16160 15820 0 119 196 25

2025-06-22 23:35:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-23 00:18:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1949 (only retried tests) 1672 0 80 170 27

2025-06-23 00:19:04 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-23 00:59:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1604 (only retried tests) 1328 0 74 175 27

🟢 2025-06-23 00:59:59 UTC Build successful.
🟢 2025-06-23 01:00:39 UTC ydbd size 3.9 GiB changed* by +12.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ecb9d76 merge: ce1ba2a diff diff %
ydbd size 4 185 150 376 Bytes 4 185 162 904 Bytes +12.2 KiB +0.000%
ydbd stripped size 1 450 983 384 Bytes 1 450 988 248 Bytes +4.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant