Skip to content

float sum aggregation has been fixed #19466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2025
Merged

float sum aggregation has been fixed #19466

merged 3 commits into from
Jun 12, 2025

Conversation

dorooleg
Copy link
Collaborator

@dorooleg dorooleg commented Jun 7, 2025 •
edited
Loading

Changelog entry

Исправлена аггрегация в arrow::Kernel для float #1

Changelog category

  • Bugfix

Description for reviewers

...

@github-actions github-actions bot added the bugfix label Jun 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2025 •
edited
Loading

⚪ 2025-06-07 19:03:13 UTC Pre-commit check linux-x86_64-release-asan for b2e3a7d has started.
⚪ 2025-06-07 19:03:21 UTC Artifacts will be uploaded here
⚪ 2025-06-07 19:06:20 UTC ya make is running...
🟡 2025-06-07 20:45:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13902 13740 0 85 55 22

⚪ 2025-06-07 20:46:45 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-07 21:18:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1371 (only retried tests) 1278 0 68 5 20

⚪ 2025-06-07 21:18:20 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-07 21:48:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1187 (only retried tests) 1088 0 71 7 21

🟢 2025-06-07 21:48:38 UTC Build successful.
🟡 2025-06-07 21:49:07 UTC ydbd size 3.9 GiB changed* by +283.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 4065db2 merge: b2e3a7d diff diff %
ydbd size 4 168 732 552 Bytes 4 169 022 912 Bytes +283.6 KiB +0.007%
ydbd stripped size 1 446 051 384 Bytes 1 446 167 256 Bytes +113.2 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2025 •
edited
Loading

🟢 2025-06-09 08:29:57 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2025 •
edited
Loading

⚪ 2025-06-07 19:04:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for b2e3a7d has started.
⚪ 2025-06-07 19:04:54 UTC Artifacts will be uploaded here
⚪ 2025-06-07 19:08:02 UTC ya make is running...
🟡 2025-06-07 20:10:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22043 20667 0 5 1340 31

⚪ 2025-06-07 20:12:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-07 20:22:22 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
426 (only retried tests) 401 0 0 0 25

🟢 2025-06-07 20:22:29 UTC Build successful.
🟡 2025-06-07 20:22:48 UTC ydbd size 2.2 GiB changed* by +178.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 4065db2 merge: b2e3a7d diff diff %
ydbd size 2 370 216 976 Bytes 2 370 400 056 Bytes +178.8 KiB +0.008%
ydbd stripped size 497 242 024 Bytes 497 280 040 Bytes +37.1 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dorooleg dorooleg marked this pull request as ready for review June 9, 2025 06:52
@dorooleg dorooleg requested a review from a team as a code owner June 9, 2025 06:52
@dorooleg dorooleg requested a review from zverevgeny June 9, 2025 06:52
@github-actions github-actions bot added bugfix and removed bugfix labels Jun 9, 2025
zverevgeny
zverevgeny reviewed Jun 9, 2025
View reviewed changes
ydb/core/formats/arrow/program/functions.cpp Outdated
return arrow::Status::OK();
}

size_t count = 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PascalCase для членов классов

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2025 •
edited
Loading

⚪ 2025-06-09 12:51:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for ebc8ef1 has started.
⚪ 2025-06-09 12:51:58 UTC Artifacts will be uploaded here
⚪ 2025-06-09 12:55:06 UTC ya make is running...
🟡 2025-06-09 13:54:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22059 20669 0 5 1341 44

⚪ 2025-06-09 13:56:33 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-09 14:11:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
497 (only retried tests) 472 0 1 0 24

⚪ 2025-06-09 14:11:32 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-06-09 14:22:29 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
290 (only retried tests) 271 0 0 0 19

🟢 2025-06-09 14:22:39 UTC Build successful.
🟡 2025-06-09 14:23:00 UTC ydbd size 2.2 GiB changed* by +139.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 113c16b merge: ebc8ef1 diff diff %
ydbd size 2 370 523 512 Bytes 2 370 666 368 Bytes +139.5 KiB +0.006%
ydbd stripped size 497 279 496 Bytes 497 309 640 Bytes +29.4 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2025 •
edited
Loading

⚪ 2025-06-09 12:53:12 UTC Pre-commit check linux-x86_64-release-asan for ebc8ef1 has started.
⚪ 2025-06-09 12:53:24 UTC Artifacts will be uploaded here
⚪ 2025-06-09 12:56:33 UTC ya make is running...
🟡 2025-06-09 14:43:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13918 13581 0 175 140 22

⚪ 2025-06-09 14:44:34 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-09 15:25:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1895 (only retried tests) 1741 0 82 49 23

⚪ 2025-06-09 15:25:22 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-09 16:01:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1584 (only retried tests) 1428 0 86 49 21

🟢 2025-06-09 16:01:40 UTC Build successful.
🟡 2025-06-09 16:02:17 UTC ydbd size 3.9 GiB changed* by +225.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 113c16b merge: ebc8ef1 diff diff %
ydbd size 4 169 110 408 Bytes 4 169 341 528 Bytes +225.7 KiB +0.006%
ydbd stripped size 1 446 149 848 Bytes 1 446 237 112 Bytes +85.2 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dorooleg dorooleg requested a review from XJIE6 June 12, 2025 15:34
@dorooleg dorooleg enabled auto-merge (squash) June 12, 2025 17:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2025 •
edited
Loading

⚪ 2025-06-12 17:51:16 UTC Pre-commit check linux-x86_64-release-asan for 47260fb has started.
⚪ 2025-06-12 17:51:28 UTC Artifacts will be uploaded here
⚪ 2025-06-12 17:54:40 UTC ya make is running...
🟡 2025-06-12 19:30:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13930 13660 0 134 111 25

⚪ 2025-06-12 19:31:54 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-12 20:06:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1714 (only retried tests) 1557 0 65 67 25

⚪ 2025-06-12 20:07:15 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-12 20:37:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1446 (only retried tests) 1281 0 58 82 25

🟢 2025-06-12 20:37:44 UTC Build successful.
🟡 2025-06-12 20:38:17 UTC ydbd size 3.9 GiB changed* by +221.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 33ded45 merge: 47260fb diff diff %
ydbd size 4 167 837 096 Bytes 4 168 064 120 Bytes +221.7 KiB +0.005%
ydbd stripped size 1 445 725 752 Bytes 1 445 808 920 Bytes +81.2 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2025 •
edited
Loading

⚪ 2025-06-12 17:51:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 47260fb has started.
⚪ 2025-06-12 17:51:29 UTC Artifacts will be uploaded here
⚪ 2025-06-12 17:54:44 UTC ya make is running...
🟡 2025-06-12 18:53:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29083 27685 0 7 1351 40

⚪ 2025-06-12 18:56:03 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-12 19:07:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
593 (only retried tests) 564 0 2 0 27

⚪ 2025-06-12 19:07:39 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-06-12 19:17:54 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
425 (only retried tests) 405 0 0 0 20

🟢 2025-06-12 19:18:02 UTC Build successful.
🟡 2025-06-12 19:18:24 UTC ydbd size 2.2 GiB changed* by +143.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 33ded45 merge: 47260fb diff diff %
ydbd size 2 369 781 840 Bytes 2 369 928 680 Bytes +143.4 KiB +0.006%
ydbd stripped size 497 023 016 Bytes 497 057 128 Bytes +33.3 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dorooleg dorooleg merged commit 0c186d0 into ydb-platform:main Jun 12, 2025
12 checks passed
@dorooleg dorooleg deleted the float_sum_aggregation_fix branch June 12, 2025 20:38
dorooleg added a commit to dorooleg/ydb that referenced this pull request Jun 18, 2025
@dorooleg
float sum aggregation has been fixed (ydb-platform#19466)
02d6e2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zverevgeny zverevgeny zverevgeny left review comments

@XJIE6 XJIE6 XJIE6 approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dorooleg @XJIE6 @zverevgeny