Enable tag event and nightly builds #19452

PavelEfarinov · 2025-06-06T15:37:26Z

Changelog category

Not for changelog (changelog entry is not required)

Description for reviewers

Nightly build is now capable of building and publishing by tags. Added trigger on tag push event

Resolves #19413 #19414

Fixed testmo tag name error. Enabled tag specific test and build workflow Refs: #19413

Fixed asan build flags. Enabled tag build workflow on tag push event Refs: #19413

github-actions · 2025-06-06T15:39:08Z

⚪ 2025-06-06 15:39:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 71e0383 has started.
⚪ 2025-06-06 15:39:18 UTC Artifacts will be uploaded here
⚪ 2025-06-06 15:41:42 UTC ya make is running...
🟢 2025-06-06 15:41:47 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2025-06-06 15:41:52 UTC Build successful.

github-actions · 2025-06-06T15:39:22Z

⚪ 2025-06-06 15:39:21 UTC Pre-commit check linux-x86_64-release-asan for 71e0383 has started.
⚪ 2025-06-06 15:39:27 UTC Artifacts will be uploaded here
⚪ 2025-06-06 15:42:00 UTC ya make is running...
🟢 2025-06-06 15:42:05 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2025-06-06 15:42:11 UTC Build successful.

github-actions · 2025-06-06T15:40:26Z

🟢 2025-06-06 15:40:26 UTC The validation of the Pull Request description is successful.

github-actions · 2025-06-06T15:40:27Z

🟢 2025-06-06 15:40:26 UTC The validation of the Pull Request description is successful.

maximyurchuk · 2025-06-06T15:51:51Z

.github/workflows/nightly_build.yml

-
+  push:
+    tags:
+      - '[0-9][0-9].[0-9].[0-9]**'


Это не совсем правильно, у нас могут быть и другие теги: например для analytics

Предлагаю все что с цифры -- считать тегом для сборки, а что уж там дальше -- неважно

Сделал

maximyurchuk · 2025-06-06T15:52:49Z

.github/workflows/nightly_build.yml

      run: |
        set -x
-        s3cmd sync --follow-symlinks --acl-public --no-progress --stats --no-check-md5 "ydb/apps/ydbd/ydbd" "s3://ydb-builds/${{ matrix.branch }}/${{ matrix.build_preset }}/ydbd" -d
+        s3cmd sync --follow-symlinks --acl-public --no-progress --stats --no-check-md5 "ydb/apps/ydbd/ydbd" "s3://ydb-builds/$(echo -n "${{ matrix.branch }}" | tr -c '[:alnum:]-' '-')/${{ matrix.build_preset }}/ydbd" -d


А зачем тут заменять на дефисы? Мне кажется это неправильно и будет конфьюзить людей. Не лучше ли называть ровно так же, как называется тег?

Казалось, что в s3 не разрешены точки в названиях, правлю

maximyurchuk · 2025-06-06T15:58:21Z

.github/actions/test_ya/action.yml

        echo "BRANCH_NAME is set to $BRANCH_NAME"

-        TESTMO_BRANCH_TAG="$BRANCH_NAME"
+        TESTMO_BRANCH_TAG=${BRANCH_NAME//[^a-zA-Z0-9-]/-}


А можешь, плз, проверить, что после этой правки ПР в ветку не ломаются?

Например, что в тестмо по прежнему все льется корректно

Должно провериться вот тут #19453

Copilot

Pull Request Overview

Adds tag-based triggers and improves name sanitization for nightly builds, while refining cache and debug configurations

Introduce push.tags event and adjust branch-selection logic to skip default branches on tag pushes
Update cache steps to use -DDEBUGINFO_LINES_ONLY and remove unused tokens
Sanitize branch names in S3 paths and TESTMO variables by stripping invalid characters

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
.github/workflows/nightly_build.yml	Added tag trigger, tweaked branch logic, updated cache args, and sanitized S3 upload path
.github/actions/test_ya/action.yml	Sanitized `TESTMO_BRANCH_TAG` by replacing non-alphanumeric/`-` chars

Comments suppressed due to low confidence (1)

.github/workflows/nightly_build.yml:14

GitHub push event tag filters use glob patterns rather than regex. The pattern '[0-9][0-9].[0-9].[0-9]**' may not match as intended; consider a glob like '..' or 'v..' to reliably capture version tags.

-      - '[0-9][0-9].[0-9].[0-9]**'

Copilot · 2025-06-06T16:00:37Z

.github/workflows/nightly_build.yml

      - id: set-branches
        run: |
-          if [[ "${{ github.event_name }}" == "schedule" || "${{ inputs.use_default_branches }}" == "true" ]]; then
+          if [[ "${{ github.event_name }}" == "schedule" || "${{ inputs.use_default_branches }}" == "true"  && "${{ github.ref_type }}" != "tag" ]]; then


[nitpick] The combination of || and && without grouping can lead to unexpected logic due to operator precedence. Wrap the second part in parentheses, e.g.: if [[ "${{ github.event_name }}" == "schedule" || ("${{ inputs.use_default_branches }}" == "true" && "${{ github.ref_type }}" != "tag") ]]; then.

Suggested change

if [[ "${{ github.event_name }}" == "schedule" || "${{ inputs.use_default_branches }}" == "true" && "${{ github.ref_type }}" != "tag" ]]; then

if [[ "${{ github.event_name }}" == "schedule" || ("${{ inputs.use_default_branches }}" == "true" && "${{ github.ref_type }}" != "tag") ]]; then

Поправил

Copilot · 2025-06-06T16:00:37Z

.github/workflows/nightly_build.yml

        put_build_results_to_cache: false
-        secs: ${{ format('{{"TESTMO_TOKEN2":"{0}","AWS_KEY_ID":"{1}","AWS_KEY_VALUE":"{2}","REMOTE_CACHE_USERNAME":"{3}","REMOTE_CACHE_PASSWORD":"{4}"}}',
-          secrets.TESTMO_TOKEN2, secrets.AWS_KEY_ID, secrets.AWS_KEY_VALUE, secrets.REMOTE_CACHE_USERNAME, secrets.REMOTE_CACHE_PASSWORD ) }}
+        additional_ya_make_args: -DDEBUGINFO_LINES_ONLY # we don't need full symbols in CI checks


An unquoted string beginning with '-' can be interpreted as a YAML list item. Quote -DDEBUGINFO_LINES_ONLY (e.g., "-DDEBUGINFO_LINES_ONLY") to ensure it’s treated as a single string argument.

Suggested change

additional_ya_make_args: -DDEBUGINFO_LINES_ONLY # we don't need full symbols in CI checks

additional_ya_make_args: "-DDEBUGINFO_LINES_ONLY" # we don't need full symbols in CI checks

Поправил

Copilot · 2025-06-06T16:00:37Z

.github/actions/test_ya/action.yml

        echo "BRANCH_NAME is set to $BRANCH_NAME"

-        TESTMO_BRANCH_TAG="$BRANCH_NAME"
+        TESTMO_BRANCH_TAG=${BRANCH_NAME//[^a-zA-Z0-9-]/-}


Parameter expansion results should be quoted to handle empty or whitespace-containing names safely. Use TESTMO_BRANCH_TAG="${BRANCH_NAME//[^a-zA-Z0-9-]/-}".

Suggested change

TESTMO_BRANCH_TAG=${BRANCH_NAME//[^a-zA-Z0-9-]/-}

TESTMO_BRANCH_TAG="${BRANCH_NAME//[^a-zA-Z0-9-]/-}"

Поправил

Refs: #19413 #19414

github-actions · 2025-06-06T16:17:02Z

⚪ 2025-06-06 16:17:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0717acf has started.
⚪ 2025-06-06 16:17:13 UTC Artifacts will be uploaded here
⚪ 2025-06-06 16:19:36 UTC ya make is running...
🟢 2025-06-06 16:19:41 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2025-06-06 16:19:47 UTC Build successful.

github-actions · 2025-06-06T16:17:36Z

⚪ 2025-06-06 16:17:35 UTC Pre-commit check linux-x86_64-release-asan for 0717acf has started.
⚪ 2025-06-06 16:17:46 UTC Artifacts will be uploaded here
⚪ 2025-06-06 16:20:11 UTC ya make is running...
🟢 2025-06-06 16:20:16 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2025-06-06 16:20:22 UTC Build successful.

Refs: #19413

PavelEfarinov added 2 commits June 6, 2025 15:47

ci: enable tag specific build

14029f9

Fixed testmo tag name error. Enabled tag specific test and build workflow Refs: #19413

ci: enable ybd build and publish on tag push

3bccb26

Fixed asan build flags. Enabled tag build workflow on tag push event Refs: #19413

PavelEfarinov requested a review from maximyurchuk June 6, 2025 15:37

PavelEfarinov self-assigned this Jun 6, 2025

PavelEfarinov changed the title ~~Enable tag event and nightly builds #19413 #19414~~ Enable tag event and nightly builds Jun 6, 2025

github-actions bot added not-for-changelog and removed not-for-changelog labels Jun 6, 2025

PavelEfarinov linked an issue Jun 6, 2025 that may be closed by this pull request

Add trigger to build new tags in nightly build #19414

Closed

maximyurchuk reviewed Jun 6, 2025

View reviewed changes

maximyurchuk requested a review from Copilot June 6, 2025 15:57

maximyurchuk reviewed Jun 6, 2025

View reviewed changes

Copilot AI reviewed Jun 6, 2025

View reviewed changes

fix: apply pr comment fixes

966ae67

Refs: #19413 #19414

maximyurchuk approved these changes Jun 6, 2025

View reviewed changes

PavelEfarinov merged commit 6831972 into main Jun 9, 2025
18 checks passed

PavelEfarinov deleted the dev-tag-build-19413 branch June 9, 2025 06:18

PavelEfarinov added a commit that referenced this pull request Jul 8, 2025

cherry-pick: Enable tag event and nightly builds (#19452)

820739f

Refs: #19413

PavelEfarinov added a commit that referenced this pull request Jul 8, 2025

cherry-pick: Enable tag event and nightly builds (#19452)

2bf1247

Refs: #19413

This was referenced Jul 8, 2025

[stable-24-4-4-hotfix] Enable tag trigger for nightly builds #20820

Merged

[stable-24-4] Enable tag trigger for nightly builds #20821

Merged

PavelEfarinov added a commit that referenced this pull request Jul 8, 2025

cherry-pick: Enable tag event and nightly builds (#19452)

d80f5d7

Refs: #19413

PavelEfarinov added a commit that referenced this pull request Jul 8, 2025

Enable tag event and nightly builds (#19452)

d19bafe

PavelEfarinov added a commit that referenced this pull request Jul 8, 2025

cherry-pick: Enable tag event and nightly builds (#19452)

a8c02a8

Refs: #19413

PavelEfarinov added a commit that referenced this pull request Jul 8, 2025

cherry-pick: Enable tag event and nightly builds (#19452)

e4660ad

Refs: #19413

StekPerepolnen mentioned this pull request Aug 5, 2025

audit log http merge 24 4 #22340

Closed

	if [[ "${{ github.event_name }}" == "schedule" \|\| "${{ inputs.use_default_branches }}" == "true" && "${{ github.ref_type }}" != "tag" ]]; then
	if [[ "${{ github.event_name }}" == "schedule" \|\| ("${{ inputs.use_default_branches }}" == "true" && "${{ github.ref_type }}" != "tag") ]]; then

	additional_ya_make_args: -DDEBUGINFO_LINES_ONLY # we don't need full symbols in CI checks
	additional_ya_make_args: "-DDEBUGINFO_LINES_ONLY" # we don't need full symbols in CI checks

	TESTMO_BRANCH_TAG=${BRANCH_NAME//[^a-zA-Z0-9-]/-}
	TESTMO_BRANCH_TAG="${BRANCH_NAME//[^a-zA-Z0-9-]/-}"

Enable tag event and nightly builds #19452

Enable tag event and nightly builds #19452

Uh oh!

Conversation

PavelEfarinov commented Jun 6, 2025

Changelog category

Description for reviewers

Uh oh!

github-actions bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2025

Uh oh!

github-actions bot commented Jun 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Jun 6, 2025 •

edited

Loading

github-actions bot commented Jun 6, 2025 •

edited

Loading

github-actions bot commented Jun 6, 2025 •

edited

Loading

github-actions bot commented Jun 6, 2025 •

edited

Loading