Skip to content

Check iter index access slice bounds #18213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 13, 2025
Merged

Check iter index access slice bounds #18213

merged 8 commits into from
May 13, 2025

Conversation

@kungasc
Copy link
Contributor

@kungasc kungasc commented May 12, 2025 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Fixes #18151

Check the next page is within the slice bounds before calling Index.Next() method

kungasc
kungasc commented May 12, 2025
View reviewed changes
ydb/core/tablet_flat/flat_fwd_cache.h
TDeque<TPageEx> Pages;
ui32 PagesBeginOffset = 0, PagesPendingOffset = 0;
TDeque<TNodeState> Queue;
TPageId BeginPageId = Max<TPageId>(), EndPageId = 0;
Copy link
Contributor Author

@kungasc kungasc May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are needed just for clear error message

@github-actions
Copy link

github-actions bot commented May 12, 2025 •
edited
Loading

🟢 2025-05-12 13:32:50 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented May 12, 2025 •
edited
Loading

⚪ 2025-05-12 13:20:15 UTC Pre-commit check linux-x86_64-release-asan for a969a9d has started.
⚪ 2025-05-12 13:20:25 UTC Artifacts will be uploaded here
⚪ 2025-05-12 13:23:29 UTC ya make is running...
⚫ 2025-05-12 13:25:24 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented May 12, 2025 •
edited
Loading

⚪ 2025-05-12 13:20:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for a969a9d has started.
⚪ 2025-05-12 13:20:31 UTC Artifacts will be uploaded here
⚪ 2025-05-12 13:23:35 UTC ya make is running...
⚫ 2025-05-12 13:25:24 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented May 12, 2025 •
edited
Loading

⚪ 2025-05-12 13:26:07 UTC Pre-commit check linux-x86_64-release-asan for 57af471 has started.
⚪ 2025-05-12 13:26:37 UTC Artifacts will be uploaded here
⚪ 2025-05-12 13:30:23 UTC ya make is running...
🟡 2025-05-12 15:35:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14568 14390 0 107 43 28

⚪ 2025-05-12 15:36:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-12 16:09:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1387 (only retried tests) 1275 0 61 25 26

⚪ 2025-05-12 16:10:10 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-12 16:43:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1367 (only retried tests) 1228 0 69 44 26

🟢 2025-05-12 16:44:00 UTC Build successful.
🟢 2025-05-12 16:44:34 UTC ydbd size 3.9 GiB changed* by +22.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a03af29 merge: 57af471 diff diff %
ydbd size 4 137 940 920 Bytes 4 137 963 960 Bytes +22.5 KiB +0.001%
ydbd stripped size 1 435 922 240 Bytes 1 435 924 672 Bytes +2.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 12, 2025 •
edited
Loading

⚪ 2025-05-12 13:27:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 57af471 has started.
⚪ 2025-05-12 13:28:00 UTC Artifacts will be uploaded here
⚪ 2025-05-12 13:31:01 UTC ya make is running...
🟡 2025-05-12 15:15:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29550 26876 0 2 2635 37

⚪ 2025-05-12 15:17:55 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-12 15:42:25 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
137 (only retried tests) 106 0 0 0 31

🟢 2025-05-12 15:42:31 UTC Build successful.
🟢 2025-05-12 15:42:49 UTC ydbd size 2.2 GiB changed* by +10.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: da5cb37 merge: 57af471 diff diff %
ydbd size 2 351 909 104 Bytes 2 351 919 928 Bytes +10.6 KiB +0.000%
ydbd stripped size 494 236 496 Bytes 494 237 264 Bytes +768 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kungasc kungasc changed the title Fix iter index loading within slice bounds Check iter index access slice bounds May 12, 2025
@kungasc kungasc marked this pull request as ready for review May 13, 2025 08:39
@kungasc kungasc requested a review from snaury May 13, 2025 08:39
@kungasc kungasc merged commit 1bfca4a into ydb-platform:main May 13, 2025
19 checks passed
kungasc added a commit to kungasc/ydb that referenced this pull request May 13, 2025
@kungasc
Check iter index access slice bounds (ydb-platform#18213)
237756b
@kungasc kungasc mentioned this pull request May 13, 2025
Merged
kungasc added a commit that referenced this pull request May 13, 2025
@kungasc
Check iter index access slice bounds (#18213)
1c5b051
kungasc added a commit that referenced this pull request May 13, 2025
@kungasc
Check iter index access slice bounds (#18213)
1e7f7de
@kungasc kungasc self-assigned this May 13, 2025
kungasc added a commit to kungasc/ydb that referenced this pull request May 13, 2025
@kungasc
Check iter index access slice bounds (ydb-platform#18213)
37b45e2
kungasc added a commit to kungasc/ydb that referenced this pull request May 13, 2025
@kungasc
Check iter index access slice bounds (ydb-platform#18213)
7d9bd21
kungasc added a commit to kungasc/ydb that referenced this pull request May 13, 2025
@kungasc
Check iter index access slice bounds (ydb-platform#18213)
4fdded9
kungasc added a commit that referenced this pull request May 14, 2025
@kungasc
Check iter index access slice bounds (#18213)
acbb460
kungasc added a commit that referenced this pull request May 14, 2025
@kungasc
Check iter index access slice bounds (#18213)
7542cdd
kungasc added a commit that referenced this pull request May 14, 2025
@kungasc
Check iter index access slice bounds (#18213)
dc47c06
maximyurchuk added a commit that referenced this pull request May 14, 2025
@maximyurchuk
Check iter index access slice bounds (#18213) (#18267)
15e4573
nshestakov pushed a commit to nshestakov/ydb that referenced this pull request May 20, 2025
@kungasc @nshestakov
Check iter index access slice bounds (ydb-platform#18213)
0927f6b
This was referenced Jun 3, 2025
Closed
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Aug 5, 2025
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snaury snaury snaury approved these changes

Assignees

@kungasc kungasc

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VERIFY AdvanceNextPage(): requirement !queue.empty() failed

2 participants

@kungasc @snaury