Skip to content

Conversation

@a-serebryanskiy
Copy link
Collaborator

Changelog entry

Moved changes from: #18079

Issue: #18116

This PR fixes optimisation in NKikimr::NRawSocket::TBufferedWriter, that wrote the entire message directly to socket if message was larger than available space in buffer. When we wrote more than 6mb to socket with SSL enabled, it every time returned -11 (WAGAIN).
As a quick fix, we replace sending of an entire message to socket with cutting this message into 1mb chunks and sending them to socket one by one.

Changelog category

  • Bugfix

Description for reviewers

...

Co-authored-by: Nikolay Shestakov <n.shestakov@gmail.com>
@a-serebryanskiy a-serebryanskiy requested a review from a team as a code owner May 7, 2025 09:19
@a-serebryanskiy a-serebryanskiy changed the title fix sending big messages (#18079) Fix reading big messages in Kafka Proxy (from #18079) May 7, 2025
@github-actions
Copy link

github-actions bot commented May 7, 2025

2025-05-07 09:32:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for 53595b9 has started.
2025-05-07 09:32:51 UTC Artifacts will be uploaded here
2025-05-07 09:36:25 UTC ya make is running...
🟡 2025-05-07 10:40:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20569 19283 0 9 1213 64

2025-05-07 10:42:02 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-07 11:03:39 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
139 (only retried tests) 78 0 0 0 61

🟢 2025-05-07 11:03:46 UTC Build successful.
🟢 2025-05-07 11:04:06 UTC ydbd size 2.1 GiB changed* by -16.4 KiB, which is <= 0 Bytes vs stable-25-1-1: OK

ydbd size dash stable-25-1-1: f642a67 merge: 53595b9 diff diff %
ydbd size 2 243 548 816 Bytes 2 243 532 000 Bytes -16.4 KiB -0.001%
ydbd stripped size 475 082 168 Bytes 475 080 888 Bytes -1.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 7, 2025

2025-05-07 09:35:11 UTC Pre-commit check linux-x86_64-release-asan for 53595b9 has started.
2025-05-07 09:35:22 UTC Artifacts will be uploaded here
2025-05-07 09:38:10 UTC ya make is running...
🟡 2025-05-07 10:49:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13465 13402 0 19 9 35

2025-05-07 10:50:12 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-07 11:10:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
97 (only retried tests) 61 0 1 1 34

2025-05-07 11:11:06 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-07 11:31:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
64 (only retried tests) 30 0 1 0 33

🟢 2025-05-07 11:31:41 UTC Build successful.
🟢 2025-05-07 11:32:07 UTC ydbd size 3.6 GiB changed* by -19.7 KiB, which is <= 0 Bytes vs stable-25-1-1: OK

ydbd size dash stable-25-1-1: f642a67 merge: 53595b9 diff diff %
ydbd size 3 902 626 696 Bytes 3 902 606 512 Bytes -19.7 KiB -0.001%
ydbd stripped size 1 365 663 408 Bytes 1 365 662 512 Bytes -896 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@a-serebryanskiy a-serebryanskiy merged commit de4d890 into ydb-platform:stable-25-1-1 May 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants