Skip to content

Conversation

@a-serebryanskiy
Copy link
Collaborator

@a-serebryanskiy a-serebryanskiy commented May 7, 2025

Changelog entry

Moved changes from: #18079

Issue: #18116

This PR fixes optimisation in NKikimr::NRawSocket::TBufferedWriter, that wrote the entire message directly to socket if message was larger than available space in buffer. When we wrote more than 6mb to socket with SSL enabled, it every time returned -11 (WAGAIN).
As a quick fix, we replace sending of an entire message to socket with cutting this message into 1mb chunks and sending them to socket one by one.

Changelog category

  • Bugfix

Description for reviewers

...

Co-authored-by: Nikolay Shestakov <n.shestakov@gmail.com>
@a-serebryanskiy a-serebryanskiy requested a review from a team as a code owner May 7, 2025 08:41
@github-actions
Copy link

github-actions bot commented May 7, 2025

2025-05-07 08:48:14 UTC Pre-commit check for 2335076 has started.
2025-05-07 08:50:56 UTC Build linux-x86_64-release-asan is running...
🟢 2025-05-07 09:15:21 UTC Build successful.
2025-05-07 09:15:39 UTC Tests are running...
🔴 2025-05-07 11:32:09 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11629 11530 0 32 26 41

🟢 2025-05-07 11:32:53 UTC ydbd size 5.6 GiB changed* by -36.5 KiB, which is <= 0 Bytes vs stable-24-4: OK

ydbd size dash stable-24-4: 6d4b851 merge: 2335076 diff diff %
ydbd size 6 028 297 192 Bytes 6 028 259 784 Bytes -36.5 KiB -0.001%
ydbd stripped size 1 508 555 072 Bytes 1 508 554 880 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@a-serebryanskiy a-serebryanskiy changed the title fix sending big messages (#18079) Fix reading big messages in Kafka Proxy (from #18079) May 7, 2025
@github-actions
Copy link

github-actions bot commented May 7, 2025

2025-05-07 09:23:24 UTC Pre-commit check for 2335076 has started.
2025-05-07 09:25:58 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-05-07 10:05:40 UTC Build successful.
2025-05-07 10:05:56 UTC Tests are running...
🔴 2025-05-07 11:34:52 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16070 14710 0 21 1300 39

🟢 2025-05-07 11:35:45 UTC ydbd size 8.3 GiB changed* by -121.9 KiB, which is <= 0 Bytes vs stable-24-4: OK

ydbd size dash stable-24-4: 6d4b851 merge: 2335076 diff diff %
ydbd size 8 899 108 176 Bytes 8 898 983 360 Bytes -121.9 KiB -0.001%
ydbd stripped size 485 044 680 Bytes 485 043 464 Bytes -1.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@a-serebryanskiy a-serebryanskiy merged commit 13d86eb into ydb-platform:stable-24-4 May 7, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants