Skip to content

Conversation

@Alek5andr-Kotov
Copy link
Collaborator

@Alek5andr-Kotov Alek5andr-Kotov commented May 5, 2025

Changelog entry

Moved changes from #17913

Issue #17915

The PQ tablet forgets about the transaction only after it receives a TEvReadSetAck from all participants. Another shard may be deleted before the PQ completes the transaction (for example, due to a split table). As a result, transactions are executed, but remain in the WAIT_RS_ACKS state.

If the PQ tablet sends a TEvReadSet to a tablet that has already been deleted, it receives a TEvClientConnected with the Dead flag in response. In this case, we consider that we have received a TEvReadSetAck.

Changelog category

  • Bugfix

Description for reviewers

...

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner May 5, 2025 10:13
@Alek5andr-Kotov Alek5andr-Kotov enabled auto-merge May 5, 2025 10:13
@github-actions
Copy link

github-actions bot commented May 5, 2025

2025-05-05 10:15:48 UTC Pre-commit check for 65c18a2 has started.
2025-05-05 10:19:02 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-05-05 11:00:38 UTC Build successful.
2025-05-05 11:00:57 UTC Tests are running...
🔴 2025-05-05 12:42:58 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14823 13460 0 21 1305 37

🟢 2025-05-05 12:43:52 UTC ydbd size 8.3 GiB changed* by +70.8 KiB, which is < 100.0 KiB vs stable-24-4: OK

ydbd size dash stable-24-4: 32a6a78 merge: 65c18a2 diff diff %
ydbd size 8 899 035 128 Bytes 8 899 107 600 Bytes +70.8 KiB +0.001%
ydbd stripped size 485 037 832 Bytes 485 044 616 Bytes +6.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 5, 2025

2025-05-05 10:17:46 UTC Pre-commit check for 65c18a2 has started.
2025-05-05 10:20:27 UTC Build linux-x86_64-release-asan is running...
🟢 2025-05-05 10:44:32 UTC Build successful.
2025-05-05 10:44:47 UTC Tests are running...
🔴 2025-05-05 12:53:17 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10390 10289 0 32 25 44

🟢 2025-05-05 12:54:06 UTC ydbd size 5.6 GiB changed* by +27.2 KiB, which is < 100.0 KiB vs stable-24-4: OK

ydbd size dash stable-24-4: 32a6a78 merge: 65c18a2 diff diff %
ydbd size 6 028 267 056 Bytes 6 028 294 872 Bytes +27.2 KiB +0.000%
ydbd stripped size 1 508 545 344 Bytes 1 508 554 496 Bytes +8.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov merged commit 36a63ce into ydb-platform:stable-24-4 May 5, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants