Skip to content

Refactor config transformations #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 14, 2024
Merged

Refactor config transformations #1787

merged 9 commits into from
Feb 14, 2024

Conversation

Enjection
Copy link
Member

Changelog entry

  • reimplement config transformations
  • add some ut

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2024 •
edited
Loading

⚪ 2024-02-11 17:53:45 UTC Pre-commit check for d00b761 has started.
⚪ 2024-02-11 17:53:47 UTC Build linux-x86_64-release-asan is running...

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2024 •
edited
Loading

⚪ 2024-02-11 17:53:46 UTC Pre-commit check for d00b761 has started.
⚪ 2024-02-11 17:53:48 UTC Build linux-x86_64-relwithdebinfo is running...

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2024 •
edited
Loading

⚪ 2024-02-11 19:57:47 UTC Pre-commit check for 407201d has started.
⚪ 2024-02-11 19:57:48 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-11 19:59:32 UTC Build successful.
⚪ 2024-02-11 19:59:44 UTC Tests are running...
🔴 2024-02-11 20:44:26 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60727 49751 0 162 10800 14

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2024 •
edited
Loading

⚪ 2024-02-11 19:58:25 UTC Pre-commit check for 407201d has started.
⚪ 2024-02-11 19:58:26 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-11 20:00:06 UTC Build successful.
⚪ 2024-02-11 20:00:18 UTC Tests are running...
🔴 2024-02-11 20:27:10 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8232 8057 0 161 4 10

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2024 •
edited
Loading

⚪ 2024-02-11 20:51:37 UTC Pre-commit check for c50629d has started.
⚪ 2024-02-11 20:51:38 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-11 20:53:04 UTC Build successful.
⚪ 2024-02-11 20:53:18 UTC Tests are running...
🔴 2024-02-11 21:16:19 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8233 8049 0 163 11 10

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2024 •
edited
Loading

⚪ 2024-02-11 20:51:43 UTC Pre-commit check for c50629d has started.
⚪ 2024-02-11 20:51:45 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-11 20:53:18 UTC Build successful.
⚪ 2024-02-11 20:53:27 UTC Tests are running...
🔴 2024-02-11 21:22:30 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60727 49751 0 162 10800 14

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2024 •
edited
Loading

⚪ 2024-02-11 21:43:59 UTC Pre-commit check for 5452840 has started.
⚪ 2024-02-11 21:44:00 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-11 21:45:26 UTC Build successful.
⚪ 2024-02-11 21:45:38 UTC Tests are running...
🔴 2024-02-11 22:09:50 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8233 8050 0 163 10 10

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2024 •
edited
Loading

⚪ 2024-02-11 21:44:07 UTC Pre-commit check for 5452840 has started.
⚪ 2024-02-11 21:44:08 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-11 21:45:33 UTC Build successful.
⚪ 2024-02-11 21:45:43 UTC Tests are running...
🔴 2024-02-11 22:11:51 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60727 49751 0 162 10800 14

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited
Loading

⚪ 2024-02-12 08:26:06 UTC Pre-commit check for 94509ea has started.
⚪ 2024-02-12 08:26:08 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-12 08:27:18 UTC Build successful.
⚪ 2024-02-12 08:27:30 UTC Tests are running...
🔴 2024-02-12 08:44:08 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60727 49751 0 162 10800 14

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited
Loading

⚪ 2024-02-12 08:26:10 UTC Pre-commit check for 94509ea has started.
⚪ 2024-02-12 08:26:11 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-12 08:27:21 UTC Build successful.
⚪ 2024-02-12 08:27:31 UTC Tests are running...
🔴 2024-02-12 08:34:38 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8233 8050 0 163 10 10

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited
Loading

⚪ 2024-02-12 09:00:47 UTC Pre-commit check for 78a005b has started.
⚪ 2024-02-12 09:00:49 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-12 09:02:20 UTC Build successful.
⚪ 2024-02-12 09:02:33 UTC Tests are running...
🔴 2024-02-12 09:09:26 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8233 8050 0 163 10 10

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited
Loading

⚪ 2024-02-12 09:00:57 UTC Pre-commit check for 78a005b has started.
⚪ 2024-02-12 09:00:59 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-12 09:02:35 UTC Build successful.
⚪ 2024-02-12 09:02:44 UTC Tests are running...
🔴 2024-02-12 09:20:03 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60727 49751 0 162 10800 14

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited
Loading

⚪ 2024-02-12 10:44:30 UTC Pre-commit check for 79ce06d has started.
⚪ 2024-02-12 10:44:33 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-02-12 11:03:19 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited
Loading

⚪ 2024-02-12 10:57:27 UTC Pre-commit check for 79ce06d has started.
⚪ 2024-02-12 10:57:29 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-02-12 11:03:18 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited
Loading

⚪ 2024-02-12 11:34:22 UTC Pre-commit check for ec96ffc has started.
⚪ 2024-02-12 11:34:25 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-02-12 11:39:52 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited
Loading

⚪ 2024-02-12 12:04:04 UTC Pre-commit check for 0d2ec6b has started.
⚪ 2024-02-12 12:04:05 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-02-12 12:04:31 UTC Check cancelled

@Enjection Enjection changed the title [WIP] Refactor config transformations Refactor config transformations Feb 12, 2024
@Enjection Enjection marked this pull request as ready for review February 12, 2024 12:06
@Enjection Enjection requested a review from CyberROFL February 12, 2024 12:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited
Loading

⚪ 2024-02-12 12:17:17 UTC Pre-commit check for 7324988 has started.
⚪ 2024-02-12 12:17:19 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-12 12:51:52 UTC Build successful.
⚪ 2024-02-12 12:52:01 UTC Tests are running...
🔴 2024-02-12 13:19:48 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8237 8052 0 165 10 10

CyberROFL
CyberROFL requested changes Feb 12, 2024
View reviewed changes
@CyberROFL
Copy link
Member

Рекомендуется разбить на несколько герметичных pr:

  • Перемещение в deprecated.
  • Вынос в отдельные файлы часте конфига.
  • Собственно само изменение.
  • etc.

@Enjection Enjection force-pushed the feature/KIKIMR-21043/refactor-yaml-config-parser branch from a130332 to d297edd Compare February 13, 2024 12:40
@Enjection Enjection requested a review from CyberROFL February 13, 2024 12:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

⚪ 2024-02-13 12:58:23 UTC Pre-commit check for 4585361 has started.
⚪ 2024-02-13 12:58:25 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-13 13:00:14 UTC Build successful.
⚪ 2024-02-13 13:00:23 UTC Tests are running...
🔴 2024-02-13 13:28:13 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60764 49723 0 161 10867 13

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

⚪ 2024-02-13 12:59:44 UTC Pre-commit check for 4585361 has started.
⚪ 2024-02-13 12:59:46 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-13 13:01:31 UTC Build successful.
⚪ 2024-02-13 13:01:42 UTC Tests are running...
🔴 2024-02-13 13:24:51 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8237 8056 0 164 7 10

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

⚪ 2024-02-13 18:30:22 UTC Pre-commit check for d1de9b9 has started.
⚪ 2024-02-13 18:30:25 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-02-13 18:32:03 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

⚪ 2024-02-13 18:31:33 UTC Pre-commit check for d1de9b9 has started.
⚪ 2024-02-13 18:31:34 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-02-13 18:32:02 UTC Check cancelled

@Enjection Enjection requested a review from CyberROFL February 13, 2024 18:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

⚪ 2024-02-13 18:46:31 UTC Pre-commit check for 6523489 has started.
⚪ 2024-02-13 18:46:33 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-13 18:48:24 UTC Build successful.
⚪ 2024-02-13 18:48:36 UTC Tests are running...
🔴 2024-02-13 20:14:27 UTC Test run completed, no test results found for commit f0a0b11. Please check build logs.
⚫ 2024-02-13 20:14:33 UTC Check cancelled

CyberROFL
CyberROFL previously approved these changes Feb 13, 2024
View reviewed changes
ydb/library/yaml_config/core_constants.h
}

const inline std::array<std::pair<TString, TString>, 4> DEFAULT_EXECUTORS{
std::pair{TString{"IoExecutor"}, TString{"IO"}},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно явно не специфицировать std::pair.

ydb/library/yaml_config/core_constants.h

constexpr ui32 DEFAULT_INTERCONNECT_PORT = 19001;

constexpr inline TStringBuf DEFAULT_ROOT_USERNAME = "root";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline-константы... ну, такое.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constexpr же implicitly inline, разве нет?

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

⚪ 2024-02-13 18:49:04 UTC Pre-commit check for 6523489 has started.
⚪ 2024-02-13 18:49:06 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-13 18:50:54 UTC Build successful.
⚪ 2024-02-13 18:51:04 UTC Tests are running...
🔴 2024-02-13 20:03:04 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67495 56460 0 20 10971 44

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

⚪ 2024-02-13 20:15:42 UTC Pre-commit check for 3a42bde has started.
⚪ 2024-02-13 20:15:44 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-13 20:17:05 UTC Build successful.
⚪ 2024-02-13 20:17:19 UTC Tests are running...
🔴 2024-02-13 20:26:29 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67495 56460 0 20 10971 44

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

⚪ 2024-02-13 20:17:17 UTC Pre-commit check for 3a42bde has started.
⚪ 2024-02-13 20:17:19 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-13 20:18:37 UTC Build successful.
⚪ 2024-02-13 20:18:49 UTC Tests are running...
🔴 2024-02-13 20:31:12 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14767 14550 0 24 147 46

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

⚪ 2024-02-13 20:47:10 UTC Pre-commit check for d730ccc has started.
⚪ 2024-02-13 20:47:13 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-13 20:49:00 UTC Build successful.
⚪ 2024-02-13 20:49:18 UTC Tests are running...
🔴 2024-02-13 22:02:24 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67394 56354 0 21 10971 48

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

⚪ 2024-02-13 20:49:30 UTC Pre-commit check for d730ccc has started.
⚪ 2024-02-13 20:49:34 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-13 20:51:13 UTC Build successful.
⚪ 2024-02-13 20:51:26 UTC Tests are running...
🔴 2024-02-13 22:26:37 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14770 14563 0 23 138 46

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

⚪ 2024-02-13 22:32:28 UTC Pre-commit check for 7a98699 has started.
⚪ 2024-02-13 22:32:31 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-13 22:33:43 UTC Build successful.
⚪ 2024-02-13 22:33:56 UTC Tests are running...
🔴 2024-02-13 22:42:37 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67394 56358 0 17 10971 48

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

⚪ 2024-02-13 22:32:47 UTC Pre-commit check for 7a98699 has started.
⚪ 2024-02-13 22:32:50 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-13 22:34:06 UTC Build successful.
⚪ 2024-02-13 22:34:18 UTC Tests are running...
🔴 2024-02-13 22:37:01 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14770 14567 0 19 138 46

@Enjection Enjection merged commit 284b7ef into ydb-platform:main Feb 14, 2024
This was referenced Feb 14, 2024
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmel1k shmel1k shmel1k approved these changes

@CyberROFL CyberROFL CyberROFL left review comments

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Enjection @CyberROFL @shmel1k