Skip to content

[Kafka API] Add forwarding of txn requests to coordinator #17765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 16, 2025
Merged

[Kafka API] Add forwarding of txn requests to coordinator #17765

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
39a35ed
remove kafka from actors names
a-serebryanskiy Apr 24, 2025
30f93a5
Merge branch 'main' into ydb-topics-kafka-transaction-actor-rename
a-serebryanskiy Apr 26, 2025
09896f6
rmeove kafka mention from tests
a-serebryanskiy Apr 26, 2025
de77224
add forwarding of kafka txn reqquests
a-serebryanskiy Apr 26, 2025
18a549f
Merge branch 'main' into ydb-topics-kafka-txn-requests-forwarding
a-serebryanskiy May 16, 2025
1f95382
fox merge error
a-serebryanskiy May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions ydb/core/kafka_proxy/kafka_connection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,42 @@ class TKafkaConnection: public TActorBootstrapped<TKafkaConnection>, public TNet
Register(CreateKafkaAlterConfigsActor(Context, header->CorrelationId, message));
}

void HandleMessage(const TRequestHeaderData* header, const TMessagePtr<TAddPartitionsToTxnRequestData>& message) {
Send(MakeTransactionsServiceID(), new TEvKafka::TEvAddPartitionsToTxnRequest(
header->CorrelationId,
message,
Context->ConnectionId,
Context->DatabasePath
));
}

void HandleMessage(const TRequestHeaderData* header, const TMessagePtr<TAddOffsetsToTxnRequestData>& message) {
Send(MakeTransactionsServiceID(), new TEvKafka::TEvAddOffsetsToTxnRequest(
header->CorrelationId,
message,
Context->ConnectionId,
Context->DatabasePath
));
}

void HandleMessage(const TRequestHeaderData* header, const TMessagePtr<TTxnOffsetCommitRequestData>& message) {
Send(MakeTransactionsServiceID(), new TEvKafka::TEvTxnOffsetCommitRequest(
header->CorrelationId,
message,
Context->ConnectionId,
Context->DatabasePath
));
}

void HandleMessage(const TRequestHeaderData* header, const TMessagePtr<TEndTxnRequestData>& message) {
Send(MakeTransactionsServiceID(), new TEvKafka::TEvEndTxnRequest(
header->CorrelationId,
message,
Context->ConnectionId,
Context->DatabasePath
));
}

template<class T>
TMessagePtr<T> Cast(std::shared_ptr<Msg>& request) {
return TMessagePtr<T>(request->Buffer, request->Message);
Expand Down Expand Up @@ -443,6 +479,22 @@ class TKafkaConnection: public TActorBootstrapped<TKafkaConnection>, public TNet
HandleMessage(&Request->Header, Cast<TAlterConfigsRequestData>(Request));
break;

case ADD_PARTITIONS_TO_TXN:
HandleMessage(&Request->Header, Cast<TAddPartitionsToTxnRequestData>(Request));
break;

case ADD_OFFSETS_TO_TXN:
HandleMessage(&Request->Header, Cast<TAddOffsetsToTxnRequestData>(Request));
break;

case TXN_OFFSET_COMMIT:
HandleMessage(&Request->Header, Cast<TTxnOffsetCommitRequestData>(Request));
break;

case END_TXN:
HandleMessage(&Request->Header, Cast<TEndTxnRequestData>(Request));
break;

default:
KAFKA_LOG_ERROR("Unsupported message: ApiKey=" << Request->Header.RequestApiKey);
PassAway();
Expand Down
Loading