Skip to content

Make it possible to return skiff from dq #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2024
Merged

Make it possible to return skiff from dq #1765

merged 1 commit into from
Feb 12, 2024

Conversation

Krisha11
Copy link
Collaborator

@Krisha11 Krisha11 commented Feb 9, 2024

Changelog entry

For use in yt yql dq

Changelog category

  • New feature

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@Krisha11 Krisha11 marked this pull request as ready for review February 9, 2024 12:01
@Krisha11 Krisha11 requested a review from a team as a code owner February 9, 2024 12:01
@resetius resetius added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Feb 9, 2024
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Feb 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024 •
edited
Loading

⚪ 2024-02-09 13:30:47 UTC Pre-commit check for 28332a1 has started.
⚪ 2024-02-09 13:30:49 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-09 13:32:22 UTC Build successful.
⚪ 2024-02-09 13:32:33 UTC Tests are running...
🔴 2024-02-09 14:57:51 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67412 56489 0 1 10892 30

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024 •
edited
Loading

⚪ 2024-02-09 13:33:57 UTC Pre-commit check for 28332a1 has started.
⚪ 2024-02-09 13:33:59 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-09 13:35:56 UTC Build successful.
⚪ 2024-02-09 13:43:18 UTC Tests are running...
🔴 2024-02-09 15:22:06 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14738 14524 0 13 165 36

resetius
resetius reviewed Feb 11, 2024
View reviewed changes
ydb/library/yql/providers/dq/provider/exec/yql_dq_exectransformer.cpp
class TDqExecTransformer: public TExecTransformerBase, TCounters
{
public:
TDqExecTransformer(const TDqStatePtr& state)
TDqExecTransformer(const TDqStatePtr& state, const ISkiffConverterPtr& skiffConverter)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second constructor argument looks foreign. But I don't know how to do it better.

@resetius resetius enabled auto-merge (squash) February 11, 2024 14:07
@resetius resetius merged commit b314cf4 into ydb-platform:main Feb 12, 2024
This was referenced Feb 12, 2024
Closed
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resetius resetius resetius approved these changes

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Krisha11 @resetius