Skip to content

Support sequences in SHOW CREATE TABLE #17488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2025
Merged

Support sequences in SHOW CREATE TABLE #17488

merged 3 commits into from
Apr 22, 2025

Conversation

@shnikd
Copy link
Contributor

@shnikd shnikd commented Apr 21, 2025 •
edited
Loading

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Support sequences in SHOW CREATE TABLE

@shnikd shnikd linked an issue Apr 21, 2025 that may be closed by this pull request
Support sequences in SHOW CREATE TABLE #17350
Closed
@github-actions
Copy link

github-actions bot commented Apr 21, 2025 •
edited
Loading

🟢 2025-04-21 12:50:25 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Apr 21, 2025 •
edited
Loading

⚪ 2025-04-21 12:47:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for d1a847c has started.
⚪ 2025-04-21 12:47:47 UTC Artifacts will be uploaded here
⚪ 2025-04-21 12:50:52 UTC ya make is running...
⚫ 2025-04-21 13:21:55 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 21, 2025 •
edited
Loading

⚪ 2025-04-21 12:49:48 UTC Pre-commit check linux-x86_64-release-asan for d1a847c has started.
⚪ 2025-04-21 12:50:04 UTC Artifacts will be uploaded here
⚪ 2025-04-21 12:52:56 UTC ya make is running...
⚫ 2025-04-21 13:21:54 UTC Check cancelled

gridnevvvit
gridnevvvit reviewed Apr 21, 2025
View reviewed changes
@shnikd shnikd force-pushed the alter-sequence-show-create-sequence branch from db0c754 to f4572aa Compare April 21, 2025 13:24
@shnikd shnikd requested a review from gridnevvvit April 21, 2025 13:25
@github-actions
Copy link

github-actions bot commented Apr 21, 2025 •
edited
Loading

⚪ 2025-04-21 13:33:04 UTC Pre-commit check linux-x86_64-release-asan for 3db9420 has started.
⚪ 2025-04-21 13:33:20 UTC Artifacts will be uploaded here
⚪ 2025-04-21 13:36:15 UTC ya make is running...
🟡 2025-04-21 14:52:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12590 12433 0 104 29 24

⚪ 2025-04-21 14:53:25 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-21 15:07:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
204 (only retried tests) 135 0 36 11 22

⚪ 2025-04-21 15:07:33 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-21 15:20:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
89 (only retried tests) 33 0 32 3 21

🟢 2025-04-21 15:20:57 UTC Build successful.
🟡 2025-04-21 15:21:27 UTC ydbd size 3.9 GiB changed* by +585.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7aa367a merge: 3db9420 diff diff %
ydbd size 4 148 051 640 Bytes 4 148 651 040 Bytes +585.4 KiB +0.014%
ydbd stripped size 1 432 035 736 Bytes 1 432 226 776 Bytes +186.6 KiB +0.013%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 21, 2025 •
edited
Loading

⚪ 2025-04-21 13:33:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3db9420 has started.
⚪ 2025-04-21 13:33:20 UTC Artifacts will be uploaded here
⚪ 2025-04-21 13:36:13 UTC ya make is running...
🟡 2025-04-21 14:38:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20242 18870 0 3 1267 102

⚪ 2025-04-21 14:40:20 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-21 14:51:21 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
161 (only retried tests) 71 0 0 0 90

🟢 2025-04-21 14:51:29 UTC Build successful.
🟡 2025-04-21 14:51:49 UTC ydbd size 2.2 GiB changed* by +345.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ef35ffe merge: 3db9420 diff diff %
ydbd size 2 363 870 160 Bytes 2 364 224 112 Bytes +345.7 KiB +0.015%
ydbd stripped size 493 930 560 Bytes 493 989 760 Bytes +57.8 KiB +0.012%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@shnikd shnikd enabled auto-merge (squash) April 21, 2025 17:07
@github-actions
Copy link

github-actions bot commented Apr 22, 2025 •
edited
Loading

⚪ 2025-04-22 11:27:56 UTC Pre-commit check linux-x86_64-release-asan for 15ae085 has started.
⚪ 2025-04-22 11:28:46 UTC Artifacts will be uploaded here
⚪ 2025-04-22 11:32:12 UTC ya make is running...
🟡 2025-04-22 12:48:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12614 12463 0 90 39 22

⚪ 2025-04-22 12:49:45 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-22 13:04:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
191 (only retried tests) 112 0 39 18 22

⚪ 2025-04-22 13:04:47 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-22 13:17:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
101 (only retried tests) 40 0 33 7 21

🟢 2025-04-22 13:17:09 UTC Build successful.
🟡 2025-04-22 13:17:42 UTC ydbd size 3.8 GiB changed* by +1.6 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0af4225 merge: 15ae085 diff diff %
ydbd size 4 130 829 640 Bytes 4 132 474 560 Bytes +1.6 MiB +0.040%
ydbd stripped size 1 430 283 800 Bytes 1 430 901 144 Bytes +602.9 KiB +0.043%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 22, 2025 •
edited
Loading

⚪ 2025-04-22 11:32:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 15ae085 has started.
⚪ 2025-04-22 11:33:14 UTC Artifacts will be uploaded here
⚪ 2025-04-22 11:36:35 UTC ya make is running...
🟡 2025-04-22 12:39:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20356 18965 0 9 1277 105

⚪ 2025-04-22 12:41:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-22 12:52:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
179 (only retried tests) 85 0 1 0 93

⚪ 2025-04-22 12:52:36 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-04-22 13:04:21 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
124 (only retried tests) 35 0 0 0 89

🟢 2025-04-22 13:04:29 UTC Build successful.
🟢 2025-04-22 13:04:50 UTC ydbd size 2.2 GiB changed* by +47.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c45eac2 merge: 15ae085 diff diff %
ydbd size 2 352 323 424 Bytes 2 352 372 120 Bytes +47.6 KiB +0.002%
ydbd stripped size 493 847 008 Bytes 493 855 392 Bytes +8.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@shnikd shnikd merged commit a8d7567 into ydb-platform:main Apr 22, 2025
13 checks passed
@shnikd shnikd mentioned this pull request Jun 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support sequences in SHOW CREATE TABLE

2 participants

@shnikd @gridnevvvit