Skip to content

Fix race condition between callback and destructor in TS3ExternalStorage #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2024
Merged

Fix race condition between callback and destructor in TS3ExternalStorage #1745

merged 1 commit into from
Feb 8, 2024

Conversation

@DimasKovas
Copy link
Contributor

@DimasKovas DimasKovas commented Feb 8, 2024

Changelog entry

Access the conditional variable RunningQueriesNotifier in the callback under the mutex to prevent a race condition between this access and the TS3ExternalStorage destruction.

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

The race is reproducible with ./ya make -ttt ydb/core/tx/schemeshard/ut_export -F=TExportToS3Tests::CorruptedDyNumber --sanitize=thread

@github-actions
Copy link

github-actions bot commented Feb 8, 2024

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@ivanmorozov333 ivanmorozov333 merged commit a2a4ddb into ydb-platform:main Feb 8, 2024
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request May 2, 2024
@DimasKovas @azevaykin
Fix race between callback and destructor (ydb-platform#1745)
c3faba0
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request May 2, 2024
@DimasKovas @azevaykin
Fix race between callback and destructor (ydb-platform#1745)
fc2dd27
azevaykin added a commit that referenced this pull request May 2, 2024
@azevaykin @DimasKovas
Fix race between callback and destructor (#1745) (#4224)
5097c74 
Co-authored-by: DimasKovas <34828390+DimasKovas@users.noreply.github.com>
azevaykin added a commit that referenced this pull request May 2, 2024
@azevaykin @DimasKovas
Fix race between callback and destructor (#1745) (#4222)
eae74a3 
Co-authored-by: DimasKovas <34828390+DimasKovas@users.noreply.github.com>
@mregrock mregrock mentioned this pull request May 15, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request May 24, 2024
Closed
This was referenced Jun 7, 2024
Closed
Closed
@CyberROFL CyberROFL mentioned this pull request Jun 19, 2024
Closed
@CyberROFL CyberROFL mentioned this pull request Jul 12, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 15, 2024
Closed
@CyberROFL CyberROFL mentioned this pull request Jul 30, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Aug 23, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivanmorozov333 ivanmorozov333 ivanmorozov333 approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DimasKovas @ivanmorozov333