Skip to content

Fixed errors of the distributed commit offset to the partition #17423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 21, 2025
Merged

Fixed errors of the distributed commit offset to the partition #17423

merged 16 commits into from
Apr 21, 2025

Conversation

nshestakov
Copy link
Collaborator

@nshestakov nshestakov commented Apr 18, 2025 •
edited
Loading

Changelog entry

Fixes for #11629

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@nshestakov nshestakov requested a review from a team as a code owner April 18, 2025 11:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

🟢 2025-04-18 11:49:32 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

⚪ 2025-04-18 11:49:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for bf4a9ba has started.
⚪ 2025-04-18 11:49:44 UTC Artifacts will be uploaded here
⚪ 2025-04-18 11:52:35 UTC ya make is running...
⚫ 2025-04-18 12:21:59 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

⚪ 2025-04-18 11:49:53 UTC Pre-commit check linux-x86_64-release-asan for bf4a9ba has started.
⚪ 2025-04-18 11:50:02 UTC Artifacts will be uploaded here
⚪ 2025-04-18 11:52:52 UTC ya make is running...
⚫ 2025-04-18 12:21:59 UTC Check cancelled

Alek5andr-Kotov
Alek5andr-Kotov reviewed Apr 18, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

⚪ 2025-04-18 12:23:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for 74db662 has started.
⚪ 2025-04-18 12:23:36 UTC Artifacts will be uploaded here
⚪ 2025-04-18 12:26:19 UTC ya make is running...
🟡 2025-04-18 13:46:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20133 18753 0 10 1261 109

⚪ 2025-04-18 13:48:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-18 14:00:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
184 (only retried tests) 80 0 7 0 97

⚪ 2025-04-18 14:00:14 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-04-18 14:11:00 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
142 (only retried tests) 42 0 7 0 93

🟢 2025-04-18 14:11:07 UTC Build successful.
🟢 2025-04-18 14:11:31 UTC ydbd size 2.2 GiB changed* by +7.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 68c43ae merge: 74db662 diff diff %
ydbd size 2 363 760 352 Bytes 2 363 768 456 Bytes +7.9 KiB +0.000%
ydbd stripped size 493 913 568 Bytes 493 914 784 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

⚪ 2025-04-18 12:28:16 UTC Pre-commit check linux-x86_64-release-asan for 74db662 has started.
⚪ 2025-04-18 12:28:30 UTC Artifacts will be uploaded here
⚪ 2025-04-18 12:31:15 UTC ya make is running...
🟡 2025-04-18 13:45:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12483 12335 0 93 29 26

⚪ 2025-04-18 13:46:56 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-18 13:59:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
210 (only retried tests) 139 0 44 5 22

⚪ 2025-04-18 13:59:34 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-18 14:11:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
102 (only retried tests) 40 0 38 1 23

🟢 2025-04-18 14:11:50 UTC Build successful.
🟢 2025-04-18 14:12:24 UTC ydbd size 3.9 GiB changed* by +12.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 68c43ae merge: 74db662 diff diff %
ydbd size 4 147 916 432 Bytes 4 147 929 232 Bytes +12.5 KiB +0.000%
ydbd stripped size 1 432 002 008 Bytes 1 432 004 888 Bytes +2.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov enabled auto-merge (squash) April 18, 2025 13:08
@nshestakov nshestakov requested a review from a team as a code owner April 20, 2025 11:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 20, 2025 •
edited
Loading

⚪ 2025-04-20 11:51:28 UTC Pre-commit check linux-x86_64-release-asan for b0becaa has started.
⚪ 2025-04-20 11:51:43 UTC Artifacts will be uploaded here
⚪ 2025-04-20 11:54:37 UTC ya make is running...
🟡 2025-04-20 13:15:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12531 12332 0 136 36 27

⚪ 2025-04-20 13:16:50 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-20 13:31:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
280 (only retried tests) 192 0 49 15 24

⚪ 2025-04-20 13:31:21 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-20 13:43:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
119 (only retried tests) 54 0 40 4 21

🟢 2025-04-20 13:43:51 UTC Build successful.
🟢 2025-04-20 13:44:22 UTC ydbd size 3.9 GiB changed* by +15.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c590a01 merge: b0becaa diff diff %
ydbd size 4 148 273 440 Bytes 4 148 289 056 Bytes +15.2 KiB +0.000%
ydbd stripped size 1 432 101 400 Bytes 1 432 105 112 Bytes +3.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 20, 2025 •
edited
Loading

⚪ 2025-04-20 11:51:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for b0becaa has started.
⚪ 2025-04-20 11:51:58 UTC Artifacts will be uploaded here
⚪ 2025-04-20 11:54:41 UTC ya make is running...
🟡 2025-04-20 12:59:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20183 18803 0 8 1267 105

⚪ 2025-04-20 13:01:00 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-20 13:13:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
177 (only retried tests) 74 0 7 0 96

⚪ 2025-04-20 13:13:19 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-04-20 13:21:40 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
140 (only retried tests) 40 0 7 0 93

🟢 2025-04-20 13:21:47 UTC Build successful.
🟢 2025-04-20 13:22:12 UTC ydbd size 2.2 GiB changed* by +7.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c590a01 merge: b0becaa diff diff %
ydbd size 2 363 960 776 Bytes 2 363 968 912 Bytes +7.9 KiB +0.000%
ydbd stripped size 493 946 624 Bytes 493 947 840 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 21, 2025 •
edited
Loading

⚪ 2025-04-21 09:05:02 UTC Pre-commit check linux-x86_64-release-asan for e74247f has started.
⚪ 2025-04-21 09:05:17 UTC Artifacts will be uploaded here
⚪ 2025-04-21 09:08:07 UTC ya make is running...
🟡 2025-04-21 10:29:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12531 12384 0 87 32 28

⚪ 2025-04-21 10:30:21 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-21 10:43:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
190 (only retried tests) 114 0 39 14 23

⚪ 2025-04-21 10:43:24 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-21 10:56:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
99 (only retried tests) 39 0 34 5 21

🟢 2025-04-21 10:56:18 UTC Build successful.
🟢 2025-04-21 10:56:50 UTC ydbd size 3.9 GiB changed* by -992 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: c590a01 merge: e74247f diff diff %
ydbd size 4 148 273 440 Bytes 4 148 272 448 Bytes -992 Bytes -0.000%
ydbd stripped size 1 432 101 400 Bytes 1 432 101 080 Bytes -320 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 21, 2025 •
edited
Loading

⚪ 2025-04-21 09:05:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for e74247f has started.
⚪ 2025-04-21 09:05:29 UTC Artifacts will be uploaded here
⚪ 2025-04-21 09:08:20 UTC ya make is running...
🟡 2025-04-21 10:20:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20183 18813 0 5 1261 104

⚪ 2025-04-21 10:22:50 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-21 10:33:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
167 (only retried tests) 69 0 2 0 96

⚪ 2025-04-21 10:33:20 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-04-21 10:43:48 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
132 (only retried tests) 36 0 2 0 94

🟢 2025-04-21 10:43:55 UTC Build successful.
🟢 2025-04-21 10:44:19 UTC ydbd size 2.2 GiB changed* by -960 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: c590a01 merge: e74247f diff diff %
ydbd size 2 363 960 776 Bytes 2 363 959 816 Bytes -960 Bytes -0.000%
ydbd stripped size 493 946 624 Bytes 493 946 560 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 21, 2025 •
edited
Loading

⚪ 2025-04-21 11:43:53 UTC Pre-commit check linux-x86_64-release-asan for 7dff9cc has started.
⚪ 2025-04-21 11:44:09 UTC Artifacts will be uploaded here
⚪ 2025-04-21 11:46:52 UTC ya make is running...
🟡 2025-04-21 13:17:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12531 12387 0 96 24 24

⚪ 2025-04-21 13:19:05 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-21 13:32:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
184 (only retried tests) 124 0 36 2 22

⚪ 2025-04-21 13:32:21 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-21 13:44:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
83 (only retried tests) 27 0 34 1 21

🟢 2025-04-21 13:44:42 UTC Build successful.
🟢 2025-04-21 13:45:16 UTC ydbd size 3.9 GiB changed* by +4.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7f0d628 merge: 7dff9cc diff diff %
ydbd size 4 148 049 592 Bytes 4 148 053 776 Bytes +4.1 KiB +0.000%
ydbd stripped size 1 432 034 648 Bytes 1 432 035 608 Bytes +960 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 21, 2025 •
edited
Loading

⚪ 2025-04-21 11:43:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7dff9cc has started.
⚪ 2025-04-21 11:44:20 UTC Artifacts will be uploaded here
⚪ 2025-04-21 11:47:48 UTC ya make is running...
🟡 2025-04-21 12:49:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20183 18812 0 2 1262 107

⚪ 2025-04-21 12:51:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-21 13:02:04 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
163 (only retried tests) 69 0 0 0 94

🟢 2025-04-21 13:02:11 UTC Build successful.
🟢 2025-04-21 13:02:35 UTC ydbd size 2.2 GiB changed* by +192 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7f0d628 merge: 7dff9cc diff diff %
ydbd size 2 363 869 888 Bytes 2 363 870 080 Bytes +192 Bytes +0.000%
ydbd stripped size 493 930 496 Bytes 493 930 624 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Gazizonoki
Gazizonoki approved these changes Apr 21, 2025
View reviewed changes
Copy link
Collaborator

@Gazizonoki Gazizonoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDK - ok

@nshestakov nshestakov merged commit 2530f5d into ydb-platform:main Apr 21, 2025
14 checks passed
@nshestakov nshestakov deleted the AP-commit-more-tests branch April 21, 2025 15:32
nshestakov added a commit to nshestakov/ydb that referenced this pull request Apr 21, 2025
@nshestakov
Fixed errors of the distributed commit offset to the partition (ydb-p…
4497a80 
…latform#17423)
nshestakov added a commit to nshestakov/ydb that referenced this pull request May 5, 2025
@nshestakov
Fixed errors of the distributed commit offset to the partition (ydb-p…
d38ff4d 
…latform#17423)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-serebryanskiy a-serebryanskiy a-serebryanskiy approved these changes

@Gazizonoki Gazizonoki Gazizonoki approved these changes

@Alek5andr-Kotov Alek5andr-Kotov Alek5andr-Kotov left review comments

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nshestakov @a-serebryanskiy @Gazizonoki @Alek5andr-Kotov