Skip to content

change partitioning in tpch #17416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 18, 2025
Merged

change partitioning in tpch #17416

merged 5 commits into from
Apr 18, 2025

Conversation

iddqdex
Copy link
Collaborator

@iddqdex iddqdex commented Apr 18, 2025 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

⚪ 2025-04-18 10:12:58 UTC Pre-commit check linux-x86_64-release-asan for 81ea92d has started.
⚪ 2025-04-18 10:13:02 UTC Artifacts will be uploaded here
⚪ 2025-04-18 10:15:21 UTC ya make is running...
🟡 2025-04-18 10:36:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
668 634 0 4 20 10

⚪ 2025-04-18 10:37:06 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-18 10:48:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
35 (only retried tests) 22 0 3 0 10

⚪ 2025-04-18 10:48:31 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-18 10:59:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14 (only retried tests) 2 0 3 0 9

🟢 2025-04-18 10:59:49 UTC Build successful.
🟢 2025-04-18 11:00:05 UTC ydbd size 3.9 GiB changed* by +144 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0fbe2c4 merge: 81ea92d diff diff %
ydbd size 4 147 911 984 Bytes 4 147 912 128 Bytes +144 Bytes +0.000%
ydbd stripped size 1 432 001 816 Bytes 1 432 001 944 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

🟢 2025-04-21 13:56:52 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

⚪ 2025-04-18 10:14:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for 81ea92d has started.
⚪ 2025-04-18 10:14:57 UTC Artifacts will be uploaded here
⚪ 2025-04-18 10:17:09 UTC ya make is running...
🟢 2025-04-18 10:46:54 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1158 1143 0 0 6 9

🟢 2025-04-18 10:47:04 UTC Build successful.
🟢 2025-04-18 10:47:14 UTC ydbd size 2.2 GiB changed* by +112 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0fbe2c4 merge: 81ea92d diff diff %
ydbd size 2 363 755 792 Bytes 2 363 755 904 Bytes +112 Bytes +0.000%
ydbd stripped size 493 912 736 Bytes 493 912 800 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@iddqdex iddqdex requested a review from a team as a code owner April 18, 2025 11:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

⚪ 2025-04-18 11:09:55 UTC Pre-commit check linux-x86_64-release-asan for 47a3e0c has started.
⚪ 2025-04-18 11:10:05 UTC Artifacts will be uploaded here
⚪ 2025-04-18 11:12:27 UTC ya make is running...
🟡 2025-04-18 11:41:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
668 632 0 5 21 10

⚪ 2025-04-18 11:41:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-18 11:43:08 UTC ydbd size 3.9 GiB changed* by +4.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3745d96 merge: 47a3e0c diff diff %
ydbd size 4 147 912 224 Bytes 4 147 916 336 Bytes +4.0 KiB +0.000%
ydbd stripped size 1 432 002 008 Bytes 1 432 001 944 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-04-18 11:43:10 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

⚪ 2025-04-18 11:12:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for 47a3e0c has started.
⚪ 2025-04-18 11:12:55 UTC Artifacts will be uploaded here
⚪ 2025-04-18 11:15:15 UTC ya make is running...
🟢 2025-04-18 11:42:19 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1158 1142 0 0 6 10

🟢 2025-04-18 11:42:32 UTC Build successful.
🟢 2025-04-18 11:42:42 UTC ydbd size 2.2 GiB changed* by +4.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3745d96 merge: 47a3e0c diff diff %
ydbd size 2 363 755 904 Bytes 2 363 760 352 Bytes +4.3 KiB +0.000%
ydbd stripped size 493 912 800 Bytes 493 913 568 Bytes +768 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-04-18 11:42:44 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

⚪ 2025-04-18 11:44:25 UTC Pre-commit check linux-x86_64-release-asan for 99d530f has started.
⚪ 2025-04-18 11:44:31 UTC Artifacts will be uploaded here
⚪ 2025-04-18 11:46:49 UTC ya make is running...
⚫ 2025-04-18 11:48:53 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

⚪ 2025-04-18 11:44:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 99d530f has started.
⚪ 2025-04-18 11:44:54 UTC Artifacts will be uploaded here
⚪ 2025-04-18 11:47:36 UTC ya make is running...
⚫ 2025-04-18 11:48:47 UTC Check cancelled

pnv1
pnv1 reviewed Apr 18, 2025
View reviewed changes
@iddqdex @pnv1
Update ydb/library/workload/tpc_base/tpc_base.cpp
fc3098b 
Co-authored-by: Nikolay Perfilov <pnv1@yandex-team.ru>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

⚪ 2025-04-18 11:50:51 UTC Pre-commit check linux-x86_64-release-asan for c0662ef has started.
⚪ 2025-04-18 11:51:06 UTC Artifacts will be uploaded here
⚫ 2025-04-18 11:52:38 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

⚪ 2025-04-18 11:50:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for c0662ef has started.
⚪ 2025-04-18 11:51:07 UTC Artifacts will be uploaded here
⚫ 2025-04-18 11:52:38 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

⚪ 2025-04-18 11:53:53 UTC Pre-commit check linux-x86_64-release-asan for dcefd7b has started.
⚪ 2025-04-18 11:53:57 UTC Artifacts will be uploaded here
⚪ 2025-04-18 11:56:16 UTC ya make is running...
🟡 2025-04-18 12:18:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
668 629 0 4 26 9

⚪ 2025-04-18 12:18:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-18 12:29:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40 (only retried tests) 26 0 3 3 8

⚪ 2025-04-18 12:29:35 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-18 12:41:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15 (only retried tests) 3 0 3 2 7

🟢 2025-04-18 12:41:10 UTC Build successful.
🟢 2025-04-18 12:41:28 UTC ydbd size 3.9 GiB changed* by +4.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3892bcc merge: dcefd7b diff diff %
ydbd size 4 147 912 224 Bytes 4 147 916 336 Bytes +4.0 KiB +0.000%
ydbd stripped size 1 432 002 008 Bytes 1 432 001 944 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

⚪ 2025-04-18 11:54:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for dcefd7b has started.
⚪ 2025-04-18 11:54:12 UTC Artifacts will be uploaded here
⚪ 2025-04-18 11:56:42 UTC ya make is running...
🟢 2025-04-18 12:21:06 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1158 1141 0 0 8 9

🟢 2025-04-18 12:21:20 UTC Build successful.
🟢 2025-04-18 12:21:30 UTC ydbd size 2.2 GiB changed* by +4.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3892bcc merge: dcefd7b diff diff %
ydbd size 2 363 755 904 Bytes 2 363 760 352 Bytes +4.3 KiB +0.000%
ydbd stripped size 493 912 800 Bytes 493 913 568 Bytes +768 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@iddqdex iddqdex enabled auto-merge (squash) April 18, 2025 12:03
@iddqdex iddqdex merged commit a0b1351 into ydb-platform:main Apr 18, 2025
13 checks passed
@iddqdex iddqdex deleted the tpch-partitions branch April 18, 2025 14:26
@galnat
Copy link
Collaborator

galnat commented May 19, 2025

@iddqdex давай допишем про эти параметры в документацию - https://ydb.tech/docs/en/reference/ydb-cli/workload-tpch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnv1 pnv1 pnv1 approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iddqdex @galnat @pnv1