Skip to content

Implement NodeBroker Delta Protocol (server-side) #17284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 23, 2025
Merged

Implement NodeBroker Delta Protocol (server-side) #17284

merged 7 commits into from
Apr 23, 2025

Conversation

@pixcc
Copy link
Member

@pixcc pixcc commented Apr 16, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

@pixcc pixcc linked an issue Apr 16, 2025 that may be closed by this pull request
Implement NodeBroker Delta Protocol (client-side) #15978
Closed
@github-actions
Copy link

github-actions bot commented Apr 16, 2025

🟢 2025-04-16 13:27:13 UTC The validation of the Pull Request description is successful.

@pixcc pixcc removed a link to an issue Apr 16, 2025
Implement NodeBroker Delta Protocol (client-side) #15978
Closed
@pixcc pixcc linked an issue Apr 16, 2025 that may be closed by this pull request
Implement NodeBroker Delta Protocol (server-side) #15977
Closed
@github-actions
Copy link

github-actions bot commented Apr 16, 2025 •
edited
Loading

⚪ 2025-04-16 13:27:47 UTC Pre-commit check linux-x86_64-release-asan for 0a2f6c3 has started.
⚪ 2025-04-16 13:28:13 UTC Artifacts will be uploaded here
⚪ 2025-04-16 13:32:00 UTC ya make is running...
🟡 2025-04-16 15:28:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14453 14247 0 132 37 37

⚪ 2025-04-16 15:29:40 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-16 15:45:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
265 (only retried tests) 171 0 41 16 37

⚪ 2025-04-16 15:45:14 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-16 15:57:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
129 (only retried tests) 55 0 36 2 36

🟢 2025-04-16 15:58:00 UTC Build successful.
🟡 2025-04-16 15:58:35 UTC ydbd size 3.9 GiB changed* by +747.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: bccba30 merge: 0a2f6c3 diff diff %
ydbd size 4 144 473 304 Bytes 4 145 238 240 Bytes +747.0 KiB +0.018%
ydbd stripped size 1 430 982 536 Bytes 1 431 266 632 Bytes +277.4 KiB +0.020%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pixcc pixcc requested a review from snaury April 16, 2025 13:29
@github-actions
Copy link

github-actions bot commented Apr 16, 2025 •
edited
Loading

⚪ 2025-04-16 13:30:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0a2f6c3 has started.
⚪ 2025-04-16 13:30:46 UTC Artifacts will be uploaded here
⚪ 2025-04-16 13:33:56 UTC ya make is running...
🟢 2025-04-16 15:17:12 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29113 26416 0 0 2576 121

🟢 2025-04-16 15:19:36 UTC Build successful.
🟡 2025-04-16 15:19:56 UTC ydbd size 2.2 GiB changed* by +418.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: bccba30 merge: 0a2f6c3 diff diff %
ydbd size 2 361 907 944 Bytes 2 362 336 944 Bytes +418.9 KiB +0.018%
ydbd stripped size 493 586 752 Bytes 493 675 616 Bytes +86.8 KiB +0.018%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pixcc pixcc force-pushed the node-broker-delta-protocol-server-side branch from e450053 to 5a65d95 Compare April 21, 2025 14:47
@pixcc pixcc marked this pull request as ready for review April 21, 2025 14:48
@pixcc pixcc requested a review from a team as a code owner April 21, 2025 14:48
@github-actions
Copy link

github-actions bot commented Apr 21, 2025 •
edited
Loading

⚪ 2025-04-21 14:49:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for ab4c3b2 has started.
⚪ 2025-04-21 14:49:50 UTC Artifacts will be uploaded here
⚪ 2025-04-21 14:53:05 UTC ya make is running...
🟡 2025-04-21 16:37:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29317 26637 0 4 2569 107

⚪ 2025-04-21 16:39:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-21 16:52:38 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
163 (only retried tests) 68 0 0 0 95

🟢 2025-04-21 16:52:45 UTC Build successful.
🟡 2025-04-21 16:53:12 UTC ydbd size 2.2 GiB changed* by +218.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 2530f5d merge: ab4c3b2 diff diff %
ydbd size 2 351 384 816 Bytes 2 351 608 720 Bytes +218.7 KiB +0.010%
ydbd stripped size 493 681 280 Bytes 493 732 288 Bytes +49.8 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 21, 2025 •
edited
Loading

⚪ 2025-04-21 14:51:02 UTC Pre-commit check linux-x86_64-release-asan for ab4c3b2 has started.
⚪ 2025-04-21 14:51:17 UTC Artifacts will be uploaded here
⚪ 2025-04-21 14:54:25 UTC ya make is running...
🟡 2025-04-21 16:49:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14640 14509 0 65 39 27

⚪ 2025-04-21 16:50:49 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-21 17:03:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
168 (only retried tests) 91 0 37 16 24

⚪ 2025-04-21 17:04:05 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-21 17:16:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
100 (only retried tests) 41 0 33 3 23

🟢 2025-04-21 17:16:40 UTC Build successful.
🟡 2025-04-21 17:17:12 UTC ydbd size 3.8 GiB changed* by +375.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 2530f5d merge: ab4c3b2 diff diff %
ydbd size 4 130 241 088 Bytes 4 130 625 992 Bytes +375.9 KiB +0.009%
ydbd stripped size 1 430 084 312 Bytes 1 430 236 248 Bytes +148.4 KiB +0.011%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pixcc pixcc removed the request for review from stanislav-shchetinin April 21, 2025 14:51
snaury
snaury reviewed Apr 21, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Apr 22, 2025 •
edited
Loading

⚪ 2025-04-22 15:50:20 UTC Pre-commit check linux-x86_64-release-asan for a4e4987 has started.
⚪ 2025-04-22 15:50:37 UTC Artifacts will be uploaded here
⚪ 2025-04-22 15:53:45 UTC ya make is running...
⚫ 2025-04-22 15:58:19 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 22, 2025 •
edited
Loading

⚪ 2025-04-22 15:50:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for a4e4987 has started.
⚪ 2025-04-22 15:50:37 UTC Artifacts will be uploaded here
⚪ 2025-04-22 15:53:49 UTC ya make is running...
⚫ 2025-04-22 15:58:18 UTC Check cancelled

@pixcc pixcc requested a review from snaury April 22, 2025 15:50
@github-actions
Copy link

github-actions bot commented Apr 22, 2025 •
edited
Loading

⚪ 2025-04-22 16:01:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 47c6263 has started.
⚪ 2025-04-22 16:01:37 UTC Artifacts will be uploaded here
⚪ 2025-04-22 16:05:21 UTC ya make is running...
🔴 2025-04-22 16:14:05 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Apr 22, 2025 •
edited
Loading

⚪ 2025-04-22 16:02:23 UTC Pre-commit check linux-x86_64-release-asan for 47c6263 has started.
⚪ 2025-04-22 16:02:38 UTC Artifacts will be uploaded here
⚪ 2025-04-22 16:05:46 UTC ya make is running...
⚫ 2025-04-22 16:15:04 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 22, 2025 •
edited
Loading

⚪ 2025-04-22 16:18:52 UTC Pre-commit check linux-x86_64-release-asan for 003dc40 has started.
⚪ 2025-04-22 16:18:56 UTC Artifacts will be uploaded here
⚪ 2025-04-22 16:21:59 UTC ya make is running...
⚫ 2025-04-22 17:42:37 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 22, 2025 •
edited
Loading

⚪ 2025-04-22 16:20:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 003dc40 has started.
⚪ 2025-04-22 16:20:15 UTC Artifacts will be uploaded here
⚪ 2025-04-22 16:23:25 UTC ya make is running...
⚫ 2025-04-22 17:42:40 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 22, 2025 •
edited
Loading

⚪ 2025-04-22 17:43:32 UTC Pre-commit check linux-x86_64-release-asan for 1624abf has started.
⚪ 2025-04-22 17:44:08 UTC Artifacts will be uploaded here
⚪ 2025-04-22 17:48:16 UTC ya make is running...
🟡 2025-04-22 19:22:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14674 14514 0 90 45 25

⚪ 2025-04-22 19:23:45 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-22 19:37:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
211 (only retried tests) 139 0 38 11 23

⚪ 2025-04-22 19:37:23 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-22 19:50:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
94 (only retried tests) 37 0 35 1 21

🟢 2025-04-22 19:50:17 UTC Build successful.
🟡 2025-04-22 19:50:48 UTC ydbd size 3.9 GiB changed* by +366.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7a3575f merge: 1624abf diff diff %
ydbd size 4 133 668 960 Bytes 4 134 044 096 Bytes +366.3 KiB +0.009%
ydbd stripped size 1 431 182 104 Bytes 1 431 329 112 Bytes +143.6 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 22, 2025 •
edited
Loading

⚪ 2025-04-22 17:44:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1624abf has started.
⚪ 2025-04-22 17:44:30 UTC Artifacts will be uploaded here
⚪ 2025-04-22 17:47:41 UTC ya make is running...
🟡 2025-04-22 18:59:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29443 26734 0 7 2590 112

⚪ 2025-04-22 19:02:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-22 19:15:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
193 (only retried tests) 90 0 1 8 94

⚪ 2025-04-22 19:15:14 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-04-22 19:27:23 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
132 (only retried tests) 39 0 0 0 93

🟢 2025-04-22 19:27:30 UTC Build successful.
🟡 2025-04-22 19:27:54 UTC ydbd size 2.2 GiB changed* by +214.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7a3575f merge: 1624abf diff diff %
ydbd size 2 353 085 464 Bytes 2 353 304 952 Bytes +214.3 KiB +0.009%
ydbd stripped size 493 951 968 Bytes 494 001 440 Bytes +48.3 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

snaury
snaury reviewed Apr 23, 2025
View reviewed changes
@pixcc pixcc requested a review from snaury April 23, 2025 11:41
@github-actions
Copy link

github-actions bot commented Apr 23, 2025 •
edited
Loading

⚪ 2025-04-23 11:53:02 UTC Pre-commit check linux-x86_64-release-asan for 3d3b8e9 has started.
⚪ 2025-04-23 11:53:34 UTC Artifacts will be uploaded here
⚪ 2025-04-23 11:57:23 UTC ya make is running...
⚫ 2025-04-23 12:34:31 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 23, 2025 •
edited
Loading

⚪ 2025-04-23 12:00:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3d3b8e9 has started.
⚪ 2025-04-23 12:01:20 UTC Artifacts will be uploaded here
⚪ 2025-04-23 12:05:01 UTC ya make is running...
⚫ 2025-04-23 12:34:31 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 23, 2025 •
edited
Loading

⚪ 2025-04-23 12:35:54 UTC Pre-commit check linux-x86_64-release-asan for 4546877 has started.
⚪ 2025-04-23 12:36:10 UTC Artifacts will be uploaded here
⚪ 2025-04-23 12:39:26 UTC ya make is running...
🟡 2025-04-23 14:07:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14688 14480 0 136 47 25

⚪ 2025-04-23 14:08:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-23 14:22:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
255 (only retried tests) 186 0 39 8 22

⚪ 2025-04-23 14:22:16 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-23 14:34:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
94 (only retried tests) 35 0 33 4 22

🟢 2025-04-23 14:34:47 UTC Build successful.
🟡 2025-04-23 14:35:20 UTC ydbd size 3.9 GiB changed* by +469.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9731c04 merge: 4546877 diff diff %
ydbd size 4 133 758 840 Bytes 4 134 239 544 Bytes +469.4 KiB +0.012%
ydbd stripped size 1 431 217 464 Bytes 1 431 412 600 Bytes +190.6 KiB +0.014%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 23, 2025 •
edited
Loading

⚪ 2025-04-23 12:41:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4546877 has started.
⚪ 2025-04-23 12:41:27 UTC Artifacts will be uploaded here
⚪ 2025-04-23 12:44:43 UTC ya make is running...
🟡 2025-04-23 14:02:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29458 26764 0 5 2585 104

⚪ 2025-04-23 14:04:59 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-23 14:16:57 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
171 (only retried tests) 76 0 0 0 95

🟢 2025-04-23 14:17:04 UTC Build successful.
🟡 2025-04-23 14:17:26 UTC ydbd size 2.2 GiB changed* by +269.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9731c04 merge: 4546877 diff diff %
ydbd size 2 353 140 576 Bytes 2 353 416 272 Bytes +269.2 KiB +0.012%
ydbd stripped size 493 968 736 Bytes 494 032 064 Bytes +61.8 KiB +0.013%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

snaury
snaury approved these changes Apr 23, 2025
View reviewed changes
@pixcc pixcc merged commit f200790 into ydb-platform:main Apr 23, 2025
16 checks passed
pixcc added a commit to pixcc/ydb that referenced this pull request Jul 11, 2025
@pixcc
Implement NodeBroker Delta Protocol (server-side) (ydb-platform#17284)
c35f878
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snaury snaury snaury approved these changes

@CyberROFL CyberROFL CyberROFL approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement NodeBroker Delta Protocol (server-side)

3 participants

@pixcc @snaury @CyberROFL