Skip to content

Reapply "Support returning list in delete statements (#1684)" (#1705) #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2024
Merged

Reapply "Support returning list in delete statements (#1684)" (#1705) #1706

merged 2 commits into from
Feb 8, 2024

Conversation

@ssmike
Copy link
Contributor

@ssmike ssmike commented Feb 8, 2024

No description provided.

@github-actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 10:54:37 UTC Pre-commit check for ae86cbc has started.
⚪ 2024-02-08 10:54:40 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-08 10:55:49 UTC Build successful.
⚪ 2024-02-08 10:56:01 UTC Tests are running...
🔴 2024-02-08 11:29:34 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67244 55918 0 482 10820 24

@github-actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 10:56:42 UTC Pre-commit check for ae86cbc has started.
⚪ 2024-02-08 10:56:45 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-08 10:57:54 UTC Build successful.
⚪ 2024-02-08 10:58:06 UTC Tests are running...
🔴 2024-02-08 11:47:20 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14586 13999 0 490 69 28

@github-actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 12:28:32 UTC Pre-commit check for 404f362 has started.
⚪ 2024-02-08 12:28:36 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-08 12:32:35 UTC Build successful.
⚪ 2024-02-08 12:32:47 UTC Tests are running...
🟢 2024-02-08 14:36:13 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67266 56413 0 0 10822 31

@github-actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 12:28:46 UTC Pre-commit check for 404f362 has started.
⚪ 2024-02-08 12:28:48 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-08 12:33:12 UTC Build successful.
⚪ 2024-02-08 12:33:24 UTC Tests are running...
🔴 2024-02-08 14:07:04 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14591 14500 0 16 53 22

@ssmike ssmike requested review from gridnevvvit and qrort February 8, 2024 13:11
qrort
qrort reviewed Feb 8, 2024
View reviewed changes
ydb/core/kqp/opt/physical/effects/kqp_opt_phy_returning.cpp
.Input(del.Input())
.Build()
.Table(del.Table())
.ReturningColumns<TCoAtomList>().Build()
Copy link
Collaborator

@qrort qrort Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

К сожалению, не очень понял: мы не передаем сюда del.ReturningColumns(), а конструируем пустой лист?

ydb/core/kqp/opt/kqp_opt_kql.cpp
auto indexDelete = Build<TKqlDeleteRows>(ctx, update.Pos())
.Table(indexMeta)
.Input(ProjectColumns(rowsToUpdate, indexTableColumns, ctx))
.ReturningColumns<TCoAtomList>().Build()
Copy link
Collaborator

@qrort qrort Feb 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а можно не добоавлять чайлда, наверное?

Copy link
Contributor Author

@ssmike ssmike Feb 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ну совершенно точно это нужная штука. Надо будет поправить правила про ExtractMembers логические к примеру

@ssmike ssmike merged commit 33ba54d into ydb-platform:main Feb 8, 2024
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
@ssmike ssmike deleted the returning-delete branch February 20, 2024 17:08
This was referenced Feb 21, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qrort qrort qrort left review comments

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ssmike @gridnevvvit @qrort