Skip to content

refactoring before SHOW CREATE VIEW #16629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025

Conversation

jepett0
Copy link
Collaborator

@jepett0 jepett0 commented Apr 1, 2025

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Issues:

Refactoring so that the future addition of the SHOW CREATE VIEW will be easier.

@jepett0 jepett0 requested a review from a team as a code owner April 1, 2025 16:59
@jepett0 jepett0 requested review from CyberROFL and shnikd April 1, 2025 16:59
Copy link

github-actions bot commented Apr 1, 2025

🟢 2025-04-01 17:00:23 UTC The validation of the Pull Request description is successful.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@jepett0 jepett0 linked an issue Apr 1, 2025 that may be closed by this pull request
1 task
@jepett0 jepett0 requested a review from CyberROFL April 2, 2025 10:38
Copy link

github-actions bot commented Apr 2, 2025

2025-04-02 10:39:29 UTC Pre-commit check linux-x86_64-release-asan for c3c8ee1 has started.
2025-04-02 10:39:44 UTC Artifacts will be uploaded here
2025-04-02 10:42:32 UTC ya make is running...
🟡 2025-04-02 12:01:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12619 12443 0 104 37 35

2025-04-02 12:02:09 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-02 12:14:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
226 (only retried tests) 153 0 33 11 29

2025-04-02 12:14:43 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-02 12:26:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
99 (only retried tests) 33 0 31 6 29

🟢 2025-04-02 12:26:35 UTC Build successful.
🟢 2025-04-02 12:27:02 UTC ydbd size 3.8 GiB changed* by -10.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8c85a42 merge: c3c8ee1 diff diff %
ydbd size 4 123 912 016 Bytes 4 123 901 328 Bytes -10.4 KiB -0.000%
ydbd stripped size 1 424 956 424 Bytes 1 424 956 552 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Apr 2, 2025

2025-04-02 10:40:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for c3c8ee1 has started.
2025-04-02 10:40:57 UTC Artifacts will be uploaded here
2025-04-02 10:43:47 UTC ya make is running...
🟡 2025-04-02 11:47:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27047 24389 0 5 2544 109

2025-04-02 11:49:21 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-02 12:00:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
161 (only retried tests) 63 0 1 0 97

2025-04-02 12:00:38 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-04-02 12:12:14 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
133 (only retried tests) 36 0 0 0 97

🟢 2025-04-02 12:12:21 UTC Build successful.
🟢 2025-04-02 12:12:43 UTC ydbd size 2.2 GiB changed* by -6.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f321564 merge: c3c8ee1 diff diff %
ydbd size 2 350 345 208 Bytes 2 350 338 936 Bytes -6.1 KiB -0.000%
ydbd stripped size 491 562 688 Bytes 491 562 112 Bytes -576 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@jepett0 jepett0 enabled auto-merge (squash) April 2, 2025 12:22
@jepett0 jepett0 merged commit 4d6d062 into ydb-platform:main Apr 2, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

view: show create
3 participants