Skip to content

Conversation

@jepett0
Copy link
Contributor

@jepett0 jepett0 commented Mar 28, 2025

Changelog entry

Making SHOW CREATE TABLE fail on views rather than produce wrong output.

Changelog category

  • Bugfix

Description for reviewers

Issue:

@github-actions
Copy link

🟢 2025-03-28 15:38:12 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Mar 28, 2025

2025-03-28 15:38:15 UTC Pre-commit check linux-x86_64-release-asan for 80be3a2 has started.
2025-03-28 15:38:30 UTC Artifacts will be uploaded here
2025-03-28 15:41:17 UTC ya make is running...
🟡 2025-03-28 16:58:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12593 12466 0 74 19 34

2025-03-28 17:00:26 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-28 17:13:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
172 (only retried tests) 109 0 33 1 29

2025-03-28 17:14:01 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-28 17:25:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
92 (only retried tests) 31 0 32 1 28

🟢 2025-03-28 17:25:53 UTC Build successful.
🟢 2025-03-28 17:26:25 UTC ydbd size 3.8 GiB changed* by +22.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0610a4d merge: 80be3a2 diff diff %
ydbd size 4 119 634 152 Bytes 4 119 656 792 Bytes +22.1 KiB +0.001%
ydbd stripped size 1 423 891 528 Bytes 1 423 898 824 Bytes +7.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@jepett0 jepett0 marked this pull request as ready for review March 28, 2025 15:38
@jepett0 jepett0 requested a review from a team as a code owner March 28, 2025 15:38
@github-actions
Copy link

github-actions bot commented Mar 28, 2025

2025-03-28 15:46:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 80be3a2 has started.
2025-03-28 15:46:30 UTC Artifacts will be uploaded here
2025-03-28 15:49:15 UTC ya make is running...
🟡 2025-03-28 16:54:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27003 24341 0 2 2548 112

2025-03-28 16:57:49 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-28 17:08:39 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
158 (only retried tests) 60 0 0 0 98

🟢 2025-03-28 17:08:49 UTC Build successful.
🟢 2025-03-28 17:09:10 UTC ydbd size 2.2 GiB changed* by +176 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4d4d83d merge: 80be3a2 diff diff %
ydbd size 2 347 491 904 Bytes 2 347 492 080 Bytes +176 Bytes +0.000%
ydbd stripped size 490 849 536 Bytes 490 849 664 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Member

@CyberROFL CyberROFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jepett0 jepett0 merged commit 358728e into ydb-platform:main Mar 29, 2025
15 checks passed
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix changelog/f25-3 PR участвует в списке изменений

Projects

None yet

Development

Successfully merging this pull request may close these issues.

show create table: when targeting a view that reads from a table t, produces results of a 'select * from t'

5 participants