Skip to content

store history of changes made to hive via http #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 12, 2024
Merged

store history of changes made to hive via http #1637

merged 4 commits into from
Feb 12, 2024

Conversation

@vporyadke
Copy link
Collaborator

@vporyadke vporyadke commented Feb 6, 2024

Changelog entry

You can now view history of changes made to hive settings through http requests (Only works for changes made after the introduction of this feature)

Changelog category

  • New feature

Additional information

...

@github-actions
Copy link

github-actions bot commented Feb 6, 2024 •
edited
Loading

⚪ 2024-02-06 16:42:29 UTC Pre-commit check for ce17d11 has started.
⚪ 2024-02-06 16:42:30 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-02-06 17:23:59 UTC Build failed. see the build logs.
⚪ 2024-02-06 17:24:09 UTC Tests are running...
🔴 2024-02-06 17:57:31 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
50021 40485 0 267 9258 11

@github-actions
Copy link

github-actions bot commented Feb 6, 2024 •
edited
Loading

⚪ 2024-02-06 16:42:42 UTC Pre-commit check for ce17d11 has started.
⚪ 2024-02-06 16:42:45 UTC Build linux-x86_64-release-asan is running...
🔴 2024-02-06 17:26:34 UTC Build failed. see the build logs.
⚪ 2024-02-06 17:26:46 UTC Tests are running...
🔴 2024-02-06 17:42:35 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6011 5734 0 260 4 13

@vporyadke
Copy link
Collaborator Author

vporyadke commented Feb 6, 2024

image

adameat
adameat requested changes Feb 6, 2024
View reviewed changes
ydb/core/mind/hive/hive_schema.h Outdated
struct OperationsLog : Table<21> {
struct Timestamp : Column<1, NScheme::NTypeIds::Uint64> {};
struct User : Column<2, NScheme::NTypeIds::String> {};
struct Operation : Column<3, NScheme::NTypeIds::String> { using Type = NKikimrHive::TOperation; };
Copy link
Member

@adameat adameat Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you actually need these complex protobuf specs just for logging purposes. And think about migrations and rollbacks - it could became a huge pain...
I think just a free text would be more than enough. (or json if you need some structure to parse)

@vporyadke vporyadke requested review from a team as code owners February 9, 2024 14:22
@github-actions
Copy link

github-actions bot commented Feb 9, 2024 •
edited
Loading

⚪ 2024-02-09 14:45:02 UTC Pre-commit check for f0dc0bc has started.
⚪ 2024-02-09 14:45:05 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-09 15:25:50 UTC Build successful.
⚪ 2024-02-09 15:26:03 UTC Tests are running...
🔴 2024-02-09 17:11:20 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14740 14505 0 22 163 50

@github-actions
Copy link

github-actions bot commented Feb 9, 2024 •
edited
Loading

⚪ 2024-02-09 14:45:04 UTC Pre-commit check for f0dc0bc has started.
⚪ 2024-02-09 14:45:07 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-09 15:24:59 UTC Build successful.
⚪ 2024-02-09 15:25:12 UTC Tests are running...
🔴 2024-02-09 17:07:04 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67310 56369 0 2 10892 47

@vporyadke vporyadke merged commit c1d5a30 into ydb-platform:main Feb 12, 2024
This was referenced Feb 12, 2024
Closed
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
This was referenced Feb 21, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adameat adameat adameat approved these changes

Assignees

No one assigned

Labels

new-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vporyadke @adameat