Skip to content

Unifying column names validation for both row and column tables #14722 #16318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Emgariko
Copy link
Collaborator

@Emgariko Emgariko commented Mar 27, 2025

Changelog entry

Unifying column names validation for both row and column tables #14722

Changelog category

  • Bugfix

Description for reviewers

Added name validation call used in row tables to column tables(link). Covered with tests - testing Create/Alter TABLE/ColumnStore behavior.
...

@Emgariko Emgariko requested a review from a team as a code owner March 27, 2025 09:57
@Emgariko Emgariko self-assigned this Mar 27, 2025
@Emgariko Emgariko linked an issue Mar 27, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Mar 27, 2025

2025-03-27 10:01:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8ff5f8e has started.
2025-03-27 10:01:08 UTC Artifacts will be uploaded here
2025-03-27 10:04:04 UTC ya make is running...
🟡 2025-03-27 11:05:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19184 17827 0 4 1220 133

2025-03-27 11:07:14 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-27 11:37:44 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
209 (only retried tests) 76 0 0 5 128

🟢 2025-03-27 11:37:51 UTC Build successful.
🟢 2025-03-27 11:38:11 UTC ydbd size 2.1 GiB changed* by +992 Bytes, which is < 100.0 KiB vs stable-25-1-analytics: OK

ydbd size dash stable-25-1-analytics: 5b40aa0 merge: 8ff5f8e diff diff %
ydbd size 2 274 533 464 Bytes 2 274 534 456 Bytes +992 Bytes +0.000%
ydbd stripped size 479 371 808 Bytes 479 371 808 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 27, 2025

2025-03-27 10:01:15 UTC Pre-commit check linux-x86_64-release-asan for 8ff5f8e has started.
2025-03-27 10:01:19 UTC Artifacts will be uploaded here
2025-03-27 10:04:15 UTC ya make is running...
🟡 2025-03-27 11:18:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11843 11603 0 193 10 37

2025-03-27 11:19:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-27 11:41:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
298 (only retried tests) 261 0 2 0 35

2025-03-27 11:42:07 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-27 12:02:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67 (only retried tests) 32 0 1 1 33

🟢 2025-03-27 12:02:19 UTC Build successful.
🟢 2025-03-27 12:02:50 UTC ydbd size 3.7 GiB changed* by +3.5 KiB, which is < 100.0 KiB vs stable-25-1-analytics: OK

ydbd size dash stable-25-1-analytics: 5b40aa0 merge: 8ff5f8e diff diff %
ydbd size 3 958 695 024 Bytes 3 958 698 600 Bytes +3.5 KiB +0.000%
ydbd stripped size 1 384 773 672 Bytes 1 384 774 184 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Emgariko Emgariko enabled auto-merge (squash) March 27, 2025 10:27
@Emgariko Emgariko disabled auto-merge March 27, 2025 10:27
@Emgariko Emgariko enabled auto-merge (squash) March 27, 2025 10:27
@Emgariko Emgariko merged commit d18ee02 into ydb-platform:stable-25-1-analytics Mar 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spaces are supported in column names for COLUMN tables
2 participants