Skip to content

max timeout for FastRead (#15520) #16164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

max timeout for FastRead (#15520) #16164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ydb/core/tx/columnshard/blob_cache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ class TBlobCache: public TActorBootstrapped<TBlobCache> {
static constexpr i64 MAX_IN_FLIGHT_BYTES = 250ll << 20;
static constexpr i64 MAX_REQUEST_BYTES = 8ll << 20;
static constexpr TDuration DEFAULT_READ_DEADLINE = TDuration::Seconds(30);
static constexpr TDuration FAST_READ_DEADLINE = TDuration::Seconds(10);

TLRUCache<TBlobRange, TString> Cache;
/// List of cached ranges by blob id.
Expand Down Expand Up @@ -358,12 +357,11 @@ class TBlobCache: public TActorBootstrapped<TBlobCache> {
}

static TInstant ReadDeadline(TReadItem::EReadVariant variant) {
if (variant == TReadItem::EReadVariant::FAST) {
return TAppData::TimeProvider->Now() + FAST_READ_DEADLINE;
} else if (variant == TReadItem::EReadVariant::DEFAULT) {
if (variant == TReadItem::EReadVariant::DEFAULT) {
return TAppData::TimeProvider->Now() + DEFAULT_READ_DEADLINE;
}
return TInstant::Max(); // EReadVariant::DEFAULT_NO_DEADLINE
// We want to wait for data anyway in this case. This behaviour is similar to datashard
return TInstant::Max(); // EReadVariant::DEFAULT_NO_DEADLINE || EReadVariant::FAST
}

void MakeReadRequests(const TActorContext& ctx) {
Expand Down
Loading