Skip to content

BTreeIndex Charge History #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ydb/core/tablet_flat/flat_page_iface.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#pragma once

#include <util/system/types.h>
#include <util/stream/output.h>

namespace NKikimr {
namespace NTable {
Expand Down Expand Up @@ -51,6 +52,10 @@ namespace NPage {
explicit operator size_t() const noexcept {
return Historic * 31 + Index;
}

friend inline IOutputStream& operator<<(IOutputStream& out, const TGroupId& groupId) {
return out << "{" << groupId.Index << "," << groupId.IsHistoric() << "}";
}
};

enum class EPage : ui16 {
Expand All @@ -59,7 +64,7 @@ namespace NPage {
Index = 3,
DataPage = 4,
Frames = 5, /* Tagged entities to TRowId relation index */
Globs = 6, /* Just enumartion of NPageCollection::TGlobId refs */
Globs = 6, /* Just enumeration of NPageCollection::TGlobId refs */
Schem2 = 7, /* New version of EPage::Scheme with TLabel */
Opaque = 8, /* User defined content, cell value as blob */
Bloom = 9, /* Bloom filter for some app. defined cells set */
Expand Down
4 changes: 2 additions & 2 deletions ydb/core/tablet_flat/flat_part_charge.h
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ namespace NTable {
const auto& scheme = Part->Scheme->HistoryGroup;
Y_DEBUG_ABORT_UNLESS(scheme.ColsKeyIdx.size() == 3);

// Directly use the histroy key defaults with correct sort order
// Directly use the history key defaults with correct sort order
const TKeyCellDefaults* keyDefaults = Part->Scheme->HistoryKeys.Get();

auto first = index->LookupKey(startKey, scheme, ESeek::Lower, keyDefaults);
Expand All @@ -441,7 +441,7 @@ namespace NTable {
ready &= bool(page);

if (!HistoryGroups) {
// don't need to caclulate prechargedFirstRowId/prechargedLastRowId
// don't need to calculate prechargedFirstRowId/prechargedLastRowId
continue;
}

Expand Down
Loading