Skip to content

YQL-17542 split stat #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2024
Merged

YQL-17542 split stat #1553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ydb/library/yql/dq/actors/compute/dq_async_compute_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,6 +789,11 @@ class TDqAsyncComputeActor : public TDqComputeActorBase<TDqAsyncComputeActor, TC
return TaskRunnerStats.Get();
}

const NYql::NDq::TDqMeteringStats* GetMeteringStats() override {
// TODO: support async CA
return nullptr;
}

template<typename TSecond>
TVector<ui32> GetIds(const THashMap<ui64, TSecond>& collection) {
TVector<ui32> ids;
Expand Down
11 changes: 4 additions & 7 deletions ydb/library/yql/dq/actors/compute/dq_compute_actor_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1776,9 +1776,8 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>
}
}

virtual const NYql::NDq::TTaskRunnerStatsBase* GetTaskRunnerStats() {
return TaskRunner ? TaskRunner->GetStats() : nullptr;
}
virtual const NYql::NDq::TTaskRunnerStatsBase* GetTaskRunnerStats() = 0;
virtual const NYql::NDq::TDqMeteringStats* GetMeteringStats() = 0;

virtual const IDqAsyncOutputBuffer* GetSink(ui64, const TAsyncOutputInfoBase& sinkInfo) const {
return sinkInfo.Buffer.Get();
Expand Down Expand Up @@ -1838,8 +1837,7 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>

for (auto& [inputIndex, sourceInfo] : SourcesMap) {
if (auto* source = sourceInfo.AsyncInput) {
// TODO: support async CA
source->FillExtraStats(protoTask, last, TaskRunner ? TaskRunner->GetMeteringStats() : nullptr);
source->FillExtraStats(protoTask, last, GetMeteringStats());
}
}
FillTaskRunnerStats(Task.GetId(), Task.GetStageId(), *taskStats, protoTask, RuntimeSettings.GetCollectStatsLevel());
Expand Down Expand Up @@ -1944,8 +1942,7 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>
}

if (auto* transform = transformInfo.AsyncInput) {
// TODO: support async CA
transform->FillExtraStats(protoTask, last, TaskRunner ? TaskRunner->GetMeteringStats() : 0);
transform->FillExtraStats(protoTask, last, GetMeteringStats());
}
}

Expand Down
8 changes: 8 additions & 0 deletions ydb/library/yql/dq/actors/compute/dq_sync_compute_actor_base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,14 @@ class TDqSyncComputeActorBase: public TDqComputeActorBase<TDerived, TComputeActo
this->TaskRunner->GetTaskParams(),
this->TaskRunner->GetReadRanges());
}

const NYql::NDq::TTaskRunnerStatsBase* GetTaskRunnerStats() override {
return this->TaskRunner ? this->TaskRunner->GetStats() : nullptr;
}

const NYql::NDq::TDqMeteringStats* GetMeteringStats() override {
return this->TaskRunner ? this->TaskRunner->GetMeteringStats() : nullptr;
}
};

} //namespace NYql::NDq
Expand Down