Skip to content

check that we are not migrating tablets to ourselves #15477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2025
Merged

check that we are not migrating tablets to ourselves #15477

merged 2 commits into from
Mar 12, 2025

Conversation

@vporyadke
Copy link
Collaborator

@vporyadke vporyadke commented Mar 7, 2025

Changelog entry

add validation to never have tablet migration from root hive to itself

Changelog category

  • Improvement

Description for reviewers

...

@github-actions
Copy link

github-actions bot commented Mar 7, 2025

🟢 2025-03-07 16:33:51 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Mar 7, 2025 •
edited
Loading

⚪ 2025-03-07 16:35:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1a2192c has started.
⚪ 2025-03-07 16:35:42 UTC Artifacts will be uploaded here
⚪ 2025-03-07 16:38:24 UTC ya make is running...
🟡 2025-03-07 17:26:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19237 17904 0 3 1217 113

⚪ 2025-03-07 17:28:28 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-07 17:39:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
161 (only retried tests) 55 0 1 0 105

⚪ 2025-03-07 17:39:48 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-07 17:51:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
148 (only retried tests) 45 0 0 0 103

🟢 2025-03-07 17:52:00 UTC Build successful.
🟢 2025-03-07 17:52:19 UTC ydbd size 2.1 GiB changed* by +2.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 67fc041 merge: 1a2192c diff diff %
ydbd size 2 294 634 584 Bytes 2 294 637 208 Bytes +2.6 KiB +0.000%
ydbd stripped size 480 595 008 Bytes 480 595 584 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 7, 2025 •
edited
Loading

⚪ 2025-03-07 16:36:31 UTC Pre-commit check linux-x86_64-release-asan for 1a2192c has started.
⚪ 2025-03-07 16:36:46 UTC Artifacts will be uploaded here
⚪ 2025-03-07 16:39:27 UTC ya make is running...
🟡 2025-03-07 17:45:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11772 11522 0 196 21 33

⚪ 2025-03-07 17:47:06 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-07 18:01:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
307 (only retried tests) 265 0 2 8 32

⚪ 2025-03-07 18:01:32 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-07 18:12:45 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69 (only retried tests) 34 0 0 7 28

🟢 2025-03-07 18:12:52 UTC Build successful.
🟢 2025-03-07 18:13:18 UTC ydbd size 3.7 GiB changed* by +6.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 67fc041 merge: 1a2192c diff diff %
ydbd size 3 996 113 088 Bytes 3 996 119 376 Bytes +6.1 KiB +0.000%
ydbd stripped size 1 389 155 016 Bytes 1 389 156 616 Bytes +1.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vporyadke vporyadke requested review from CyberROFL and adameat March 10, 2025 15:02
CyberROFL
CyberROFL reviewed Mar 10, 2025
View reviewed changes
ydb/core/mind/hive/hive_impl.cpp Outdated

void THive::Handle(TEvHive::TEvInitMigration::TPtr& ev) {
BLOG_D("Handle InitMigration " << ev->Get()->Record);
Y_DEBUG_ABORT_UNLESS(!AreWeRootHive());
Copy link
Member

@CyberROFL CyberROFL Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может лучше тест написать, что такая миграция стала невозможна?

@github-actions
Copy link

github-actions bot commented Mar 11, 2025 •
edited
Loading

⚪ 2025-03-11 23:00:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for 594a0bc has started.
⚪ 2025-03-11 23:00:39 UTC Artifacts will be uploaded here
⚪ 2025-03-11 23:03:25 UTC ya make is running...
🟡 2025-03-11 23:51:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19305 17964 0 1 1224 116

⚪ 2025-03-11 23:53:04 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-12 00:03:48 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
166 (only retried tests) 63 0 0 0 103

🟢 2025-03-12 00:03:55 UTC Build successful.
🟢 2025-03-12 00:04:15 UTC ydbd size 2.1 GiB changed* by +2.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 76f8353 merge: 594a0bc diff diff %
ydbd size 2 296 164 912 Bytes 2 296 167 840 Bytes +2.9 KiB +0.000%
ydbd stripped size 480 718 112 Bytes 480 718 688 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 11, 2025 •
edited
Loading

⚪ 2025-03-11 23:01:44 UTC Pre-commit check linux-x86_64-release-asan for 594a0bc has started.
⚪ 2025-03-11 23:01:59 UTC Artifacts will be uploaded here
⚪ 2025-03-11 23:04:43 UTC ya make is running...
🟡 2025-03-12 00:08:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11829 11636 0 143 18 32

⚪ 2025-03-12 00:09:58 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-12 00:23:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
281 (only retried tests) 169 0 78 2 32

⚪ 2025-03-12 00:24:05 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-12 00:36:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
188 (only retried tests) 106 0 50 1 31

🟢 2025-03-12 00:36:38 UTC Build successful.
🟢 2025-03-12 00:37:06 UTC ydbd size 3.7 GiB changed* by +7.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 76f8353 merge: 594a0bc diff diff %
ydbd size 3 999 115 040 Bytes 3 999 122 336 Bytes +7.1 KiB +0.000%
ydbd stripped size 1 389 687 560 Bytes 1 389 689 544 Bytes +1.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vporyadke vporyadke merged commit add786e into ydb-platform:main Mar 12, 2025
12 checks passed
@vporyadke vporyadke self-assigned this Mar 12, 2025
vporyadke added a commit to vporyadke/ydb that referenced this pull request Mar 12, 2025
@vporyadke
check that we are not migrating tablets to ourselves (ydb-platform#15477
4281364 
)
vporyadke added a commit to vporyadke/ydb that referenced this pull request Mar 12, 2025
@vporyadke
check that we are not migrating tablets to ourselves (ydb-platform#15477
e9a4441 
)
@serbel324 serbel324 mentioned this pull request Mar 13, 2025
Merged
vporyadke added a commit that referenced this pull request Mar 14, 2025
@vporyadke
24-4: check that we are not migrating tablets to ourselves (#15477) (#…
41e5d4e 
…15666)
vporyadke added a commit that referenced this pull request Mar 14, 2025
@vporyadke
25-1: check that we are not migrating tablets to ourselves (#15477) (#…
8b06bf3 
…15667)
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
@vporyadke @adameat
check that we are not migrating tablets to ourselves (ydb-platform#15477
1f2c5ca 
)
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@vporyadke @blinkov
check that we are not migrating tablets to ourselves (#15477)
4c09254
Emgariko pushed a commit to Emgariko/ydb that referenced this pull request Mar 24, 2025
@vporyadke @Emgariko
check that we are not migrating tablets to ourselves (ydb-platform#15477
c6922fa 
)
@alexv-smirnov alexv-smirnov mentioned this pull request Mar 25, 2025
Merged
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
@vporyadke
check that we are not migrating tablets to ourselves (ydb-platform#15477
6a761e7 
)
This was referenced Jun 3, 2025
Closed
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyberROFL CyberROFL CyberROFL approved these changes

@adameat adameat Awaiting requested review from adameat

Assignees

@vporyadke vporyadke

Labels

changelog/f25-3 PR участвует в списке изменений improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vporyadke @CyberROFL @liruoko