Skip to content

Fix proxy crash on duplicate topics in request #15467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

FloatingCrowbar
Copy link
Collaborator

Changelog entry

Fix metadataRequest containg same topic multiple times crashing KafkaProxy

Changelog category

  • Bugfix

Description for reviewers

...

@FloatingCrowbar FloatingCrowbar requested a review from a team as a code owner March 7, 2025 14:03
@github-actions github-actions bot added the bugfix label Mar 7, 2025
Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 14:04:34 UTC Pre-commit check linux-x86_64-release-asan for f9c51a5 has started.
2025-03-07 14:04:47 UTC Artifacts will be uploaded here
2025-03-07 14:06:00 UTC Check cancelled

Copy link

github-actions bot commented Mar 7, 2025

🔴 2025-03-07 14:04:34 UTC The validation of the Pull Request description has failed. Please update the description.

Bugfix requires a linked issue in the changelog entry

@FloatingCrowbar FloatingCrowbar force-pushed the kafka-proxy-dont-crash-pls branch from 9c53f08 to e2fdffa Compare March 7, 2025 14:05
Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 14:07:20 UTC Pre-commit check linux-x86_64-release-asan for ea225da has started.
2025-03-07 14:07:35 UTC Artifacts will be uploaded here
2025-03-07 14:10:24 UTC ya make is running...
🟡 2025-03-07 15:16:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11475 11259 0 157 21 38

2025-03-07 15:17:20 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-07 15:30:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
277 (only retried tests) 233 0 12 1 31

2025-03-07 15:30:50 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-07 15:43:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79 (only retried tests) 51 0 0 0 28

🟢 2025-03-07 15:43:21 UTC Build successful.
🟢 2025-03-07 15:43:55 UTC ydbd size 3.7 GiB changed* by +3.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e4821cc merge: ea225da diff diff %
ydbd size 3 996 097 640 Bytes 3 996 101 680 Bytes +3.9 KiB +0.000%
ydbd stripped size 1 389 147 400 Bytes 1 389 148 552 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 14:09:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for ea225da has started.
2025-03-07 14:10:10 UTC Artifacts will be uploaded here
2025-03-07 14:13:32 UTC ya make is running...
🟡 2025-03-07 15:01:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18730 17395 0 1 1217 117

2025-03-07 15:03:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-07 15:14:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
162 (only retried tests) 57 0 0 0 105

🟢 2025-03-07 15:14:59 UTC Build successful.
🟢 2025-03-07 15:15:18 UTC ydbd size 2.1 GiB changed* by +2.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e4821cc merge: ea225da diff diff %
ydbd size 2 294 621 968 Bytes 2 294 624 224 Bytes +2.2 KiB +0.000%
ydbd stripped size 480 593 312 Bytes 480 593 760 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@FloatingCrowbar FloatingCrowbar merged commit 7c72123 into ydb-platform:main Mar 7, 2025
12 checks passed
FloatingCrowbar added a commit to FloatingCrowbar/ydb that referenced this pull request Mar 7, 2025
FloatingCrowbar added a commit to FloatingCrowbar/ydb that referenced this pull request Mar 7, 2025
FloatingCrowbar added a commit to FloatingCrowbar/ydb that referenced this pull request Mar 7, 2025
FloatingCrowbar added a commit to FloatingCrowbar/ydb that referenced this pull request Mar 10, 2025
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants