Skip to content

allow parsing out-of-range doubles in bulk-upsert #15376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 7, 2025
Merged

allow parsing out-of-range doubles in bulk-upsert #15376

merged 3 commits into from
Mar 7, 2025

Conversation

swalrus1
Copy link
Collaborator

@swalrus1 swalrus1 commented Mar 5, 2025

Changelog entry

Add an option to case out-of-range doubles coming from bulk-upsert to double::inf.

Changelog category

  • New feature

Description for reviewers

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

🟢 2025-03-05 16:18:16 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

⚪ 2025-03-05 16:18:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 29a98ec has started.
⚪ 2025-03-05 16:18:50 UTC Artifacts will be uploaded here
⚪ 2025-03-05 16:22:33 UTC ya make is running...
🟡 2025-03-05 17:53:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28136 25552 0 3 2465 116

⚪ 2025-03-05 17:56:00 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-05 18:07:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
169 (only retried tests) 64 0 1 0 104

⚪ 2025-03-05 18:07:35 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-05 18:19:11 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
147 (only retried tests) 42 0 1 0 104

🟢 2025-03-05 18:19:20 UTC Build successful.
🟢 2025-03-05 18:19:42 UTC ydbd size 2.1 GiB changed* by +9.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: afb7274 merge: 29a98ec diff diff %
ydbd size 2 294 063 048 Bytes 2 294 073 088 Bytes +9.8 KiB +0.000%
ydbd stripped size 480 394 752 Bytes 480 395 840 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

⚪ 2025-03-05 16:18:30 UTC Pre-commit check linux-x86_64-release-asan for 29a98ec has started.
⚪ 2025-03-05 16:18:34 UTC Artifacts will be uploaded here
⚪ 2025-03-05 16:21:33 UTC ya make is running...
🟡 2025-03-05 17:58:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13728 13343 0 274 74 37

⚪ 2025-03-05 17:59:56 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-05 18:17:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
544 (only retried tests) 272 0 187 51 34

⚪ 2025-03-05 18:18:12 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-05 18:35:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
409 (only retried tests) 148 0 178 50 33

🟢 2025-03-05 18:35:18 UTC Build successful.
🟢 2025-03-05 18:35:52 UTC ydbd size 3.7 GiB changed* by +6.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: afb7274 merge: 29a98ec diff diff %
ydbd size 3 997 172 152 Bytes 3 997 179 192 Bytes +6.9 KiB +0.000%
ydbd stripped size 1 390 281 000 Bytes 1 390 283 176 Bytes +2.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 09:46:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2f1329a has started.
⚪ 2025-03-06 09:46:40 UTC Artifacts will be uploaded here
⚪ 2025-03-06 09:49:42 UTC ya make is running...
🟡 2025-03-06 11:15:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28429 25831 0 3 2476 119

🟢 2025-03-06 11:16:41 UTC ydbd size 2.1 GiB changed* by +54.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4b641a3 merge: 2f1329a diff diff %
ydbd size 2 293 101 120 Bytes 2 293 156 432 Bytes +54.0 KiB +0.002%
ydbd stripped size 480 445 056 Bytes 480 459 584 Bytes +14.2 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-03-06 11:16:42 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 09:46:59 UTC Pre-commit check linux-x86_64-release-asan for 2f1329a has started.
⚪ 2025-03-06 09:47:14 UTC Artifacts will be uploaded here
⚪ 2025-03-06 09:50:28 UTC ya make is running...
⚫ 2025-03-06 11:16:33 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 11:19:02 UTC Pre-commit check linux-x86_64-release-asan for 0178700 has started.
⚪ 2025-03-06 11:19:18 UTC Artifacts will be uploaded here
⚪ 2025-03-06 11:22:19 UTC ya make is running...
🟡 2025-03-06 12:58:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14028 13906 0 66 22 34

⚪ 2025-03-06 12:59:37 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-06 13:12:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
179 (only retried tests) 146 0 1 1 31

⚪ 2025-03-06 13:12:45 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-06 13:25:53 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 31 0 0 0 29

🟢 2025-03-06 13:26:03 UTC Build successful.
🟢 2025-03-06 13:26:37 UTC ydbd size 3.7 GiB changed* by +11.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: cda52e1 merge: 0178700 diff diff %
ydbd size 3 995 175 008 Bytes 3 995 186 224 Bytes +11.0 KiB +0.000%
ydbd stripped size 1 389 081 256 Bytes 1 389 087 592 Bytes +6.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 11:19:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0178700 has started.
⚪ 2025-03-06 11:20:22 UTC Artifacts will be uploaded here
⚪ 2025-03-06 11:24:12 UTC ya make is running...
🟢 2025-03-06 12:53:15 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28440 25844 0 0 2476 120

🟢 2025-03-06 12:55:49 UTC Build successful.
🟢 2025-03-06 12:56:07 UTC ydbd size 2.1 GiB changed* by +9.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: cda52e1 merge: 0178700 diff diff %
ydbd size 2 293 954 392 Bytes 2 293 964 512 Bytes +9.9 KiB +0.000%
ydbd stripped size 480 563 328 Bytes 480 564 512 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@swalrus1 swalrus1 force-pushed the parse-out-of-range-double branch from bb03cd5 to 7356e61 Compare March 7, 2025 08:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025 •
edited
Loading

⚪ 2025-03-07 08:33:12 UTC Pre-commit check linux-x86_64-release-asan for 518b32a has started.
⚪ 2025-03-07 08:33:27 UTC Artifacts will be uploaded here
⚪ 2025-03-07 08:36:29 UTC ya make is running...
🟡 2025-03-07 10:18:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13766 13588 0 108 29 41

⚪ 2025-03-07 10:20:50 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-07 10:35:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
240 (only retried tests) 200 0 3 2 35

⚪ 2025-03-07 10:35:47 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-07 10:47:50 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73 (only retried tests) 39 0 0 1 33

🟢 2025-03-07 10:47:56 UTC Build successful.
🟢 2025-03-07 10:48:29 UTC ydbd size 3.7 GiB changed* by +6.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b654981 merge: 518b32a diff diff %
ydbd size 3 994 259 048 Bytes 3 994 266 032 Bytes +6.8 KiB +0.000%
ydbd stripped size 1 388 747 112 Bytes 1 388 749 224 Bytes +2.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025 •
edited
Loading

⚪ 2025-03-07 08:33:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for 518b32a has started.
⚪ 2025-03-07 08:33:29 UTC Artifacts will be uploaded here
⚪ 2025-03-07 08:36:42 UTC ya make is running...
🟡 2025-03-07 10:06:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28172 25586 0 1 2465 120

⚪ 2025-03-07 10:09:06 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-07 10:22:20 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
174 (only retried tests) 65 0 0 0 109

🟢 2025-03-07 10:22:31 UTC Build successful.
🟢 2025-03-07 10:22:53 UTC ydbd size 2.1 GiB changed* by +9.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b654981 merge: 518b32a diff diff %
ydbd size 2 293 420 848 Bytes 2 293 430 952 Bytes +9.9 KiB +0.000%
ydbd stripped size 480 451 296 Bytes 480 452 448 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025 •
edited
Loading

⚪ 2025-03-07 12:36:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8b5aee3 has started.
⚪ 2025-03-07 12:37:10 UTC Artifacts will be uploaded here
⚪ 2025-03-07 12:40:22 UTC ya make is running...
🟡 2025-03-07 14:12:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28180 25598 0 1 2465 116

⚪ 2025-03-07 14:15:07 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-07 14:35:24 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
158 (only retried tests) 53 0 0 0 105

🟢 2025-03-07 14:35:34 UTC Build successful.
🟢 2025-03-07 14:35:53 UTC ydbd size 2.1 GiB changed* by +13.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8068540 merge: 8b5aee3 diff diff %
ydbd size 2 294 618 720 Bytes 2 294 632 104 Bytes +13.1 KiB +0.001%
ydbd stripped size 480 593 184 Bytes 480 594 496 Bytes +1.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025 •
edited
Loading

⚪ 2025-03-07 12:36:57 UTC Pre-commit check linux-x86_64-release-asan for 8b5aee3 has started.
⚪ 2025-03-07 12:37:56 UTC Artifacts will be uploaded here
⚪ 2025-03-07 12:41:14 UTC ya make is running...
🟡 2025-03-07 14:35:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13772 13599 0 108 27 38

⚪ 2025-03-07 14:36:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-07 14:52:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
246 (only retried tests) 207 0 3 3 33

⚪ 2025-03-07 14:52:42 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-07 15:11:02 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
66 (only retried tests) 34 0 0 1 31

🟢 2025-03-07 15:11:12 UTC Build successful.
🟢 2025-03-07 15:11:46 UTC ydbd size 3.7 GiB changed* by +15.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8068540 merge: 8b5aee3 diff diff %
ydbd size 3 996 092 752 Bytes 3 996 108 792 Bytes +15.7 KiB +0.000%
ydbd stripped size 1 389 146 920 Bytes 1 389 153 672 Bytes +6.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@swalrus1 swalrus1 marked this pull request as ready for review March 7, 2025 12:46
@swalrus1 swalrus1 requested review from a team as code owners March 7, 2025 12:46
@swalrus1 swalrus1 enabled auto-merge (squash) March 7, 2025 15:57
nikvas0
nikvas0 approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@nikvas0 nikvas0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kqp ok

@swalrus1 swalrus1 merged commit 67fc041 into ydb-platform:main Mar 7, 2025
12 checks passed
@swalrus1 swalrus1 deleted the parse-out-of-range-double branch March 7, 2025 17:02
@swalrus1 swalrus1 linked an issue Mar 7, 2025 that may be closed by this pull request
JSON parsing error on olap-perf #14633
Closed
@serbel324 serbel324 mentioned this pull request Mar 10, 2025
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 11, 2025
Merged
@serbel324 serbel324 mentioned this pull request Mar 13, 2025
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
@swalrus1 @adameat
allow parsing out-of-range doubles in bulk-upsert (ydb-platform#15376)
f5c6cdc
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@swalrus1 @blinkov
allow parsing out-of-range doubles in bulk-upsert (#15376)
799a9aa
dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Mar 24, 2025
@swalrus1 @dorooleg
allow parsing out-of-range doubles in bulk-upsert (ydb-platform#15376)
8d1dbad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikvas0 nikvas0 nikvas0 approved these changes

@ivanmorozov333 ivanmorozov333 ivanmorozov333 approved these changes

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON parsing error on olap-perf
3 participants
@swalrus1 @nikvas0 @ivanmorozov333