Skip to content

Support pausing TestShard writes through ICB #15299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Mar 4, 2025

Changelog entry

Support pausing TestShard writes through ICB

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

All writes on a node generated by TestShard can now be paused through ICB.

Copy link

github-actions bot commented Mar 4, 2025

🟢 2025-03-04 12:33:13 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 4, 2025

2025-03-04 12:33:22 UTC Pre-commit check linux-x86_64-release-asan for 0c71a65 has started.
2025-03-04 12:33:54 UTC Artifacts will be uploaded here
2025-03-04 12:37:35 UTC ya make is running...
🟡 2025-03-04 14:22:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13705 13526 0 116 24 39

2025-03-04 14:23:27 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-04 14:39:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
236 (only retried tests) 194 0 6 1 35

2025-03-04 14:39:53 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-04 14:52:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72 (only retried tests) 41 0 0 1 30

🟢 2025-03-04 14:53:00 UTC Build successful.
🟢 2025-03-04 14:53:32 UTC ydbd size 3.7 GiB changed* by +40.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 57dc7ac merge: 0c71a65 diff diff %
ydbd size 3 989 750 528 Bytes 3 989 791 912 Bytes +40.4 KiB +0.001%
ydbd stripped size 1 388 808 424 Bytes 1 388 826 408 Bytes +17.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 4, 2025

2025-03-04 12:34:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0c71a65 has started.
2025-03-04 12:34:55 UTC Artifacts will be uploaded here
2025-03-04 12:38:08 UTC ya make is running...
🟡 2025-03-04 14:10:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28123 25505 0 5 2475 138

2025-03-04 14:13:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-04 14:26:54 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
222 (only retried tests) 96 0 0 0 126

🟢 2025-03-04 14:27:04 UTC Build successful.
🟢 2025-03-04 14:27:24 UTC ydbd size 2.1 GiB changed* by +27.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 57dc7ac merge: 0c71a65 diff diff %
ydbd size 2 289 174 928 Bytes 2 289 202 648 Bytes +27.1 KiB +0.001%
ydbd stripped size 479 753 792 Bytes 479 763 552 Bytes +9.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge (squash) March 5, 2025 04:44
@alexvru alexvru merged commit b0f9318 into ydb-platform:main Mar 5, 2025
14 checks passed
@alexvru alexvru deleted the testshard/turnoff-icb branch March 5, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants