Skip to content

Conversation

@adameat
Copy link
Member

@adameat adameat commented Mar 4, 2025

Changelog entry

don't return childrenExist prop for databases, closes #15256

Changelog category

  • Bugfix

Description for reviewers

this will trigger default behavior where we draw a toggle to expand the element and remove it if it doesn't have any children

@adameat adameat requested a review from a team as a code owner March 4, 2025 11:39
@github-actions github-actions bot added the bugfix label Mar 4, 2025
@github-actions
Copy link

github-actions bot commented Mar 4, 2025

🟢 2025-03-04 11:40:53 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Mar 4, 2025

2025-03-04 11:41:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for da60412 has started.
2025-03-04 11:41:25 UTC Artifacts will be uploaded here
2025-03-04 11:44:08 UTC ya make is running...
🟡 2025-03-04 12:37:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19169 17809 0 5 1216 139

2025-03-04 12:39:48 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-04 12:52:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
218 (only retried tests) 92 0 1 0 125

2025-03-04 12:52:45 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-04 13:04:48 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
188 (only retried tests) 64 0 1 0 123

🟢 2025-03-04 13:04:55 UTC Build successful.
🟢 2025-03-04 13:05:18 UTC ydbd size 2.1 GiB changed* by -88 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9eea4e3 merge: da60412 diff diff %
ydbd size 2 289 175 032 Bytes 2 289 174 944 Bytes -88 Bytes -0.000%
ydbd stripped size 479 753 792 Bytes 479 753 792 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 4, 2025

2025-03-04 11:42:02 UTC Pre-commit check linux-x86_64-release-asan for da60412 has started.
2025-03-04 11:42:16 UTC Artifacts will be uploaded here
2025-03-04 11:45:02 UTC ya make is running...
🟡 2025-03-04 12:53:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11689 11505 0 123 19 42

2025-03-04 12:55:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-04 13:09:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
239 (only retried tests) 192 0 9 5 33

2025-03-04 13:09:36 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-04 13:22:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
78 (only retried tests) 43 0 1 3 31

🟢 2025-03-04 13:22:21 UTC Build successful.
🟡 2025-03-04 13:22:55 UTC ydbd size 3.7 GiB changed* by +194.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 18f45b9 merge: da60412 diff diff %
ydbd size 3 989 555 664 Bytes 3 989 754 608 Bytes +194.3 KiB +0.005%
ydbd stripped size 1 388 759 272 Bytes 1 388 812 520 Bytes +52.0 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

CyberROFL
CyberROFL previously approved these changes Mar 4, 2025
@adameat adameat enabled auto-merge (squash) March 4, 2025 11:53
@adameat adameat requested a review from a team as a code owner March 5, 2025 05:26
@github-actions
Copy link

github-actions bot commented Mar 5, 2025

2025-03-05 05:27:41 UTC Pre-commit check linux-x86_64-release-asan for 784ed8c has started.
2025-03-05 05:27:56 UTC Artifacts will be uploaded here
2025-03-05 05:30:47 UTC ya make is running...
🟡 2025-03-05 06:54:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11686 11518 0 103 26 39

2025-03-05 06:55:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-05 07:16:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
244 (only retried tests) 197 0 7 7 33

2025-03-05 07:16:10 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-05 07:28:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79 (only retried tests) 48 0 0 0 31

🟢 2025-03-05 07:28:48 UTC Build successful.
🟢 2025-03-05 07:29:21 UTC ydbd size 3.7 GiB changed* by -16 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: b0f9318 merge: 784ed8c diff diff %
ydbd size 3 990 870 208 Bytes 3 990 870 192 Bytes -16 Bytes -0.000%
ydbd stripped size 1 388 995 016 Bytes 1 388 995 016 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 5, 2025

2025-03-05 05:27:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 784ed8c has started.
2025-03-05 05:27:56 UTC Artifacts will be uploaded here
2025-03-05 05:30:42 UTC ya make is running...
🟡 2025-03-05 06:34:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19150 17794 0 2 1228 126

2025-03-05 06:36:17 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-05 06:48:39 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
183 (only retried tests) 73 0 0 0 110

🟢 2025-03-05 06:48:48 UTC Build successful.
🟢 2025-03-05 06:49:11 UTC ydbd size 2.1 GiB changed* by +23.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: fb4d6bb merge: 784ed8c diff diff %
ydbd size 2 290 063 784 Bytes 2 290 087 472 Bytes +23.1 KiB +0.001%
ydbd stripped size 479 946 656 Bytes 479 952 384 Bytes +5.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat merged commit 4d0fb2e into ydb-platform:main Mar 5, 2025
12 checks passed
@adameat adameat deleted the fix-children-exist branch March 6, 2025 08:59
adameat added a commit to adameat/ydb that referenced this pull request Apr 29, 2025
adameat added a commit to adameat/ydb that referenced this pull request May 13, 2025
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix changelog/f25-3 PR участвует в списке изменений

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nested databases are childless when navigating from domain

4 participants