Skip to content

Change MAX_REORDER_TX_KEYS from 100 to 1000 (24-4) #15294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

qyryq
Copy link
Collaborator

@qyryq qyryq commented Mar 4, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Improve out of order tx batching

#15293

@qyryq qyryq requested a review from a team as a code owner March 4, 2025 11:03
@qyryq qyryq changed the title Change MAX_REORDER_TX_KEYS from 100 to 1000 Change MAX_REORDER_TX_KEYS from 100 to 1000 (24-4) Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

2025-03-04 11:12:29 UTC Pre-commit check for 357ffab has started.
2025-03-04 11:15:08 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-03-04 11:58:17 UTC Build successful.
2025-03-04 11:58:32 UTC Tests are running...
🔴 2025-03-04 13:26:26 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14794 13429 0 23 1302 40

🟢 2025-03-04 13:27:24 UTC ydbd size 8.3 GiB changed* by +32 Bytes, which is < 100.0 KiB vs stable-24-4: OK

ydbd size dash stable-24-4: 0a25dc5 merge: 357ffab diff diff %
ydbd size 8 897 583 920 Bytes 8 897 583 952 Bytes +32 Bytes +0.000%
ydbd stripped size 484 988 776 Bytes 484 988 840 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 4, 2025

2025-03-04 11:12:52 UTC Pre-commit check for 357ffab has started.
2025-03-04 11:15:45 UTC Build linux-x86_64-release-asan is running...
🟢 2025-03-04 11:41:50 UTC Build successful.
2025-03-04 11:42:17 UTC Tests are running...
🔴 2025-03-04 13:58:20 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10359 10251 0 39 26 43

🟢 2025-03-04 13:59:21 UTC ydbd size 5.6 GiB changed* by -32 Bytes, which is <= 0 Bytes vs stable-24-4: OK

ydbd size dash stable-24-4: 0a25dc5 merge: 357ffab diff diff %
ydbd size 6 026 997 144 Bytes 6 026 997 112 Bytes -32 Bytes -0.000%
ydbd stripped size 1 508 304 544 Bytes 1 508 304 544 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@qyryq qyryq enabled auto-merge (squash) March 4, 2025 12:53
@qyryq qyryq merged commit 4b470a1 into ydb-platform:stable-24-4 Mar 4, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants