Skip to content

KIKIMR-20931: Fix set_config #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 2, 2024
Merged

KIKIMR-20931: Fix set_config #1521

merged 3 commits into from
Feb 2, 2024

Conversation

MrLolthe1st
Copy link
Collaborator

No description provided.

@MrLolthe1st MrLolthe1st requested a review from a team as a code owner February 1, 2024 14:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024 •
edited
Loading

⚪ 2024-02-01 14:12:26 UTC Pre-commit check for f6110a5 has started.
⚪ 2024-02-01 14:12:28 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-01 14:14:52 UTC Build successful.
⚪ 2024-02-01 14:15:09 UTC Tests are running...
🔴 2024-02-01 14:36:15 UTC Test run completed, no test results found for commit bc179d8. Please check build logs.
⚫ 2024-02-01 14:36:18 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024 •
edited
Loading

⚪ 2024-02-01 14:13:25 UTC Pre-commit check for f6110a5 has started.
⚪ 2024-02-01 14:13:28 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-01 14:15:47 UTC Build successful.
⚪ 2024-02-01 14:15:59 UTC Tests are running...
🔴 2024-02-01 14:36:15 UTC Test run completed, no test results found for commit bc179d8. Please check build logs.
⚫ 2024-02-01 14:36:17 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024 •
edited
Loading

⚪ 2024-02-01 14:36:57 UTC Pre-commit check for 46e5c30 has started.
⚪ 2024-02-01 14:36:58 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-01 14:39:07 UTC Build successful.
⚪ 2024-02-01 14:39:16 UTC Tests are running...
🔴 2024-02-01 15:05:40 UTC Test run completed, no test results found for commit f999a9f. Please check build logs.
⚫ 2024-02-01 15:05:42 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024 •
edited
Loading

⚪ 2024-02-01 14:37:57 UTC Pre-commit check for 46e5c30 has started.
⚪ 2024-02-01 14:38:02 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-01 14:40:35 UTC Build successful.
⚪ 2024-02-01 14:40:49 UTC Tests are running...
🔴 2024-02-01 15:05:50 UTC Test run completed, no test results found for commit f999a9f. Please check build logs.
⚫ 2024-02-01 15:05:53 UTC Check cancelled

vitstn
vitstn reviewed Feb 1, 2024
View reviewed changes
ydb/library/yql/sql/pg/pg_sql.cpp Outdated
@@ -2091,8 +2091,8 @@ class TConverter : public IPGParseEvents {
AddError(TStringBuilder() << "VariableSetStmt, set_config doesn't support that option:" << name);
return nullptr;
}
if (rawStr != "pg_catalog" && rawStr != "public") {
AddError(TStringBuilder() << "VariableSetStmt, search path supports only public and pg_catalogue, but got :" << rawStr);
if (rawStr != "pg_catalog" && rawStr != "public" && rawStr != "") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add information_schema too

@MrLolthe1st MrLolthe1st requested a review from vitstn February 1, 2024 15:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024 •
edited
Loading

⚪ 2024-02-01 15:06:51 UTC Pre-commit check for c9b2601 has started.
⚪ 2024-02-01 15:06:53 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-01 15:09:12 UTC Build successful.
⚪ 2024-02-01 15:09:25 UTC Tests are running...
🟢 2024-02-01 16:22:59 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58833 49524 0 0 9270 39

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024 •
edited
Loading

⚪ 2024-02-01 15:08:36 UTC Pre-commit check for c9b2601 has started.
⚪ 2024-02-01 15:08:41 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-01 15:10:54 UTC Build successful.
⚪ 2024-02-01 15:11:07 UTC Tests are running...
🔴 2024-02-01 16:08:09 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14516 14364 0 33 61 58

@MrLolthe1st MrLolthe1st merged commit 11954b0 into ydb-platform:main Feb 2, 2024
This was referenced Feb 2, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 3, 2024
Merged
@FloatingCrowbar FloatingCrowbar mentioned this pull request Feb 4, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 4, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Closed
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 6, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 7, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitstn vitstn vitstn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrLolthe1st @vitstn