Skip to content

Conversation

@StekPerepolnen
Copy link
Collaborator

@StekPerepolnen StekPerepolnen commented Feb 27, 2025

Changelog entry

after the commit #13316, a poller actor is needed in oidc_proxy and meta. Without this, the build hangs and does not work.

Changelog category

  • Bugfix

Description for reviewers

@github-actions
Copy link

github-actions bot commented Feb 27, 2025

2025-02-27 10:53:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8acc7e6 has started.
2025-02-27 10:53:30 UTC Artifacts will be uploaded here
2025-02-27 10:55:50 UTC ya make is running...
🟢 2025-02-27 10:56:55 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31 31 0 0 0 0

🟢 2025-02-27 10:57:02 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Feb 27, 2025

🔴 2025-02-27 12:27:25 UTC The validation of the Pull Request description has failed. Please update the description.

Bugfix requires a linked issue in the changelog entry

@github-actions
Copy link

github-actions bot commented Feb 27, 2025

2025-02-27 10:53:27 UTC Pre-commit check linux-x86_64-release-asan for 8acc7e6 has started.
2025-02-27 10:53:44 UTC Artifacts will be uploaded here
2025-02-27 10:56:06 UTC ya make is running...
🟢 2025-02-27 10:57:04 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31 31 0 0 0 0

🟢 2025-02-27 10:57:11 UTC Build successful.

@StekPerepolnen StekPerepolnen changed the title oidc bad images oidc add poller actor Feb 27, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Feb 27, 2025
@UgnineSirdis
Copy link
Collaborator

We discussed that the task will be divided into two parts:

  1. Fix itself. This PR.
  2. Test whose absense caused the current problem that is fixed with this PR: in that test we setup real server that serves by http interface (not only actor one) and call simple command like ping. Setup of oidc proxy must be reusable and customizable in the future, the test will use this setup with several lines of code.

@github-actions github-actions bot added bugfix and removed bugfix labels Feb 27, 2025
@StekPerepolnen StekPerepolnen merged commit 78482df into ydb-platform:main Feb 27, 2025
19 of 26 checks passed
@StekPerepolnen StekPerepolnen deleted the oidc-bad-images branch February 27, 2025 12:28
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix changelog/f25-3 PR участвует в списке изменений

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants