Skip to content

Use autoconfig when used node_type or cpu_count #15045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ydb/core/driver_lib/run/kikimr_services_initializers.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -499,11 +499,17 @@ static TInterconnectSettings GetInterconnectSettings(const NKikimrConfig::TInter
return result;
}

bool NeedToUseAutoConfig(const NKikimrConfig::TActorSystemConfig& config) {
return config.GetUseAutoConfig()
|| config.HasNodeType()
|| config.HasCpuCount();
}

void TBasicServicesInitializer::InitializeServices(NActors::TActorSystemSetup* setup,
const NKikimr::TAppData* appData) {
bool hasASCfg = Config.HasActorSystemConfig();
if (!hasASCfg || Config.GetActorSystemConfig().GetUseAutoConfig()) {
bool useAutoConfig = !hasASCfg || NeedToUseAutoConfig(Config.GetActorSystemConfig());
if (useAutoConfig) {
bool isDynamicNode = appData->DynamicNameserviceConfig->MinDynamicNodeId <= NodeId;
NAutoConfigInitializer::ApplyAutoConfig(Config.MutableActorSystemConfig(), isDynamicNode);
}
Expand Down
Loading