Skip to content

fix compaction logic in case huge-deletion #15039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ivanmorozov333
Copy link
Collaborator

  • Bugfix

Copy link

🟢 2025-02-26 08:35:16 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 08:35:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 63bba70 has started.
2025-02-26 08:35:36 UTC Artifacts will be uploaded here
2025-02-26 08:38:30 UTC ya make is running...
🟡 2025-02-26 09:33:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18819 17449 0 5 1230 135

2025-02-26 09:35:17 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-26 09:53:37 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
220 (only retried tests) 88 0 0 3 129

🟢 2025-02-26 09:53:44 UTC Build successful.
🟢 2025-02-26 09:54:04 UTC ydbd size 2.1 GiB changed* by -7.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: a378163 merge: 63bba70 diff diff %
ydbd size 2 263 579 104 Bytes 2 263 571 976 Bytes -7.0 KiB -0.000%
ydbd stripped size 477 117 880 Bytes 477 116 600 Bytes -1.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 08:37:28 UTC Pre-commit check linux-x86_64-release-asan for 63bba70 has started.
2025-02-26 08:37:41 UTC Artifacts will be uploaded here
2025-02-26 08:40:40 UTC ya make is running...
🟡 2025-02-26 09:49:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11583 11500 0 23 28 32

2025-02-26 09:50:53 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-26 10:03:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
123 (only retried tests) 90 0 1 2 30

2025-02-26 10:03:10 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-26 10:14:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
62 (only retried tests) 31 0 1 1 29

🟢 2025-02-26 10:14:57 UTC Build successful.
🟢 2025-02-26 10:15:26 UTC ydbd size 3.7 GiB changed* by -13.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: a378163 merge: 63bba70 diff diff %
ydbd size 3 942 835 520 Bytes 3 942 821 256 Bytes -13.9 KiB -0.000%
ydbd stripped size 1 374 042 544 Bytes 1 374 038 960 Bytes -3.5 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review February 26, 2025 11:20
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner February 26, 2025 11:20
@ivanmorozov333 ivanmorozov333 merged commit 7cc0d9b into ydb-platform:main Feb 26, 2025
14 checks passed
@ivanmorozov333 ivanmorozov333 deleted the fix_compaction_logic branch February 26, 2025 11:21
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants