Skip to content

Remove legacy kv api (#10614) #15004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 6, 2025
Merged

Remove legacy kv api (#10614) #15004

merged 3 commits into from
Mar 6, 2025

Conversation

mregrock
Copy link
Collaborator

Remove legacy KV API and LocalEnumerateTablets

Changelog entry

Remove legacy KV API and LocalEnumerateTablets

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@mregrock mregrock marked this pull request as draft February 25, 2025 12:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

🟢 2025-03-06 14:40:41 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

⚪ 2025-02-25 12:38:14 UTC Pre-commit check linux-x86_64-release-asan for e0d00a6 has started.
⚪ 2025-02-25 12:38:45 UTC Artifacts will be uploaded here
🔴 2025-02-25 12:41:12 UTC Graph compare failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

⚪ 2025-02-25 12:39:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for e0d00a6 has started.
⚪ 2025-02-25 12:47:25 UTC Artifacts will be uploaded here
🔴 2025-02-25 12:49:19 UTC Graph compare failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

⚪ 2025-02-25 12:53:46 UTC Pre-commit check linux-x86_64-release-asan for bb67092 has started.
⚪ 2025-02-25 12:54:19 UTC Artifacts will be uploaded here
⚪ 2025-02-25 12:57:35 UTC ya make is running...
🟡 2025-02-25 14:32:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13871 13780 0 48 9 34

⚪ 2025-02-25 14:34:19 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-25 14:54:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
138 (only retried tests) 101 0 1 6 30

⚪ 2025-02-25 14:54:53 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-25 15:07:09 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
64 (only retried tests) 29 0 0 4 31

🟢 2025-02-25 15:07:17 UTC Build successful.
🟢 2025-02-25 15:07:53 UTC ydbd size 3.6 GiB changed* by -939.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9029d02 merge: bb67092 diff diff %
ydbd size 3 900 116 896 Bytes 3 899 154 736 Bytes -939.6 KiB -0.025%
ydbd stripped size 1 365 335 376 Bytes 1 365 001 328 Bytes -326.2 KiB -0.024%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

⚪ 2025-02-25 13:00:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for bb67092 has started.
⚪ 2025-02-25 13:00:31 UTC Artifacts will be uploaded here
⚪ 2025-02-25 13:03:40 UTC ya make is running...
🟡 2025-02-25 14:30:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28249 25646 0 5 2464 134

⚪ 2025-02-25 14:33:20 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-25 14:56:11 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
212 (only retried tests) 81 0 0 4 127

🟢 2025-02-25 14:56:19 UTC Build successful.
🟢 2025-02-25 14:56:44 UTC ydbd size 2.1 GiB changed* by -588.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9029d02 merge: bb67092 diff diff %
ydbd size 2 243 209 832 Bytes 2 242 607 608 Bytes -588.1 KiB -0.027%
ydbd stripped size 474 901 528 Bytes 474 783 384 Bytes -115.4 KiB -0.025%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@mregrock mregrock marked this pull request as ready for review February 25, 2025 19:21
@mregrock mregrock marked this pull request as draft February 25, 2025 19:52
@mregrock mregrock force-pushed the remove_kv_api_finally branch from e650a64 to 68eb8d7 Compare March 5, 2025 10:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

⚪ 2025-03-05 10:13:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for d083ff0 has started.
⚪ 2025-03-05 10:14:00 UTC Artifacts will be uploaded here
⚪ 2025-03-05 10:17:01 UTC ya make is running...
🟡 2025-03-05 11:41:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28117 25527 0 1 2467 122

⚪ 2025-03-05 11:44:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-05 12:02:12 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
177 (only retried tests) 67 0 0 0 110

🟢 2025-03-05 12:02:23 UTC Build successful.
🟢 2025-03-05 12:02:46 UTC ydbd size 2.1 GiB changed* by -597.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6ef51f6 merge: d083ff0 diff diff %
ydbd size 2 290 082 720 Bytes 2 289 470 520 Bytes -597.9 KiB -0.027%
ydbd stripped size 479 951 936 Bytes 479 828 992 Bytes -120.1 KiB -0.026%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

⚪ 2025-03-05 10:14:08 UTC Pre-commit check linux-x86_64-release-asan for d083ff0 has started.
⚪ 2025-03-05 10:14:22 UTC Artifacts will be uploaded here
⚪ 2025-03-05 10:17:32 UTC ya make is running...
🟡 2025-03-05 12:02:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13710 13564 0 83 29 34

⚪ 2025-03-05 12:04:25 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-05 12:19:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
205 (only retried tests) 166 0 5 2 32

⚪ 2025-03-05 12:19:46 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-05 12:35:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68 (only retried tests) 35 0 1 0 32

🟢 2025-03-05 12:35:24 UTC Build successful.
🟢 2025-03-05 12:35:54 UTC ydbd size 3.7 GiB changed* by -951.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6ef51f6 merge: d083ff0 diff diff %
ydbd size 3 990 859 216 Bytes 3 989 885 120 Bytes -951.3 KiB -0.024%
ydbd stripped size 1 388 993 096 Bytes 1 388 655 592 Bytes -329.6 KiB -0.024%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@mregrock mregrock marked this pull request as ready for review March 5, 2025 10:56
@mregrock mregrock changed the title Legacy kv api remove (#10614) Remove legacy kv api (#10614) Mar 6, 2025
the-ancient-1
the-ancient-1 approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@the-ancient-1 the-ancient-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mregrock mregrock merged commit c2244f7 into ydb-platform:main Mar 6, 2025
14 checks passed
@serbel324 serbel324 mentioned this pull request Mar 10, 2025
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 11, 2025
Merged
@serbel324 serbel324 mentioned this pull request Mar 13, 2025
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@mregrock @blinkov
Remove legacy kv api (#10614) (#15004)
0d36836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-ancient-1 the-ancient-1 the-ancient-1 approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mregrock @the-ancient-1