Skip to content

Conversation

@maximyurchuk
Copy link
Collaborator

@maximyurchuk maximyurchuk commented Feb 21, 2025

embedded breakpad not working properly, we will investiagate this problem later
KIKIMR-18829

Information from @snaury:

У меня на слайсе стоит пакет с breakpad'ом, и на старте используется LD_PRELOAD=/usr/lib/libbreakpad_init.so, к сожалению с asan сборкой возникли проблемы, во время периодической остановки процессов стреляют странные ошибки:

paste.yandex-team.ru/2644904d-c8eb-4f10-8d7a-781e1279268a
paste.yandex-team.ru/a153f07f-4492-427d-874b-90c09f362c26

Если убрать ydb/library/breakpad из ya.make для ydbd, то ошибки уходят.

Я попытался сделать создание ExceptionHandler'а условным, типа при наличии libbreakpad_init.so в загруженных библиотеках - никакие хендлеры не создавать:

snaury@c18da16

После этого ошибки от asan'а уходят, однако процессы на остановке очень странно зависают вот в этом потоке:

https://github.com/ydb-platform/ydb/blob/main/library/cpp/sighandler/async_signals_handler.cpp#L101

Он остаётся единственный и процесс висит. Я вижу, что этот обработчик у нас устанавливается вот здесь:

TLogBackend::ReopenAllBackends();

Что висит пока понять не могу, т.к. asan сборку приходится делать без дебажных символов и gdb ничего не показывает.

Есть подозрение, что libbreakpad_init.so и ydbd всё-равно каким-то образом шарят символы и что-то неожиданным образом всё-равно ломается. В сборке без санитайзера и без встроенного breakpad'а таких проблем нет.

@github-actions
Copy link

github-actions bot commented Feb 21, 2025

🟢 2025-02-24 18:27:57 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Feb 21, 2025

2025-02-21 16:15:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3f64b4e has started.
2025-02-21 16:17:19 UTC Artifacts will be uploaded here
2025-02-21 16:19:43 UTC ya make is running...
🟡 2025-02-21 16:59:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4664 4539 0 2 36 87

2025-02-21 16:59:56 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-21 17:12:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
104 (only retried tests) 24 0 2 1 77

2025-02-21 17:13:03 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-21 17:18:37 UTC ydbd size 2.1 GiB changed* by -237.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3a1c845 merge: 3f64b4e diff diff %
ydbd size 2 241 792 328 Bytes 2 241 548 936 Bytes -237.7 KiB -0.011%
ydbd stripped size 474 864 792 Bytes 474 783 160 Bytes -79.7 KiB -0.017%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2025-02-21 17:18:39 UTC Check cancelled

snaury
snaury previously approved these changes Feb 21, 2025
@maximyurchuk maximyurchuk changed the title stable-25-1: disable breakpad integration temporarly stable-25-1: disable breakpad integration temporarily Feb 21, 2025
@github-actions
Copy link

github-actions bot commented Feb 21, 2025

2025-02-21 16:24:13 UTC Pre-commit check linux-x86_64-release-asan for 3f64b4e has started.
2025-02-21 16:24:28 UTC Artifacts will be uploaded here
2025-02-21 16:26:57 UTC ya make is running...
🟡 2025-02-21 16:58:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1627 1606 0 6 6 9

2025-02-21 16:59:00 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-21 17:12:52 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25 (only retried tests) 14 0 0 1 10

🟢 2025-02-21 17:13:03 UTC Build successful.
🟢 2025-02-21 17:13:19 UTC ydbd size 3.6 GiB changed* by -439.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f330cca merge: 3f64b4e diff diff %
ydbd size 3 899 694 352 Bytes 3 899 244 216 Bytes -439.6 KiB -0.012%
ydbd stripped size 1 365 007 360 Bytes 1 364 773 424 Bytes -228.5 KiB -0.017%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 21, 2025

2025-02-21 17:19:30 UTC Pre-commit check linux-x86_64-release-asan for 18e0309 has started.
2025-02-21 17:19:42 UTC Artifacts will be uploaded here
2025-02-21 17:22:13 UTC ya make is running...
🟡 2025-02-21 17:48:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1627 1601 0 5 9 12

2025-02-21 17:48:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-21 17:59:55 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31 (only retried tests) 19 0 0 4 8

🟢 2025-02-21 18:00:02 UTC Build successful.
🟢 2025-02-21 18:00:18 UTC ydbd size 3.6 GiB changed* by -433.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: c48bfb6 merge: 18e0309 diff diff %
ydbd size 3 899 692 536 Bytes 3 899 249 000 Bytes -433.1 KiB -0.011%
ydbd stripped size 1 365 006 208 Bytes 1 364 774 448 Bytes -226.3 KiB -0.017%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 21, 2025

2025-02-21 17:22:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 18e0309 has started.
2025-02-21 17:23:00 UTC Artifacts will be uploaded here
2025-02-21 17:25:32 UTC ya make is running...
🟢 2025-02-21 17:50:35 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4657 4527 0 0 45 85

🟢 2025-02-21 17:51:20 UTC Build successful.
🟢 2025-02-21 17:51:31 UTC ydbd size 2.1 GiB changed* by -238.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: c48bfb6 merge: 18e0309 diff diff %
ydbd size 2 241 795 752 Bytes 2 241 551 624 Bytes -238.4 KiB -0.011%
ydbd stripped size 474 865 368 Bytes 474 783 448 Bytes -80.0 KiB -0.017%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk merged commit 6c53efd into ydb-platform:main Feb 21, 2025
12 checks passed
maximyurchuk added a commit to maximyurchuk/ydb that referenced this pull request Feb 24, 2025
@maximyurchuk maximyurchuk changed the title stable-25-1: disable breakpad integration temporarily main: disable breakpad integration temporarily Feb 24, 2025
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
maximyurchuk added a commit to maximyurchuk/ydb that referenced this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants