Skip to content

Don't replace EvWrite/ProposeTx in tests #14898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 21, 2025
Merged

Don't replace EvWrite/ProposeTx in tests #14898

merged 3 commits into from
Feb 21, 2025

Conversation

nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented Feb 21, 2025

Changelog entry

.Get rid of replacing EvWrite in tests

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@nikvas0 nikvas0 requested a review from azevaykin February 21, 2025 11:46
@nikvas0 nikvas0 changed the title Get rid of replacing EvWrite/ProposeTx in tests Don't replace EvWrite/ProposeTx in tests Feb 21, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2025 •
edited
Loading

🟢 2025-02-21 12:30:08 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2025 •
edited
Loading

⚪ 2025-02-21 12:29:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 495997b has started.
⚪ 2025-02-21 12:30:07 UTC Artifacts will be uploaded here
⚪ 2025-02-21 12:32:28 UTC ya make is running...
🟢 2025-02-21 12:46:15 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1777 1752 0 0 0 25

🟢 2025-02-21 12:46:35 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2025 •
edited
Loading

⚪ 2025-02-21 12:29:36 UTC Pre-commit check linux-x86_64-release-asan for 495997b has started.
⚪ 2025-02-21 12:31:48 UTC Artifacts will be uploaded here
⚪ 2025-02-21 12:34:11 UTC ya make is running...
🟡 2025-02-21 12:46:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1342 1339 0 1 0 2

⚪ 2025-02-21 12:46:23 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-21 12:49:08 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6 (only retried tests) 4 0 0 0 2

🟢 2025-02-21 12:49:15 UTC Build successful.

azevaykin
azevaykin previously approved these changes Feb 21, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2025 •
edited
Loading

⚪ 2025-02-21 13:40:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2899bab has started.
⚪ 2025-02-21 13:41:23 UTC Artifacts will be uploaded here
⚪ 2025-02-21 13:43:42 UTC ya make is running...
🟡 2025-02-21 13:57:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1777 1750 0 2 0 25

⚪ 2025-02-21 13:58:04 UTC ya make is running... (failed tests rerun, try 2)
⚫ 2025-02-21 13:59:06 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2025 •
edited
Loading

⚪ 2025-02-21 13:40:45 UTC Pre-commit check linux-x86_64-release-asan for 2899bab has started.
⚪ 2025-02-21 13:42:12 UTC Artifacts will be uploaded here
⚪ 2025-02-21 13:44:41 UTC ya make is running...
🟡 2025-02-21 13:57:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1342 1338 0 2 0 2

⚪ 2025-02-21 13:57:42 UTC ya make is running... (failed tests rerun, try 2)
⚫ 2025-02-21 13:59:08 UTC Check cancelled

@nikvas0 nikvas0 requested a review from a team as a code owner February 21, 2025 13:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2025 •
edited
Loading

⚪ 2025-02-21 14:07:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 388b094 has started.
⚪ 2025-02-21 14:14:12 UTC Artifacts will be uploaded here
⚪ 2025-02-21 14:17:00 UTC ya make is running...
🟢 2025-02-21 15:09:24 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19152 17799 0 0 1220 133

🟢 2025-02-21 15:12:05 UTC Build successful.
🟢 2025-02-21 15:12:20 UTC ydbd size 2.1 GiB changed* by -4.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 147c972 merge: 388b094 diff diff %
ydbd size 2 241 796 728 Bytes 2 241 792 328 Bytes -4.3 KiB -0.000%
ydbd stripped size 474 865 816 Bytes 474 864 792 Bytes -1.0 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2025 •
edited
Loading

⚪ 2025-02-21 14:13:44 UTC Pre-commit check linux-x86_64-release-asan for 388b094 has started.
⚪ 2025-02-21 14:14:21 UTC Artifacts will be uploaded here
⚪ 2025-02-21 14:17:54 UTC ya make is running...
🟡 2025-02-21 15:20:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11836 11745 0 45 11 35

⚪ 2025-02-21 15:22:27 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-21 15:34:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
142 (only retried tests) 101 0 1 7 33

⚪ 2025-02-21 15:35:10 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-21 15:53:25 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70 (only retried tests) 34 0 0 4 32

🟢 2025-02-21 15:53:36 UTC Build successful.
🟢 2025-02-21 15:54:09 UTC ydbd size 3.6 GiB changed* by -176 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: f330cca merge: 388b094 diff diff %
ydbd size 3 899 694 352 Bytes 3 899 694 176 Bytes -176 Bytes -0.000%
ydbd stripped size 1 365 007 360 Bytes 1 365 007 232 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 enabled auto-merge (squash) February 21, 2025 14:21
@nikvas0 nikvas0 merged commit 3a1c845 into ydb-platform:main Feb 21, 2025
12 checks passed
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 23, 2025
Merged
@serbel324 serbel324 mentioned this pull request Feb 25, 2025
Merged
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@nikvas0
Don't replace EvWrite/ProposeTx in tests (ydb-platform#14898)
6df38a2
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Closed
This was referenced Mar 10, 2025
Merged
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@nikvas0 @blinkov
Don't replace EvWrite/ProposeTx in tests (#14898)
1174cdd
nikvas0 added a commit to nikvas0/ydb that referenced this pull request Mar 31, 2025
@nikvas0
Don't replace EvWrite/ProposeTx in tests (ydb-platform#14898)
0852191
dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Apr 19, 2025
@nikvas0 @dorooleg
Don't replace EvWrite/ProposeTx in tests (ydb-platform#14898)
b5c7338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gridnevvvit gridnevvvit gridnevvvit approved these changes

@azevaykin azevaykin azevaykin approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikvas0 @gridnevvvit @azevaykin