Skip to content

Conversation

@UgnineSirdis
Copy link
Collaborator

Changelog entry

Refactor two S3Buffers into one that supports all features. It allows to use different combinations of checksums, compression and encryption parameters for serialization of export data.

Changelog category

  • Improvement

Description for reviewers

...

@github-actions
Copy link

🟢 2025-02-20 17:22:14 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Feb 20, 2025

2025-02-20 17:24:50 UTC Pre-commit check linux-x86_64-release-asan for 7ac713b has started.
2025-02-20 17:25:38 UTC Artifacts will be uploaded here
2025-02-20 17:28:29 UTC ya make is running...
🟡 2025-02-20 18:34:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11837 11768 0 15 19 35

2025-02-20 18:36:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-20 18:49:23 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 63 0 0 3 32

🟢 2025-02-20 18:49:30 UTC Build successful.
🟢 2025-02-20 18:49:56 UTC ydbd size 3.6 GiB changed* by -31.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 90a6e27 merge: 7ac713b diff diff %
ydbd size 3 895 668 280 Bytes 3 895 635 792 Bytes -31.7 KiB -0.001%
ydbd stripped size 1 364 068 448 Bytes 1 364 069 248 Bytes +800 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 20, 2025

2025-02-20 17:34:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7ac713b has started.
2025-02-20 17:34:39 UTC Artifacts will be uploaded here
2025-02-20 17:37:37 UTC ya make is running...
🟢 2025-02-20 18:35:48 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19149 17784 0 0 1227 138

🟢 2025-02-20 18:38:03 UTC Build successful.
🟢 2025-02-20 18:38:22 UTC ydbd size 2.1 GiB changed* by -33.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: bd6334d merge: 7ac713b diff diff %
ydbd size 2 239 517 968 Bytes 2 239 483 216 Bytes -33.9 KiB -0.002%
ydbd stripped size 474 552 088 Bytes 474 551 320 Bytes -768 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 20, 2025

2025-02-20 21:28:12 UTC Pre-commit check linux-x86_64-release-asan for dac1231 has started.
2025-02-20 21:30:12 UTC Artifacts will be uploaded here
2025-02-20 21:33:42 UTC ya make is running...
🟡 2025-02-20 22:48:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11837 11772 0 14 14 37

2025-02-20 22:49:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-20 23:07:07 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
95 (only retried tests) 59 0 0 4 32

🟢 2025-02-20 23:07:14 UTC Build successful.
🟢 2025-02-20 23:07:41 UTC ydbd size 3.6 GiB changed* by -44.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 555fbb8 merge: dac1231 diff diff %
ydbd size 3 896 864 936 Bytes 3 896 819 168 Bytes -44.7 KiB -0.001%
ydbd stripped size 1 364 380 864 Bytes 1 364 379 072 Bytes -1.8 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 20, 2025

2025-02-20 21:29:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for dac1231 has started.
2025-02-20 21:29:16 UTC Artifacts will be uploaded here
2025-02-20 21:32:05 UTC ya make is running...
🟢 2025-02-20 22:32:36 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19149 17800 0 0 1216 133

🟢 2025-02-20 22:34:17 UTC Build successful.
🟢 2025-02-20 22:34:32 UTC ydbd size 2.1 GiB changed* by -34.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 555fbb8 merge: dac1231 diff diff %
ydbd size 2 240 049 416 Bytes 2 240 014 624 Bytes -34.0 KiB -0.002%
ydbd stripped size 474 639 512 Bytes 474 638 744 Bytes -768 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL requested a review from pixcc February 21, 2025 07:45
@UgnineSirdis UgnineSirdis merged commit 499b85e into ydb-platform:main Feb 21, 2025
12 checks passed
@UgnineSirdis UgnineSirdis deleted the refactor-export-s3-buffer branch February 21, 2025 07:48
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Apr 21, 2025
…binations of checksums, compression and encryption (ydb-platform#14862)"

This reverts commit 499b85e.
UgnineSirdis added a commit that referenced this pull request Apr 21, 2025
…binations of checksums, compression and encryption (#14862)" (#17506)
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Apr 22, 2025
…binations of checksums, compression and encryption (ydb-platform#14862)"

This reverts commit 499b85e.
UgnineSirdis added a commit that referenced this pull request Apr 22, 2025
…binations of checksums, compression and encryption (#14862)" (#17524)
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Jun 10, 2025
…s of checksums, compression and encryption (ydb-platform#14862)

(cherry picked from commit 499b85e)
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Jun 11, 2025
…s of checksums, compression and encryption (ydb-platform#14862)

(cherry picked from commit 499b85e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants