Skip to content

Avoid persistent and in-memory tx status getting out-of-sync #14781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

snaury
Copy link
Member

@snaury snaury commented Feb 19, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

It was discovered that in certain situation tx status parts and in-memory state may diverge, allowing transaction ids to be reused, which would unexpectedly become committed or removed after a restart. Make sure in-memory state doesn't diverge from the state that could be restored from disk on restart.

Fixes KIKIMR-22538.

@snaury snaury self-assigned this Feb 19, 2025
Copy link

🟢 2025-02-19 11:46:33 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Feb 19, 2025

2025-02-19 11:49:28 UTC Pre-commit check linux-x86_64-release-asan for 7b64127 has started.
2025-02-19 11:49:40 UTC Artifacts will be uploaded here
2025-02-19 11:52:43 UTC ya make is running...
🟡 2025-02-19 13:15:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13570 13494 0 21 16 39

2025-02-19 13:16:43 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-19 13:35:37 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
116 (only retried tests) 79 0 0 5 32

🟢 2025-02-19 13:35:47 UTC Build successful.
🟢 2025-02-19 13:36:14 UTC ydbd size 3.6 GiB changed* by +52.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2872539 merge: 7b64127 diff diff %
ydbd size 3 893 387 816 Bytes 3 893 441 392 Bytes +52.3 KiB +0.001%
ydbd stripped size 1 363 137 728 Bytes 1 363 160 928 Bytes +22.7 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 19, 2025

2025-02-19 11:55:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7b64127 has started.
2025-02-19 11:55:30 UTC Artifacts will be uploaded here
2025-02-19 11:59:15 UTC ya make is running...
🟡 2025-02-19 13:21:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27768 25172 0 1 2462 133

2025-02-19 13:24:18 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-19 13:52:10 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
205 (only retried tests) 76 0 0 2 127

🟢 2025-02-19 13:52:18 UTC Build successful.
🟢 2025-02-19 13:52:39 UTC ydbd size 2.1 GiB changed* by +59.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2872539 merge: 7b64127 diff diff %
ydbd size 2 238 223 232 Bytes 2 238 284 536 Bytes +59.9 KiB +0.003%
ydbd stripped size 474 291 928 Bytes 474 312 600 Bytes +20.2 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury marked this pull request as ready for review February 20, 2025 07:44
@snaury snaury requested a review from azevaykin February 20, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants